| Message ID | 20191009014707.38716-1-maowenan@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | da4b5d18dd949abdda7c8ea76c9483b5edd49616 |
| Headers | show |
| Series | [-next] usb: typec: add dependency for TYPEC_HD3SS3220 | expand |
Hello Mao Wenan, Thanks for the patch. > Subject: [PATCH -next] usb: typec: add dependency for TYPEC_HD3SS3220 > > If CONFIG_TYPEC_HD3SS3220=y, CONFIG_USB_ROLE_SWITCH=m, below > errors can be found: > drivers/usb/typec/hd3ss3220.o: In function `hd3ss3220_remove': > hd3ss3220.c:(.text+0x64): undefined reference to `usb_role_switch_put' > drivers/usb/typec/hd3ss3220.o: In function `hd3ss3220_dr_set': > hd3ss3220.c:(.text+0x154): undefined reference to > `usb_role_switch_set_role' > drivers/usb/typec/hd3ss3220.o: In function `hd3ss3220_set_role': > hd3ss3220.c:(.text+0x294): undefined reference to > `usb_role_switch_set_role' > hd3ss3220.c:(.text+0x2f4): undefined reference to > `usb_role_switch_set_role' > hd3ss3220.c:(.text+0x348): undefined reference to > `usb_role_switch_set_role' > hd3ss3220.c:(.text+0x390): undefined reference to > `usb_role_switch_set_role' > drivers/usb/typec/hd3ss3220.o: In function `hd3ss3220_probe': > hd3ss3220.c:(.text+0x5e8): undefined reference to > `fwnode_usb_role_switch_get' > hd3ss3220.c:(.text+0x8a4): undefined reference to `usb_role_switch_put' > make: *** [vmlinux] Error 1 > > This patch add dependency USB_ROLE_SWITCH for TYPEC_HD3SS3220. > > Fixes: 1c48c759ef4b ("usb: typec: driver for TI HD3SS3220 USB Type-C DRP > port controller") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Mao Wenan <maowenan@huawei.com> Reviewed-by: Biju Das <biju.das@bp.renesas.com> Regards, Biju > --- > drivers/usb/typec/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig index > aceb2af..b4f2aac 100644 > --- a/drivers/usb/typec/Kconfig > +++ b/drivers/usb/typec/Kconfig > @@ -53,6 +53,7 @@ source "drivers/usb/typec/ucsi/Kconfig" > config TYPEC_HD3SS3220 > tristate "TI HD3SS3220 Type-C DRP Port controller driver" > depends on I2C > + depends on USB_ROLE_SWITCH > help > Say Y or M here if your system has TI HD3SS3220 Type-C DRP Port > controller driver. > -- > 2.7.4
On Wed, Oct 09, 2019 at 09:47:07AM +0800, Mao Wenan wrote: > If CONFIG_TYPEC_HD3SS3220=y, CONFIG_USB_ROLE_SWITCH=m, below errors > can be found: > drivers/usb/typec/hd3ss3220.o: In function `hd3ss3220_remove': > hd3ss3220.c:(.text+0x64): undefined reference to `usb_role_switch_put' > drivers/usb/typec/hd3ss3220.o: In function `hd3ss3220_dr_set': > hd3ss3220.c:(.text+0x154): undefined reference to `usb_role_switch_set_role' > drivers/usb/typec/hd3ss3220.o: In function `hd3ss3220_set_role': > hd3ss3220.c:(.text+0x294): undefined reference to `usb_role_switch_set_role' > hd3ss3220.c:(.text+0x2f4): undefined reference to `usb_role_switch_set_role' > hd3ss3220.c:(.text+0x348): undefined reference to `usb_role_switch_set_role' > hd3ss3220.c:(.text+0x390): undefined reference to `usb_role_switch_set_role' > drivers/usb/typec/hd3ss3220.o: In function `hd3ss3220_probe': > hd3ss3220.c:(.text+0x5e8): undefined reference to `fwnode_usb_role_switch_get' > hd3ss3220.c:(.text+0x8a4): undefined reference to `usb_role_switch_put' > make: *** [vmlinux] Error 1 > > This patch add dependency USB_ROLE_SWITCH for TYPEC_HD3SS3220. > > Fixes: 1c48c759ef4b ("usb: typec: driver for TI HD3SS3220 USB Type-C DRP port controller") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Mao Wenan <maowenan@huawei.com> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/typec/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig > index aceb2af..b4f2aac 100644 > --- a/drivers/usb/typec/Kconfig > +++ b/drivers/usb/typec/Kconfig > @@ -53,6 +53,7 @@ source "drivers/usb/typec/ucsi/Kconfig" > config TYPEC_HD3SS3220 > tristate "TI HD3SS3220 Type-C DRP Port controller driver" > depends on I2C > + depends on USB_ROLE_SWITCH > help > Say Y or M here if your system has TI HD3SS3220 Type-C DRP Port > controller driver. > -- > 2.7.4 thanks,
kindly ping. On 2019/10/9 9:47, Mao Wenan wrote: > If CONFIG_TYPEC_HD3SS3220=y, CONFIG_USB_ROLE_SWITCH=m, below errors > can be found: > drivers/usb/typec/hd3ss3220.o: In function `hd3ss3220_remove': > hd3ss3220.c:(.text+0x64): undefined reference to `usb_role_switch_put' > drivers/usb/typec/hd3ss3220.o: In function `hd3ss3220_dr_set': > hd3ss3220.c:(.text+0x154): undefined reference to `usb_role_switch_set_role' > drivers/usb/typec/hd3ss3220.o: In function `hd3ss3220_set_role': > hd3ss3220.c:(.text+0x294): undefined reference to `usb_role_switch_set_role' > hd3ss3220.c:(.text+0x2f4): undefined reference to `usb_role_switch_set_role' > hd3ss3220.c:(.text+0x348): undefined reference to `usb_role_switch_set_role' > hd3ss3220.c:(.text+0x390): undefined reference to `usb_role_switch_set_role' > drivers/usb/typec/hd3ss3220.o: In function `hd3ss3220_probe': > hd3ss3220.c:(.text+0x5e8): undefined reference to `fwnode_usb_role_switch_get' > hd3ss3220.c:(.text+0x8a4): undefined reference to `usb_role_switch_put' > make: *** [vmlinux] Error 1 > > This patch add dependency USB_ROLE_SWITCH for TYPEC_HD3SS3220. > > Fixes: 1c48c759ef4b ("usb: typec: driver for TI HD3SS3220 USB Type-C DRP port controller") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Mao Wenan <maowenan@huawei.com> > --- > drivers/usb/typec/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig > index aceb2af..b4f2aac 100644 > --- a/drivers/usb/typec/Kconfig > +++ b/drivers/usb/typec/Kconfig > @@ -53,6 +53,7 @@ source "drivers/usb/typec/ucsi/Kconfig" > config TYPEC_HD3SS3220 > tristate "TI HD3SS3220 Type-C DRP Port controller driver" > depends on I2C > + depends on USB_ROLE_SWITCH > help > Say Y or M here if your system has TI HD3SS3220 Type-C DRP Port > controller driver. >
This patch is present in both usb-next and Linux-next. https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id=da4b5d18dd949abdda7c8ea76c9483b5edd49616 https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20191016&id=da4b5d18dd949abdda7c8ea76c9483b5edd49616 Cheers, Biju > Subject: Re: [PATCH -next] usb: typec: add dependency for > TYPEC_HD3SS3220 > > kindly ping. > > On 2019/10/9 9:47, Mao Wenan wrote: > > If CONFIG_TYPEC_HD3SS3220=y, CONFIG_USB_ROLE_SWITCH=m, below > errors > > can be found: > > drivers/usb/typec/hd3ss3220.o: In function `hd3ss3220_remove': > > hd3ss3220.c:(.text+0x64): undefined reference to `usb_role_switch_put' > > drivers/usb/typec/hd3ss3220.o: In function `hd3ss3220_dr_set': > > hd3ss3220.c:(.text+0x154): undefined reference to > `usb_role_switch_set_role' > > drivers/usb/typec/hd3ss3220.o: In function `hd3ss3220_set_role': > > hd3ss3220.c:(.text+0x294): undefined reference to > `usb_role_switch_set_role' > > hd3ss3220.c:(.text+0x2f4): undefined reference to > `usb_role_switch_set_role' > > hd3ss3220.c:(.text+0x348): undefined reference to > `usb_role_switch_set_role' > > hd3ss3220.c:(.text+0x390): undefined reference to > `usb_role_switch_set_role' > > drivers/usb/typec/hd3ss3220.o: In function `hd3ss3220_probe': > > hd3ss3220.c:(.text+0x5e8): undefined reference to > `fwnode_usb_role_switch_get' > > hd3ss3220.c:(.text+0x8a4): undefined reference to `usb_role_switch_put' > > make: *** [vmlinux] Error 1 > > > > This patch add dependency USB_ROLE_SWITCH for TYPEC_HD3SS3220. > > > > Fixes: 1c48c759ef4b ("usb: typec: driver for TI HD3SS3220 USB Type-C > > DRP port controller") > > Reported-by: Hulk Robot <hulkci@huawei.com> > > Signed-off-by: Mao Wenan <maowenan@huawei.com> > > --- > > drivers/usb/typec/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig > > index aceb2af..b4f2aac 100644 > > --- a/drivers/usb/typec/Kconfig > > +++ b/drivers/usb/typec/Kconfig > > @@ -53,6 +53,7 @@ source "drivers/usb/typec/ucsi/Kconfig" > > config TYPEC_HD3SS3220 > > tristate "TI HD3SS3220 Type-C DRP Port controller driver" > > depends on I2C > > + depends on USB_ROLE_SWITCH > > help > > Say Y or M here if your system has TI HD3SS3220 Type-C DRP Port > > controller driver. > >
diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig index aceb2af..b4f2aac 100644 --- a/drivers/usb/typec/Kconfig +++ b/drivers/usb/typec/Kconfig @@ -53,6 +53,7 @@ source "drivers/usb/typec/ucsi/Kconfig" config TYPEC_HD3SS3220 tristate "TI HD3SS3220 Type-C DRP Port controller driver" depends on I2C + depends on USB_ROLE_SWITCH help Say Y or M here if your system has TI HD3SS3220 Type-C DRP Port controller driver.
If CONFIG_TYPEC_HD3SS3220=y, CONFIG_USB_ROLE_SWITCH=m, below errors can be found: drivers/usb/typec/hd3ss3220.o: In function `hd3ss3220_remove': hd3ss3220.c:(.text+0x64): undefined reference to `usb_role_switch_put' drivers/usb/typec/hd3ss3220.o: In function `hd3ss3220_dr_set': hd3ss3220.c:(.text+0x154): undefined reference to `usb_role_switch_set_role' drivers/usb/typec/hd3ss3220.o: In function `hd3ss3220_set_role': hd3ss3220.c:(.text+0x294): undefined reference to `usb_role_switch_set_role' hd3ss3220.c:(.text+0x2f4): undefined reference to `usb_role_switch_set_role' hd3ss3220.c:(.text+0x348): undefined reference to `usb_role_switch_set_role' hd3ss3220.c:(.text+0x390): undefined reference to `usb_role_switch_set_role' drivers/usb/typec/hd3ss3220.o: In function `hd3ss3220_probe': hd3ss3220.c:(.text+0x5e8): undefined reference to `fwnode_usb_role_switch_get' hd3ss3220.c:(.text+0x8a4): undefined reference to `usb_role_switch_put' make: *** [vmlinux] Error 1 This patch add dependency USB_ROLE_SWITCH for TYPEC_HD3SS3220. Fixes: 1c48c759ef4b ("usb: typec: driver for TI HD3SS3220 USB Type-C DRP port controller") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Mao Wenan <maowenan@huawei.com> --- drivers/usb/typec/Kconfig | 1 + 1 file changed, 1 insertion(+)