| Message ID | 20191011093342.3471-1-boris.brezillon@collabora.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | media: rockchip: Add the rkvdec driver | expand |
On 10/11/19 11:33 AM, Boris Brezillon wrote: > Hello, > > Sorry for the noise, I forgot to Cc the DT maintainers/ML on my last > attempt. > > This is v2 of the rkvdec driver which was initially posted as part of > my RFC adding codec helpers. > For this version, I decided to get rid of the helper stuff which is > likely to take some more time to settle. The patchset now contains a > proper DT binding doc. > > Note that this implementation is likely to be adjusted based on the > outcome of the 'scaling matrix order' [1] and 'dynamic resolution > changes' [2] discussions, but I thought it'd be worth posting this > version to start getting feeback. I assume this version of the driver does not (yet?) support slicing? Core slicing support is part of this series: https://patchwork.linuxtv.org/cover/59415/ Regards, Hans > > Regards, > > Boris > > [1]https://patchwork.kernel.org/cover/11125207/ > [2]https://lkml.org/lkml/2019/9/3/1033 > > Boris Brezillon (4): > media: vb2: Add a helper to get the vb2 buffer attached to a request > media: dt-bindings: rockchip: Document RK3399 Video Decoder bindings > media: rockchip: Add the rkvdec driver > arm64: dts: rockchip: rk3399: Define the rockchip Video Decoder node > > .../bindings/media/rockchip,vdec.yaml | 71 ++ > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 14 +- > .../media/common/videobuf2/videobuf2-core.c | 23 + > drivers/staging/media/Kconfig | 2 + > drivers/staging/media/Makefile | 1 + > drivers/staging/media/rockchip/Kconfig | 16 + > drivers/staging/media/rockchip/Makefile | 2 + > drivers/staging/media/rockchip/vdec/Kconfig | 14 + > drivers/staging/media/rockchip/vdec/Makefile | 3 + > .../staging/media/rockchip/vdec/rkvdec-h264.c | 960 +++++++++++++++ > .../staging/media/rockchip/vdec/rkvdec-regs.h | 306 +++++ > drivers/staging/media/rockchip/vdec/rkvdec.c | 1089 +++++++++++++++++ > drivers/staging/media/rockchip/vdec/rkvdec.h | 131 ++ > include/media/videobuf2-core.h | 11 + > 14 files changed, 2642 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/media/rockchip,vdec.yaml > create mode 100644 drivers/staging/media/rockchip/Kconfig > create mode 100644 drivers/staging/media/rockchip/Makefile > create mode 100644 drivers/staging/media/rockchip/vdec/Kconfig > create mode 100644 drivers/staging/media/rockchip/vdec/Makefile > create mode 100644 drivers/staging/media/rockchip/vdec/rkvdec-h264.c > create mode 100644 drivers/staging/media/rockchip/vdec/rkvdec-regs.h > create mode 100644 drivers/staging/media/rockchip/vdec/rkvdec.c > create mode 100644 drivers/staging/media/rockchip/vdec/rkvdec.h >
On Fri, 11 Oct 2019 11:43:20 +0200 Hans Verkuil <hverkuil@xs4all.nl> wrote: > On 10/11/19 11:33 AM, Boris Brezillon wrote: > > Hello, > > > > Sorry for the noise, I forgot to Cc the DT maintainers/ML on my last > > attempt. > > > > This is v2 of the rkvdec driver which was initially posted as part of > > my RFC adding codec helpers. > > For this version, I decided to get rid of the helper stuff which is > > likely to take some more time to settle. The patchset now contains a > > proper DT binding doc. > > > > Note that this implementation is likely to be adjusted based on the > > outcome of the 'scaling matrix order' [1] and 'dynamic resolution > > changes' [2] discussions, but I thought it'd be worth posting this > > version to start getting feeback. > > I assume this version of the driver does not (yet?) support slicing? Nope, but the driver does not support SLICE_BASED decoding anyway, so I'm not sure slicing applies here.