diff mbox series

[v2,1/2] soundwire: depend on ACPI

Message ID bd685232ea511251eeb9554172f1524eabf9a46e.1570097621.git.msuchanek@suse.de (mailing list archive)
State New, archived
Headers show
Series [v2,1/2] soundwire: depend on ACPI | expand

Commit Message

Michal Suchanek Oct. 3, 2019, 10:13 a.m. UTC
The device cannot be probed on !ACPI and gives this warning:

drivers/soundwire/slave.c:16:12: warning: ‘sdw_slave_add’ defined but
not used [-Wunused-function]
 static int sdw_slave_add(struct sdw_bus *bus,
            ^~~~~~~~~~~~~

Cc: stable@vger.kernel.org
Fixes: 7c3cd189b86d ("soundwire: Add Master registration")
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
---
 drivers/soundwire/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Sasha Levin Oct. 6, 2019, 12:07 p.m. UTC | #1
Hi,

[This is an automated email]

This commit has been processed because it contains a "Fixes:" tag,
fixing commit: 7c3cd189b86d soundwire: Add Master registration.

The bot has tested the following trees: v5.3.2, v5.2.18, v4.19.76.

v5.3.2: Build OK!
v5.2.18: Failed to apply! Possible dependencies:
    8676b3ca4673 ("soundwire: fix regmap dependencies and align with other serial links")

v4.19.76: Failed to apply! Possible dependencies:
    8676b3ca4673 ("soundwire: fix regmap dependencies and align with other serial links")
    9d7cd9d50082 ("soundwire: Kconfig: fix help format")


NOTE: The patch will not be queued to stable trees until it is upstream.

How should we proceed with this patch?
Vinod Koul Oct. 15, 2019, 10:45 a.m. UTC | #2
On 03-10-19, 12:13, Michal Suchanek wrote:
> The device cannot be probed on !ACPI and gives this warning:
> 
> drivers/soundwire/slave.c:16:12: warning: ‘sdw_slave_add’ defined but
> not used [-Wunused-function]
>  static int sdw_slave_add(struct sdw_bus *bus,

Applied both, thanks
diff mbox series

Patch

diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig
index f518273cfbe3..c73bfbaa2659 100644
--- a/drivers/soundwire/Kconfig
+++ b/drivers/soundwire/Kconfig
@@ -5,6 +5,7 @@ 
 
 menuconfig SOUNDWIRE
 	tristate "SoundWire support"
+	depends on ACPI
 	help
 	  SoundWire is a 2-Pin interface with data and clock line ratified
 	  by the MIPI Alliance. SoundWire is used for transporting data