| Message ID | 20191015123932.12214-1-kwolf@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | blockdev: Use error_report() in hmp_commit() | expand |
On 10/15/19 7:39 AM, Kevin Wolf wrote: > Instead of using monitor_printf() to report errors, hmp_commit() should > use error_report() like other places do. > > Signed-off-by: Kevin Wolf <kwolf@redhat.com> > --- > blockdev.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > Reviewed-by: Eric Blake <eblake@redhat.com>
On 10/15/19 2:39 PM, Kevin Wolf wrote: > Instead of using monitor_printf() to report errors, hmp_commit() should > use error_report() like other places do. > > Signed-off-by: Kevin Wolf <kwolf@redhat.com> > --- > blockdev.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/blockdev.c b/blockdev.c > index f89e48fc79..e2358966c3 100644 > --- a/blockdev.c > +++ b/blockdev.c > @@ -1088,11 +1088,11 @@ void hmp_commit(Monitor *mon, const QDict *qdict) > > blk = blk_by_name(device); > if (!blk) { > - monitor_printf(mon, "Device '%s' not found\n", device); > + error_report("Device '%s' not found", device); > return; > } > if (!blk_is_available(blk)) { > - monitor_printf(mon, "Device '%s' has no medium\n", device); > + error_report("Device '%s' has no medium", device); > return; > } > > @@ -1105,8 +1105,7 @@ void hmp_commit(Monitor *mon, const QDict *qdict) > aio_context_release(aio_context); > } > if (ret < 0) { > - monitor_printf(mon, "'commit' error for '%s': %s\n", device, > - strerror(-ret)); > + error_report("'commit' error for '%s': %s", device, strerror(-ret)); > } > } > > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
diff --git a/blockdev.c b/blockdev.c index f89e48fc79..e2358966c3 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1088,11 +1088,11 @@ void hmp_commit(Monitor *mon, const QDict *qdict) blk = blk_by_name(device); if (!blk) { - monitor_printf(mon, "Device '%s' not found\n", device); + error_report("Device '%s' not found", device); return; } if (!blk_is_available(blk)) { - monitor_printf(mon, "Device '%s' has no medium\n", device); + error_report("Device '%s' has no medium", device); return; } @@ -1105,8 +1105,7 @@ void hmp_commit(Monitor *mon, const QDict *qdict) aio_context_release(aio_context); } if (ret < 0) { - monitor_printf(mon, "'commit' error for '%s': %s\n", device, - strerror(-ret)); + error_report("'commit' error for '%s': %s", device, strerror(-ret)); } }
Instead of using monitor_printf() to report errors, hmp_commit() should use error_report() like other places do. Signed-off-by: Kevin Wolf <kwolf@redhat.com> --- blockdev.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)