| Message ID | 20191015202020.29114-1-vvidic@valentin-vidic.from.hr (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 77b6d09f4ae66d42cd63b121af67780ae3d1a5e9 |
| Headers | show |
| Series | net: usb: sr9800: fix uninitialized local variable | expand |
From: Valentin Vidic <vvidic@valentin-vidic.from.hr> Date: Tue, 15 Oct 2019 22:20:20 +0200 > Make sure res does not contain random value if the call to > sr_read_cmd fails for some reason. > > Reported-by: syzbot+f1842130bbcfb335bac1@syzkaller.appspotmail.com > Signed-off-by: Valentin Vidic <vvidic@valentin-vidic.from.hr> Applied. But often in situation like this a failed read can more aptly be indicated by an all-1's value.
diff --git a/drivers/net/usb/sr9800.c b/drivers/net/usb/sr9800.c index c5d4a0060124..681e0def6356 100644 --- a/drivers/net/usb/sr9800.c +++ b/drivers/net/usb/sr9800.c @@ -335,7 +335,7 @@ static void sr_set_multicast(struct net_device *net) static int sr_mdio_read(struct net_device *net, int phy_id, int loc) { struct usbnet *dev = netdev_priv(net); - __le16 res; + __le16 res = 0; mutex_lock(&dev->phy_mutex); sr_set_sw_mii(dev);
Make sure res does not contain random value if the call to sr_read_cmd fails for some reason. Reported-by: syzbot+f1842130bbcfb335bac1@syzkaller.appspotmail.com Signed-off-by: Valentin Vidic <vvidic@valentin-vidic.from.hr> --- drivers/net/usb/sr9800.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)