mbox series

[v3,0/4] vfio-ccw: A couple trace changes

Message ID 20191016142040.14132-1-farman@linux.ibm.com (mailing list archive)
Headers show
Series vfio-ccw: A couple trace changes | expand

Message

Eric Farman Oct. 16, 2019, 2:20 p.m. UTC
Here a couple updates to the vfio-ccw traces in the kernel,
based on things I've been using locally.  Perhaps they'll
be useful for future debugging.

v2 -> v3:
 - Added Conny's r-b to patches 1, 2, 4
 - s/command=%d/command=0x%x/ in patch 3 [Cornelia Huck]

v1/RFC -> v2:
 - Convert state/event=%x to %d [Steffen Maier]
 - Use individual fields for cssid/ssid/sch_no, to enable
   filtering by device [Steffen Maier]
 - Add 0x prefix to remaining %x substitution in existing trace

Eric Farman (4):
  vfio-ccw: Refactor how the traces are built
  vfio-ccw: Trace the FSM jumptable
  vfio-ccw: Add a trace for asynchronous requests
  vfio-ccw: Rework the io_fctl trace

 drivers/s390/cio/Makefile           |  4 +-
 drivers/s390/cio/vfio_ccw_cp.h      |  1 +
 drivers/s390/cio/vfio_ccw_fsm.c     | 11 +++--
 drivers/s390/cio/vfio_ccw_private.h |  1 +
 drivers/s390/cio/vfio_ccw_trace.c   | 14 ++++++
 drivers/s390/cio/vfio_ccw_trace.h   | 76 ++++++++++++++++++++++++++---
 6 files changed, 93 insertions(+), 14 deletions(-)
 create mode 100644 drivers/s390/cio/vfio_ccw_trace.c

Comments

Halil Pasic Oct. 16, 2019, 2:30 p.m. UTC | #1
On Wed, 16 Oct 2019 16:20:36 +0200
Eric Farman <farman@linux.ibm.com> wrote:

> Here a couple updates to the vfio-ccw traces in the kernel,
> based on things I've been using locally.  Perhaps they'll
> be useful for future debugging.
> 

Hi! I had a brief look, no full blown review though. You can add an ack
by me for all the patches in this series.

Regards,
Halil
Cornelia Huck Oct. 17, 2019, 10:19 a.m. UTC | #2
On Wed, 16 Oct 2019 16:20:36 +0200
Eric Farman <farman@linux.ibm.com> wrote:

> Here a couple updates to the vfio-ccw traces in the kernel,
> based on things I've been using locally.  Perhaps they'll
> be useful for future debugging.
> 
> v2 -> v3:
>  - Added Conny's r-b to patches 1, 2, 4
>  - s/command=%d/command=0x%x/ in patch 3 [Cornelia Huck]
> 
> v1/RFC -> v2:
>  - Convert state/event=%x to %d [Steffen Maier]
>  - Use individual fields for cssid/ssid/sch_no, to enable
>    filtering by device [Steffen Maier]
>  - Add 0x prefix to remaining %x substitution in existing trace
> 
> Eric Farman (4):
>   vfio-ccw: Refactor how the traces are built
>   vfio-ccw: Trace the FSM jumptable
>   vfio-ccw: Add a trace for asynchronous requests
>   vfio-ccw: Rework the io_fctl trace
> 
>  drivers/s390/cio/Makefile           |  4 +-
>  drivers/s390/cio/vfio_ccw_cp.h      |  1 +
>  drivers/s390/cio/vfio_ccw_fsm.c     | 11 +++--
>  drivers/s390/cio/vfio_ccw_private.h |  1 +
>  drivers/s390/cio/vfio_ccw_trace.c   | 14 ++++++
>  drivers/s390/cio/vfio_ccw_trace.h   | 76 ++++++++++++++++++++++++++---
>  6 files changed, 93 insertions(+), 14 deletions(-)
>  create mode 100644 drivers/s390/cio/vfio_ccw_trace.c
> 

Thanks, applied.