| Message ID | 20191010001224.41826-3-tony@atomide.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Improve PM for omap4 devices | expand |
Hi! > The wkup domain is always on and does not have logic off setting. This > got accidentally added by commit f74297dd9354 ("ARM: OMAP2+: Make sure > LOGICRETSTATE bits are not cleared") but is harmless. > > Cc: Merlijn Wajer <merlijn@wizzup.org> > Cc: Pavel Machek <pavel@ucw.cz> > Cc: Sebastian Reichel <sre@kernel.org> > Signed-off-by: Tony Lindgren <tony@atomide.com> > --- > arch/arm/mach-omap2/pm44xx.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/arm/mach-omap2/pm44xx.c b/arch/arm/mach-omap2/pm44xx.c > --- a/arch/arm/mach-omap2/pm44xx.c > +++ b/arch/arm/mach-omap2/pm44xx.c > @@ -137,8 +137,7 @@ static int __init pwrdms_setup(struct powerdomain *pwrdm, void *unused) > * smsc911x at least if per hits retention during idle. > */ > if (!strncmp(pwrdm->name, "core", 4) || > - !strncmp(pwrdm->name, "l4per", 5) || > - !strncmp(pwrdm->name, "wkup", 4)) > + !strncmp(pwrdm->name, "l4per", 5)) > pwrdm_set_logic_retst(pwrdm, PWRDM_POWER_RET); This is rather theoretical, but if the powerdomain is called "corelation-not-causation", do you still want the if() to trigger? Best regards, Pavel
* Pavel Machek <pavel@ucw.cz> [191013 15:08]: > Hi! > > > The wkup domain is always on and does not have logic off setting. This > > got accidentally added by commit f74297dd9354 ("ARM: OMAP2+: Make sure > > LOGICRETSTATE bits are not cleared") but is harmless. > > > > Cc: Merlijn Wajer <merlijn@wizzup.org> > > Cc: Pavel Machek <pavel@ucw.cz> > > Cc: Sebastian Reichel <sre@kernel.org> > > Signed-off-by: Tony Lindgren <tony@atomide.com> > > --- > > arch/arm/mach-omap2/pm44xx.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/arch/arm/mach-omap2/pm44xx.c b/arch/arm/mach-omap2/pm44xx.c > > --- a/arch/arm/mach-omap2/pm44xx.c > > +++ b/arch/arm/mach-omap2/pm44xx.c > > @@ -137,8 +137,7 @@ static int __init pwrdms_setup(struct powerdomain *pwrdm, void *unused) > > * smsc911x at least if per hits retention during idle. > > */ > > if (!strncmp(pwrdm->name, "core", 4) || > > - !strncmp(pwrdm->name, "l4per", 5) || > > - !strncmp(pwrdm->name, "wkup", 4)) > > + !strncmp(pwrdm->name, "l4per", 5)) > > pwrdm_set_logic_retst(pwrdm, PWRDM_POWER_RET); > > This is rather theoretical, but if the powerdomain is called > "corelation-not-causation", do you still want the if() to trigger? No need to if no writable register bits exists if I understand your theoretical comment right :) Regards, Tony
diff --git a/arch/arm/mach-omap2/pm44xx.c b/arch/arm/mach-omap2/pm44xx.c --- a/arch/arm/mach-omap2/pm44xx.c +++ b/arch/arm/mach-omap2/pm44xx.c @@ -137,8 +137,7 @@ static int __init pwrdms_setup(struct powerdomain *pwrdm, void *unused) * smsc911x at least if per hits retention during idle. */ if (!strncmp(pwrdm->name, "core", 4) || - !strncmp(pwrdm->name, "l4per", 5) || - !strncmp(pwrdm->name, "wkup", 4)) + !strncmp(pwrdm->name, "l4per", 5)) pwrdm_set_logic_retst(pwrdm, PWRDM_POWER_RET); pwrst = kmalloc(sizeof(struct power_state), GFP_ATOMIC);
The wkup domain is always on and does not have logic off setting. This got accidentally added by commit f74297dd9354 ("ARM: OMAP2+: Make sure LOGICRETSTATE bits are not cleared") but is harmless. Cc: Merlijn Wajer <merlijn@wizzup.org> Cc: Pavel Machek <pavel@ucw.cz> Cc: Sebastian Reichel <sre@kernel.org> Signed-off-by: Tony Lindgren <tony@atomide.com> --- arch/arm/mach-omap2/pm44xx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)