mbox series

[0/4] Bluetooth: hci_qca: Regulator usage cleanup

Message ID 20191018052405.3693555-1-bjorn.andersson@linaro.org (mailing list archive)
Headers show
Series Bluetooth: hci_qca: Regulator usage cleanup | expand

Message

Bjorn Andersson Oct. 18, 2019, 5:24 a.m. UTC 
Clean up the regulator usage in hci_qca and in particular don't
regulator_set_voltage() for fixed voltages. It cleans up the driver, but more
important it makes bluetooth work on my Lenovo Yoga C630, where the regulator
for vddch0 is defined with a voltage range that doesn't overlap the values in
the driver.

Bjorn Andersson (4):
  Bluetooth: hci_qca: Update regulator_set_load() usage
  Bluetooth: hci_qca: Don't vote for specific voltage
  Bluetooth: hci_qca: Use regulator bulk enable/disable
  Bluetooth: hci_qca: Split qca_power_setup()

 drivers/bluetooth/hci_qca.c | 135 +++++++++++++++---------------------
 1 file changed, 55 insertions(+), 80 deletions(-)

Comments

Marcel Holtmann Oct. 18, 2019, 7:59 a.m. UTC | #1 
Hi Bjorn,

> Clean up the regulator usage in hci_qca and in particular don't
> regulator_set_voltage() for fixed voltages. It cleans up the driver, but more
> important it makes bluetooth work on my Lenovo Yoga C630, where the regulator
> for vddch0 is defined with a voltage range that doesn't overlap the values in
> the driver.
> 
> Bjorn Andersson (4):
>  Bluetooth: hci_qca: Update regulator_set_load() usage
>  Bluetooth: hci_qca: Don't vote for specific voltage
>  Bluetooth: hci_qca: Use regulator bulk enable/disable
>  Bluetooth: hci_qca: Split qca_power_setup()
> 
> drivers/bluetooth/hci_qca.c | 135 +++++++++++++++---------------------
> 1 file changed, 55 insertions(+), 80 deletions(-)

all 4 patches have been applied to bluetooth-next tree.

Regards

Marcel
Harish Bandi Oct. 18, 2019, 11:17 a.m. UTC | #2 
On 2019-10-18 10:54, Bjorn Andersson wrote:
> Clean up the regulator usage in hci_qca and in particular don't
> regulator_set_voltage() for fixed voltages. It cleans up the driver, 
> but more
> important it makes bluetooth work on my Lenovo Yoga C630, where the 
> regulator
> for vddch0 is defined with a voltage range that doesn't overlap the 
> values in
> the driver.
> 
> Bjorn Andersson (4):
>   Bluetooth: hci_qca: Update regulator_set_load() usage
>   Bluetooth: hci_qca: Don't vote for specific voltage
>   Bluetooth: hci_qca: Use regulator bulk enable/disable
>   Bluetooth: hci_qca: Split qca_power_setup()
> 
>  drivers/bluetooth/hci_qca.c | 135 +++++++++++++++---------------------
>  1 file changed, 55 insertions(+), 80 deletions(-)
Jeffrey Hugo Oct. 18, 2019, 2:52 p.m. UTC | #3 
On Fri, Oct 18, 2019 at 1:59 AM Marcel Holtmann <marcel@holtmann.org> wrote:
>
> Hi Bjorn,
>
> > Clean up the regulator usage in hci_qca and in particular don't
> > regulator_set_voltage() for fixed voltages. It cleans up the driver, but more
> > important it makes bluetooth work on my Lenovo Yoga C630, where the regulator
> > for vddch0 is defined with a voltage range that doesn't overlap the values in
> > the driver.
> >
> > Bjorn Andersson (4):
> >  Bluetooth: hci_qca: Update regulator_set_load() usage
> >  Bluetooth: hci_qca: Don't vote for specific voltage
> >  Bluetooth: hci_qca: Use regulator bulk enable/disable
> >  Bluetooth: hci_qca: Split qca_power_setup()
> >
> > drivers/bluetooth/hci_qca.c | 135 +++++++++++++++---------------------
> > 1 file changed, 55 insertions(+), 80 deletions(-)
>
> all 4 patches have been applied to bluetooth-next tree.

I know this is already applied, but I just wanted to follow up and indicate:

Tested-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
Reviewed-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>

Thanks for the cleanups Bjorn.