[1/2] USB: dummy-hcd: increase max number of devices to 32

Commit Message

Andrey Konovalov Oct. 18, 2019, 2:55 p.m. UTC

This patch increases the maximum number of Dummy UDC/HCD devices to 32.
---
 drivers/usb/gadget/udc/dummy_hcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Greg Kroah-Hartman Oct. 18, 2019, 6:06 p.m. UTC | #1

On Fri, Oct 18, 2019 at 04:55:56PM +0200, Andrey Konovalov wrote:
> This patch increases the maximum number of Dummy UDC/HCD devices to 32.

Yes, that is a good description of _what_ the patch does, but it does
not tell us _why_ you want to do that.

Also, no signed-off-by, are you sure you ran your patches through
scripts/checkpatch.pl before sending it out?  It's a good idea to do
so...

thanks,

greg k-h

Andrey Konovalov Oct. 21, 2019, 12:35 p.m. UTC | #2

On Fri, Oct 18, 2019 at 8:07 PM Greg Kroah-Hartman
<[e-mail]> wrote:
>
> On Fri, Oct 18, 2019 at 04:55:56PM +0200, Andrey Konovalov wrote:
> > This patch increases the maximum number of Dummy UDC/HCD devices to 32.
>
> Yes, that is a good description of _what_ the patch does, but it does
> not tell us _why_ you want to do that.

Will do in v2, thanks!

> Also, no signed-off-by, are you sure you ran your patches through
> scripts/checkpatch.pl before sending it out?  It's a good idea to do
> so...

Sorry, missed this, I thought the patch is small enough to not do that :)

Patch

diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/dummy_hcd.c
index 3d499d93c083..a8f1e5707c14 100644
--- a/drivers/usb/gadget/udc/dummy_hcd.c
+++ b/drivers/usb/gadget/udc/dummy_hcd.c
@@ -2725,7 +2725,7 @@  static struct platform_driver dummy_hcd_driver = {
 };
 
 /*-------------------------------------------------------------------------*/
-#define MAX_NUM_UDC	2
+#define MAX_NUM_UDC	32
 static struct platform_device *the_udc_pdev[MAX_NUM_UDC];
 static struct platform_device *the_hcd_pdev[MAX_NUM_UDC];