| Message ID | 20191021143742.14487-1-geert+renesas@glider.be (mailing list archive) |
|---|---|
| Headers | show |
| Series | debugfs: Add and use debugfs_create_xul() | expand |
On Mon, 21 Oct 2019 at 16:37, Geert Uytterhoeven <geert+renesas@glider.be> wrote: > > Hi all, > > The existing debugfs_create_ulong() function supports objects of > type "unsigned long", which are 32-bit or 64-bit depending on the > platform, in decimal form. To format objects in hexadecimal, various > debugfs_create_x*() functions exist, but all of them take fixed-size > types. > > To work around this, some drivers call one of debugfs_create_x{32,64}(), > depending on the size of unsigned long. > Other driver just cast the value pointer to "u32 *" or "u64 *", > introducing portability bugs or data leaks in the process. > > Hence this patch series adds a debugfs helper for "unsigned long" > objects in hexadecimal format, and converts drivers to make use of it. > It also contains two cleanups removing superfluous casts, which I added > to this series to avoid conflicts. > > Thanks for your comments! The mmc changes looks good to me. I guess we could funnel via Greg's "debugfs" tree? In such case, feel free to add my ack for the mmc changes. Kind regards Uffe > > Geert Uytterhoeven (7): > debugfs: Add debugfs_create_xul() for hexadecimal unsigned long > mac80211: Use debugfs_create_xul() helper > net: caif: Fix debugfs on 64-bit platforms > mmc: atmel-mci: Fix debugfs on 64-bit platforms > mmc: atmel-mci: Remove superfluous cast in debugfs_create_u32() call > mmc: dw_mmc: Fix debugfs on 64-bit platforms > mmc: dw_mmc: Remove superfluous cast in debugfs_create_u32() call > > drivers/mmc/host/atmel-mci.c | 10 +++++----- > drivers/mmc/host/dw_mmc.c | 10 +++++----- > drivers/net/caif/caif_serial.c | 4 ++-- > include/linux/debugfs.h | 10 ++++++++++ > net/mac80211/debugfs_sta.c | 17 +++-------------- > 5 files changed, 25 insertions(+), 26 deletions(-) > > -- > 2.17.1 > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
Hi all, The existing debugfs_create_ulong() function supports objects of type "unsigned long", which are 32-bit or 64-bit depending on the platform, in decimal form. To format objects in hexadecimal, various debugfs_create_x*() functions exist, but all of them take fixed-size types. To work around this, some drivers call one of debugfs_create_x{32,64}(), depending on the size of unsigned long. Other driver just cast the value pointer to "u32 *" or "u64 *", introducing portability bugs or data leaks in the process. Hence this patch series adds a debugfs helper for "unsigned long" objects in hexadecimal format, and converts drivers to make use of it. It also contains two cleanups removing superfluous casts, which I added to this series to avoid conflicts. Thanks for your comments! Geert Uytterhoeven (7): debugfs: Add debugfs_create_xul() for hexadecimal unsigned long mac80211: Use debugfs_create_xul() helper net: caif: Fix debugfs on 64-bit platforms mmc: atmel-mci: Fix debugfs on 64-bit platforms mmc: atmel-mci: Remove superfluous cast in debugfs_create_u32() call mmc: dw_mmc: Fix debugfs on 64-bit platforms mmc: dw_mmc: Remove superfluous cast in debugfs_create_u32() call drivers/mmc/host/atmel-mci.c | 10 +++++----- drivers/mmc/host/dw_mmc.c | 10 +++++----- drivers/net/caif/caif_serial.c | 4 ++-- include/linux/debugfs.h | 10 ++++++++++ net/mac80211/debugfs_sta.c | 17 +++-------------- 5 files changed, 25 insertions(+), 26 deletions(-)