| Message ID | 20191018233844.23838-1-f.fainelli@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mtd: rawnand: brcmnand: Fix sparse warning in has_flash_dma() | expand |
Hi Florian, Florian Fainelli <f.fainelli@gmail.com> wrote on Fri, 18 Oct 2019 16:38:44 -0700: > Sparse rightfully complained about has_flash_dma(): > +drivers/mtd/nand/brcmnand/brcmnand.c:951:40: warning: Using plain integer as NULL pointer [sparse] I don't get why would sparse complain about this... Anyway I prefer the !!(<pointer>) alternative if you don't mind. Otherwise the "!= NULL" comparison feels wrong. > > Fixes: 27c5b17cd1b1 ("mtd: nand: add NAND driver "library" for Broadcom STB NAND controller") > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> > --- > drivers/mtd/nand/raw/brcmnand/brcmnand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c > index 15ef30b368a5..73f7a0945399 100644 > --- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c > +++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c > @@ -909,7 +909,7 @@ static inline void brcmnand_set_wp(struct brcmnand_controller *ctrl, bool en) > > static inline bool has_flash_dma(struct brcmnand_controller *ctrl) > { > - return ctrl->flash_dma_base; > + return ctrl->flash_dma_base != NULL; > } > > static inline void disable_ctrl_irqs(struct brcmnand_controller *ctrl) Thanks, Miquèl
On 10/19/19 2:39 AM, Miquel Raynal wrote: > Hi Florian, > > Florian Fainelli <f.fainelli@gmail.com> wrote on Fri, 18 Oct 2019 > 16:38:44 -0700: > >> Sparse rightfully complained about has_flash_dma(): >> +drivers/mtd/nand/brcmnand/brcmnand.c:951:40: warning: Using plain integer as NULL pointer [sparse] > > I don't get why would sparse complain about this... Anyway I prefer > the !!(<pointer>) alternative if you don't mind. Otherwise the "!= > NULL" comparison feels wrong. I did not read the sparse complaint correctly and mixed up two issues (one downstream, one upstream) there is still one that is legitimately reported by sparse and that will be fixed in a v2, thanks.
diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c index 15ef30b368a5..73f7a0945399 100644 --- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c +++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c @@ -909,7 +909,7 @@ static inline void brcmnand_set_wp(struct brcmnand_controller *ctrl, bool en) static inline bool has_flash_dma(struct brcmnand_controller *ctrl) { - return ctrl->flash_dma_base; + return ctrl->flash_dma_base != NULL; } static inline void disable_ctrl_irqs(struct brcmnand_controller *ctrl)
Sparse rightfully complained about has_flash_dma(): +drivers/mtd/nand/brcmnand/brcmnand.c:951:40: warning: Using plain integer as NULL pointer [sparse] Fixes: 27c5b17cd1b1 ("mtd: nand: add NAND driver "library" for Broadcom STB NAND controller") Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> --- drivers/mtd/nand/raw/brcmnand/brcmnand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)