| Message ID | 20191021171120.17947-1-pbonzini@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | memory-device: simplify Makefile.objs conditions | expand |
On 10/21/19 7:11 PM, Paolo Bonzini wrote: > hw/mem/ is only included if CONFIG_MEM_DEVICE is true, so we need not > specify the condition again in hw/mem/Makefile.objs. Yes, cleaner. Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- > hw/mem/Makefile.objs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/mem/Makefile.objs b/hw/mem/Makefile.objs > index 3e2f7c5ca2..56345befd0 100644 > --- a/hw/mem/Makefile.objs > +++ b/hw/mem/Makefile.objs > @@ -1,3 +1,3 @@ > common-obj-$(CONFIG_DIMM) += pc-dimm.o > -common-obj-$(CONFIG_MEM_DEVICE) += memory-device.o > +common-obj-y += memory-device.o > common-obj-$(CONFIG_NVDIMM) += nvdimm.o >
On 21/10/2019 19.11, Paolo Bonzini wrote: > hw/mem/ is only included if CONFIG_MEM_DEVICE is true, so we need not > specify the condition again in hw/mem/Makefile.objs. > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- > hw/mem/Makefile.objs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/mem/Makefile.objs b/hw/mem/Makefile.objs > index 3e2f7c5ca2..56345befd0 100644 > --- a/hw/mem/Makefile.objs > +++ b/hw/mem/Makefile.objs > @@ -1,3 +1,3 @@ > common-obj-$(CONFIG_DIMM) += pc-dimm.o > -common-obj-$(CONFIG_MEM_DEVICE) += memory-device.o > +common-obj-y += memory-device.o > common-obj-$(CONFIG_NVDIMM) += nvdimm.o > Reviewed-by: Thomas Huth <thuth@redhat.com>
diff --git a/hw/mem/Makefile.objs b/hw/mem/Makefile.objs index 3e2f7c5ca2..56345befd0 100644 --- a/hw/mem/Makefile.objs +++ b/hw/mem/Makefile.objs @@ -1,3 +1,3 @@ common-obj-$(CONFIG_DIMM) += pc-dimm.o -common-obj-$(CONFIG_MEM_DEVICE) += memory-device.o +common-obj-y += memory-device.o common-obj-$(CONFIG_NVDIMM) += nvdimm.o
hw/mem/ is only included if CONFIG_MEM_DEVICE is true, so we need not specify the condition again in hw/mem/Makefile.objs. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> --- hw/mem/Makefile.objs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)