diff mbox series

[v5.1,RESEND] dt-bindings: hwrng: Add Samsung Exynos 5250+ True RNG bindings

Message ID 20190111132139.12333-1-l.stelmach@samsung.com (mailing list archive)
State Not Applicable
Headers show
Series [v5.1,RESEND] dt-bindings: hwrng: Add Samsung Exynos 5250+ True RNG bindings | expand

Commit Message

Lukasz Stelmach Jan. 11, 2019, 1:21 p.m. UTC
Add binding documentation for the True Random Number Generator
found on Samsung Exynos 5250+ SoCs.

Acked-by: Rob Herring <robh@kernel.org>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
---
 .../bindings/rng/samsung,exynos5250-trng.txt    | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt

Comments

Krzysztof Kozlowski March 26, 2019, 11:42 a.m. UTC | #1
On Fri, 11 Jan 2019 at 14:22, Łukasz Stelmach <l.stelmach@samsung.com> wrote:
>
> Add binding documentation for the True Random Number Generator
> found on Samsung Exynos 5250+ SoCs.
>
> Acked-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
> ---

Rob,
Could you apply this directly? You acked this some time ago but it
never went through drivers tree. Lukasz resent this patch and it is
waiting since then.
The driver implementing compatible is already in mainline.

Best regards,
Krzysztof
Andreas Färber Oct. 23, 2019, 8:16 a.m. UTC | #2
Hi guys,

Am 26.03.19 um 12:42 schrieb Krzysztof Kozlowski:
> On Fri, 11 Jan 2019 at 14:22, Łukasz Stelmach <l.stelmach@samsung.com> wrote:
>>
>> Add binding documentation for the True Random Number Generator
>> found on Samsung Exynos 5250+ SoCs.
>>
>> Acked-by: Rob Herring <robh@kernel.org>
>> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
>> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
>> ---
> 
> Rob,
> Could you apply this directly? You acked this some time ago but it
> never went through drivers tree. Lukasz resent this patch and it is
> waiting since then.
> The driver implementing compatible is already in mainline.

For some reason this text file in linux-next is lonely in devicetree/...
rather than living in Documentation/devicetree/... - please fix that.
The patch here looks correct, so not sure what went wrong:

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/devicetree/bindings/rng/samsung,exynos5250-trng.txt?h=next-20191023&id=85552c22f03c9066c33f26f34538b67fee6a91a8

Thanks,
Andreas
Herbert Xu Oct. 23, 2019, 8:44 a.m. UTC | #3
On Wed, Oct 23, 2019 at 10:16:48AM +0200, Andreas Färber wrote:
>
> For some reason this text file in linux-next is lonely in devicetree/...
> rather than living in Documentation/devicetree/... - please fix that.
> The patch here looks correct, so not sure what went wrong:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/devicetree/bindings/rng/samsung,exynos5250-trng.txt?h=next-20191023&id=85552c22f03c9066c33f26f34538b67fee6a91a8

It's because the patch

	https://patchwork.kernel.org/patch/11181265/

was generated at the wrong level (p0 instead of p1).

I'll fix this up in my tree.  Thanks for the heads up.

Cheers,
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt b/Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt
new file mode 100644
index 000000000000..5a613a4ec780
--- /dev/null
+++ b/Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt
@@ -0,0 +1,17 @@ 
+Exynos True Random Number Generator
+
+Required properties:
+
+- compatible  : Should be "samsung,exynos5250-trng".
+- reg         : Specifies base physical address and size of the registers map.
+- clocks      : Phandle to clock-controller plus clock-specifier pair.
+- clock-names : "secss" as a clock name.
+
+Example:
+
+	rng@10830600 {
+		compatible = "samsung,exynos5250-trng";
+		reg = <0x10830600 0x100>;
+		clocks = <&clock CLK_SSS>;
+		clock-names = "secss";
+	};