| Message ID | CA+9XP1jeMVuzj0gz_-H6zV=cmjWQwvBLi08AED1KBie+kugmcg@mail.gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ALSA: usb-audio: Add Gustard U16/X26 device family to quirks for native DSD support | expand |
On Wed, 23 Oct 2019 06:05:08 +0200, Fly Pig wrote: > > Hi There > > This patch add native DSD support for Gustard U16/X26 USB Interface. Tested on > my unit, working properly. Hence submit the patch. > > Cheers. > > Thank you very much. > > Pig The upstream code changed the DSD detection recently, so your patch doesn't apply. In short, check whether you get fp->dsd_raw set. If yes, we can apply the vendor check instead of vendor:device pair check. Please resubmit the patch with the correction, and don't forget to add your sign-off line (see Documentation/process/submitting-patches.rst). It's a legal requirement for taking the patch to upstream. thanks, Takashi > > --- a/sound/usb/quirks.c 2019-09-22 21:28:09.757897000 +0000 > +++ b/sound/usb/quirks.c 2019-09-22 21:33:36.892274800 +0000 > @@ -1369,6 +1369,7 @@ > case USB_ID(0x22d9, 0x0461): /* OPPO UDP-205 */ > case USB_ID(0x2522, 0x0012): /* LH Labs VI DAC Infinity */ > case USB_ID(0x2772, 0x0230): /* Pro-Ject Pre Box S2 Digital */ > + case USB_ID(0x292b, 0xc4b3): /* Gustard U16 */ > if (fp->altsetting == 2) > return SNDRV_PCM_FMTBIT_DSD_U32_BE; > break; > >
Got it, Tested using VID and fp->dsd_raw method. Works as well, patch updated below. Sign off line attached. --- a/sound/usb/quirks.c 2019-10-23 05:38:05.664262661 +0000 +++ b/sound/usb/quirks.c 2019-10-23 05:41:15.907336660 +0000 @@ -1452,6 +1452,7 @@ case 0x2ab6: /* T+A devices */ case 0x3842: /* EVGA */ case 0xc502: /* HiBy devices */ + case 0x292b: /* Gustard/Ess based devices */ if (fp->dsd_raw) return SNDRV_PCM_FMTBIT_DSD_U32_BE; break; By making a contribution to this project, I certify that: 1. The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or 2. The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or 3. The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. 4. I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. Signed-off-by: Justin Song<flyingecar@gmail.com> On Tue, Oct 22, 2019 at 10:04 PM Takashi Iwai <tiwai@suse.de> wrote: > On Wed, 23 Oct 2019 06:05:08 +0200, > Fly Pig wrote: > > > > Hi There > > > > This patch add native DSD support for Gustard U16/X26 USB Interface. > Tested on > > my unit, working properly. Hence submit the patch. > > > > Cheers. > > > > Thank you very much. > > > > Pig > > The upstream code changed the DSD detection recently, so your patch > doesn't apply. In short, check whether you get fp->dsd_raw set. If > yes, we can apply the vendor check instead of vendor:device pair > check. > > Please resubmit the patch with the correction, and don't forget to add > your sign-off line (see Documentation/process/submitting-patches.rst). > It's a legal requirement for taking the patch to upstream. > > > thanks, > > Takashi > > > > > --- a/sound/usb/quirks.c 2019-09-22 21:28:09.757897000 +0000 > > +++ b/sound/usb/quirks.c 2019-09-22 21:33:36.892274800 +0000 > > @@ -1369,6 +1369,7 @@ > > case USB_ID(0x22d9, 0x0461): /* OPPO UDP-205 */ > > case USB_ID(0x2522, 0x0012): /* LH Labs VI DAC Infinity */ > > case USB_ID(0x2772, 0x0230): /* Pro-Ject Pre Box S2 Digital */ > > + case USB_ID(0x292b, 0xc4b3): /* Gustard U16 */ > > if (fp->altsetting == 2) > > return SNDRV_PCM_FMTBIT_DSD_U32_BE; > > break; > > > > >
On Thu, 24 Oct 2019 04:47:44 +0200, Fly Pig wrote: > > Got it, > > Tested using VID and fp->dsd_raw method. Works as well, patch updated below. > Sign off line attached. > > --- a/sound/usb/quirks.c 2019-10-23 05:38:05.664262661 +0000 > +++ b/sound/usb/quirks.c 2019-10-23 05:41:15.907336660 +0000 > @@ -1452,6 +1452,7 @@ > case 0x2ab6: /* T+A devices */ > case 0x3842: /* EVGA */ > case 0xc502: /* HiBy devices */ > + case 0x292b: /* Gustard/Ess based devices */ > if (fp->dsd_raw) > return SNDRV_PCM_FMTBIT_DSD_U32_BE; > break; > > By making a contribution to this project, I certify that: > > 1. The contribution was created in whole or in part by me and I have the > right to submit it under the open source license indicated in the > file; or > 2. The contribution is based upon previous work that, to the best of my > knowledge, is covered under an appropriate open source license and I > have the right under that license to submit that work with > modifications, whether created in whole or in part by me, under the > same open source license (unless I am permitted to submit under a > different license), as indicated in the file; or > 3. The contribution was provided directly to me by some other person who > certified (a), (b) or (c) and I have not modified it. > 4. I understand and agree that this project and the contribution are > public and that a record of the contribution (including all personal > information I submit with it, including my sign-off) is maintained > indefinitely and may be redistributed consistent with this project or > the open source license(s) involved. > > Signed-off-by: Justin Song<flyingecar@gmail.com> OK, now I applied the fix with a slight modification of the patch subject and changelog. BTW, you don't need to copy the text above. At the next time, just put your sign-off line in the patch description. thanks, Takashi > > On Tue, Oct 22, 2019 at 10:04 PM Takashi Iwai <tiwai@suse.de> wrote: > > On Wed, 23 Oct 2019 06:05:08 +0200, > Fly Pig wrote: > > > > Hi There > > > > This patch add native DSD support for Gustard U16/X26 USB Interface. > Tested on > > my unit, working properly. Hence submit the patch. > > > > Cheers. > > > > Thank you very much. > > > > Pig > > The upstream code changed the DSD detection recently, so your patch > doesn't apply. In short, check whether you get fp->dsd_raw set. If > yes, we can apply the vendor check instead of vendor:device pair > check. > > Please resubmit the patch with the correction, and don't forget to add > your sign-off line (see Documentation/process/submitting-patches.rst). > It's a legal requirement for taking the patch to upstream. > > thanks, > > Takashi > > > > > --- a/sound/usb/quirks.c 2019-09-22 21:28:09.757897000 +0000 > > +++ b/sound/usb/quirks.c 2019-09-22 21:33:36.892274800 +0000 > > @@ -1369,6 +1369,7 @@ > > case USB_ID(0x22d9, 0x0461): /* OPPO UDP-205 */ > > case USB_ID(0x2522, 0x0012): /* LH Labs VI DAC Infinity */ > > case USB_ID(0x2772, 0x0230): /* Pro-Ject Pre Box S2 Digital */ > > + case USB_ID(0x292b, 0xc4b3): /* Gustard U16 */ > > if (fp->altsetting == 2) > > return SNDRV_PCM_FMTBIT_DSD_U32_BE; > > break; > > > > > >
--- a/sound/usb/quirks.c 2019-09-22 21:28:09.757897000 +0000 +++ b/sound/usb/quirks.c 2019-09-22 21:33:36.892274800 +0000 @@ -1369,6 +1369,7 @@ case USB_ID(0x22d9, 0x0461): /* OPPO UDP-205 */ case USB_ID(0x2522, 0x0012): /* LH Labs VI DAC Infinity */ case USB_ID(0x2772, 0x0230): /* Pro-Ject Pre Box S2 Digital */ + case USB_ID(0x292b, 0xc4b3): /* Gustard U16 */ if (fp->altsetting == 2) return SNDRV_PCM_FMTBIT_DSD_U32_BE; break;