| Message ID | 20191024124610.18182-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f8a60435703bdde8f8a0ceb1aa8dad59df821583 |
| Headers | show |
| Series | [next] ASoC: rt5677: Add missing null check for failed allocation of rt5677_dsp | expand |
On Thu, Oct 24, 2019 at 5:46 AM Colin King <colin.king@canonical.com> wrote: > > From: Colin Ian King <colin.king@canonical.com> > > The allocation of rt5677_dsp can potentially fail and return null, so add > a null check and return -ENOMEM on a memory allocation failure. > > Addresses-Coverity: ("Dereference null return") > Fixes: a0e0d135427c ("ASoC: rt5677: Add a PCM device for streaming hotword via SPI") > Signed-off-by: Colin Ian King <colin.king@canonical.com> Thanks Acked-by Curtis Malainey <cujomalainey@chromium.org> > --- > sound/soc/codecs/rt5677-spi.c | 2 ++ > 1 file changed, 2 insertions(+)
diff --git a/sound/soc/codecs/rt5677-spi.c b/sound/soc/codecs/rt5677-spi.c index 36c02d200cfc..3a17643fcd9f 100644 --- a/sound/soc/codecs/rt5677-spi.c +++ b/sound/soc/codecs/rt5677-spi.c @@ -376,6 +376,8 @@ static int rt5677_spi_pcm_probe(struct snd_soc_component *component) rt5677_dsp = devm_kzalloc(component->dev, sizeof(*rt5677_dsp), GFP_KERNEL); + if (!rt5677_dsp) + return -ENOMEM; rt5677_dsp->dev = &g_spi->dev; mutex_init(&rt5677_dsp->dma_lock); INIT_DELAYED_WORK(&rt5677_dsp->copy_work, rt5677_spi_copy_work);