mbox series

[v4,0/2] Add CML M/C for RT5682 and RT1011

Message ID 1569430624-30505-1-git-send-email-sathya.prakash.m.r@intel.com (mailing list archive)
Headers show
Series Add CML M/C for RT5682 and RT1011 | expand

Message

M R, Sathya Prakash Sept. 25, 2019, 4:57 p.m. UTC
From: Sathya Prakash M R <sathya.prakash.m.r@intel.com>

The series adds CML m/c driver with RT5682 on SSP0 and
RT1011 on SSP1.
The RT1011 is smart AMP which supports 2 Whoofers and
2 tweeter support.
RT5682 is headset codec supporting playback and record.
The m/c supports HDMI playback and DMIC record.

Naveen Manohar (2):
  ASoC: Intel: boards: Add CML m/c using RT1011 and RT5682
  ASoC: Intel: Add acpi match for rt1011 based m/c driver

 sound/soc/intel/boards/Kconfig                    |  18 +
 sound/soc/intel/boards/Makefile                   |   2 +
 sound/soc/intel/boards/cml_rt1011_rt5682.c        | 473 ++++++++++++++++++++++
 sound/soc/intel/common/soc-acpi-intel-cnl-match.c |   7 +
 4 files changed, 500 insertions(+)
 create mode 100644 sound/soc/intel/boards/cml_rt1011_rt5682.c

--
V3 Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Changes from V3: repost with more recipients and edits to commit messages
Changes from V2: re ordered match table
to ensure non i2c device matches are at the end
Changes from V1:
Addressed comments on 
ASoC: Intel: boards: Add CML m/c using RT1011 and RT5682 
1.9.1

Comments

Pierre-Louis Bossart Oct. 18, 2019, 7:35 p.m. UTC | #1
On 9/25/19 11:57 AM, sathya.prakash.m.r@intel.com wrote:
> From: Sathya Prakash M R <sathya.prakash.m.r@intel.com>
> 
> The series adds CML m/c driver with RT5682 on SSP0 and
> RT1011 on SSP1.
> The RT1011 is smart AMP which supports 2 Whoofers and
> 2 tweeter support.
> RT5682 is headset codec supporting playback and record.
> The m/c supports HDMI playback and DMIC record.
> 
> Naveen Manohar (2):
>    ASoC: Intel: boards: Add CML m/c using RT1011 and RT5682
>    ASoC: Intel: Add acpi match for rt1011 based m/c driver
> 
>   sound/soc/intel/boards/Kconfig                    |  18 +
>   sound/soc/intel/boards/Makefile                   |   2 +
>   sound/soc/intel/boards/cml_rt1011_rt5682.c        | 473 ++++++++++++++++++++++
>   sound/soc/intel/common/soc-acpi-intel-cnl-match.c |   7 +
>   4 files changed, 500 insertions(+)
>   create mode 100644 sound/soc/intel/boards/cml_rt1011_rt5682.c
> 
> --
> V3 Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

Mark, I noticed this morning while rebasing SOF on your tree that those 
two patches have not been merged.
Not sure if they were missed (the 4 versions were confusing), if you 
didn't see my Acked-by tag or if there was an objection?
No real urgency except for likely conflicts with Kai's work on the HDMI 
side if we delay, and I think Morimoto-san is also preparing additional 
nice simplifications for codec-dais.
Thanks and have a nice weekend.


> Changes from V3: repost with more recipients and edits to commit messages
> Changes from V2: re ordered match table
> to ensure non i2c device matches are at the end
> Changes from V1:
> Addressed comments on
> ASoC: Intel: boards: Add CML m/c using RT1011 and RT5682
> 1.9.1
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
Mark Brown Oct. 18, 2019, 7:48 p.m. UTC | #2
On Fri, Oct 18, 2019 at 02:35:00PM -0500, Pierre-Louis Bossart wrote:
> On 9/25/19 11:57 AM, sathya.prakash.m.r@intel.com wrote:

> >   create mode 100644 sound/soc/intel/boards/cml_rt1011_rt5682.c
> > 
> > --
> > V3 Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

> Mark, I noticed this morning while rebasing SOF on your tree that those two
> patches have not been merged.
> Not sure if they were missed (the 4 versions were confusing), if you didn't
> see my Acked-by tag or if there was an objection?

I didn't see your ack as it's here and not on either of the patches.
Pierre-Louis Bossart Oct. 24, 2019, 9:05 p.m. UTC | #3
On 9/25/19 11:57 AM, sathya.prakash.m.r@intel.com wrote:
> From: Sathya Prakash M R <sathya.prakash.m.r@intel.com>
> 
> The series adds CML m/c driver with RT5682 on SSP0 and
> RT1011 on SSP1.
> The RT1011 is smart AMP which supports 2 Whoofers and
> 2 tweeter support.
> RT5682 is headset codec supporting playback and record.
> The m/c supports HDMI playback and DMIC record.
> 
> Naveen Manohar (2):
>    ASoC: Intel: boards: Add CML m/c using RT1011 and RT5682
>    ASoC: Intel: Add acpi match for rt1011 based m/c driver
> 
>   sound/soc/intel/boards/Kconfig                    |  18 +
>   sound/soc/intel/boards/Makefile                   |   2 +
>   sound/soc/intel/boards/cml_rt1011_rt5682.c        | 473 ++++++++++++++++++++++
>   sound/soc/intel/common/soc-acpi-intel-cnl-match.c |   7 +
>   4 files changed, 500 insertions(+)
>   create mode 100644 sound/soc/intel/boards/cml_rt1011_rt5682.c

re-adding my tag for the series

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

> V3 Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Changes from V3: repost with more recipients and edits to commit messages
> Changes from V2: re ordered match table
> to ensure non i2c device matches are at the end
> Changes from V1:
> Addressed comments on
> ASoC: Intel: boards: Add CML m/c using RT1011 and RT5682
> 1.9.1
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>