| Message ID | 20191024171406.12504-1-eperezma@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Packed virtqueue for virtio | expand |
On 2019/10/25 上午1:13, Eugenio Pérez wrote: > Hi: > > This is an updated version of packed virtqueue support based on Wei and Jason's > V5, mainly solving the clang leak detector error CI gave. > > Please review. > > Changes from V5: > - Fix qemu's CI asan error. > - Move/copy rcu comments. > - Merge duplicated vdev->broken check between split and packet version. > > Eugenio Pérez (3): > virtio: Free rng and blk virqueues > virtio: add some rcu comments > virtio: Move vdev->broken check to dispatch drop_all > > Jason Wang (4): > virtio: basic packed virtqueue support > virtio: event suppression support for packed ring > vhost_net: enable packed ring support > virtio: add property to enable packed virtqueue > > Wei Xu (2): > virtio: basic structure for packed ring > virtio: device/driverr area size calculation refactor for split ring Looks good to me. Just two nits: I tend to squash patch 8 and patch 9 into the patch that introduces those issues and split patch 3 into two parts. Btw, if you wish you can add your s-o-b to the series. Do you want to post a new version or I can tweak them by myself? Thanks > > hw/block/virtio-blk.c | 7 +- > hw/char/virtio-serial-bus.c | 2 +- > hw/net/vhost_net.c | 2 + > hw/scsi/virtio-scsi.c | 3 +- > hw/virtio/virtio-rng.c | 1 + > hw/virtio/virtio.c | 1154 ++++++++++++++++++++++++++++++++++++++----- > include/hw/virtio/virtio.h | 14 +- > 7 files changed, 1045 insertions(+), 138 deletions(-) >
Hi Jason! I can post a new version. You will have it in a moment. Thanks! On Fri, Oct 25, 2019 at 5:20 AM Jason Wang <jasowang@redhat.com> wrote: > > > On 2019/10/25 上午1:13, Eugenio Pérez wrote: > > Hi: > > > > This is an updated version of packed virtqueue support based on Wei and Jason's > > V5, mainly solving the clang leak detector error CI gave. > > > > Please review. > > > > Changes from V5: > > - Fix qemu's CI asan error. > > - Move/copy rcu comments. > > - Merge duplicated vdev->broken check between split and packet version. > > > > Eugenio Pérez (3): > > virtio: Free rng and blk virqueues > > virtio: add some rcu comments > > virtio: Move vdev->broken check to dispatch drop_all > > > > Jason Wang (4): > > virtio: basic packed virtqueue support > > virtio: event suppression support for packed ring > > vhost_net: enable packed ring support > > virtio: add property to enable packed virtqueue > > > > Wei Xu (2): > > virtio: basic structure for packed ring > > virtio: device/driverr area size calculation refactor for split ring > > > Looks good to me. > > Just two nits: > > I tend to squash patch 8 and patch 9 into the patch that introduces > those issues and split patch 3 into two parts. > > Btw, if you wish you can add your s-o-b to the series. > > Do you want to post a new version or I can tweak them by myself? > > Thanks > > > > > > hw/block/virtio-blk.c | 7 +- > > hw/char/virtio-serial-bus.c | 2 +- > > hw/net/vhost_net.c | 2 + > > hw/scsi/virtio-scsi.c | 3 +- > > hw/virtio/virtio-rng.c | 1 + > > hw/virtio/virtio.c | 1154 ++++++++++++++++++++++++++++++++++++++----- > > include/hw/virtio/virtio.h | 14 +- > > 7 files changed, 1045 insertions(+), 138 deletions(-) > >