mbox

[PULL,00/11] MIPS queue for October 24th, 2019

Message ID 1571915195-4381-1-git-send-email-aleksandar.markovic@rt-rk.com (mailing list archive)
State New, archived
Headers show

Pull-request

https://github.com/AMarkovic/qemu tags/mips-queue-oct-24-2019

Message

Aleksandar Markovic Oct. 24, 2019, 11:06 a.m. UTC 
From: Aleksandar Markovic <amarkovic@wavecomp.com>

The following changes since commit ea0ec714d3109e0d0523b9dacb38030e4cb142a8:

  Merge remote-tracking branch 'remotes/xtensa/tags/20191023-xtensa' into staging (2019-10-24 09:55:01 +0100)

are available in the git repository at:

  https://github.com/AMarkovic/qemu tags/mips-queue-oct-24-2019

for you to fetch changes up to f4d200d0e55ebc4e9c9af50cb9317e2f6ebe9d0c:

  target/mips: Add support for emulation of CRC32 group of instructions (2019-10-24 13:00:37 +0200)

----------------------------------------------------------------

MIPS queue for October 24th, 2019

  - added emulation of R6 CRC32 instructions 
  - added several mostly cosmetic leanups
  - a checkpath warning is a false positive

----------------------------------------------------------------

Aleksandar Markovic (10):
  target/mips: Clean up helper.c
  target/mips: Clean up op_helper.c
  MAINTAINERS: Update mail address of Aleksandar Rikalo
  target/mips: msa: Split helpers for <MAX|MIN>_A.<B|H|W|D>
  target/mips: msa: Split helpers for <MAX|MIN>_<S|U>.<B|H|W|D>
  target/mips: msa: Split helpers for ILV<EV|OD|L|R>.<B|H|W|D>
  target/mips: msa: Split helpers for ADD<_A|S_A|S_S|S_U|V>.<B|H|W|D>
  target/mips: msa: Split helpers for HADD_<S|U>.<H|W|D>
  target/mips: msa: Split helpers for S<LL|RA|RAR|RL|RLR>.<B|H|W|D>
  target/mips: msa: Split helpers for PCK<EV|OD>.<B|H|W|D>

Yongbok Kim (1):
  target/mips: Add support for emulation of CRC32 group of instructions

 .mailmap                 |    5 +-
 MAINTAINERS              |   18 +-
 disas/mips.c             |    8 +
 target/mips/helper.c     |  123 +-
 target/mips/helper.h     |  135 +-
 target/mips/msa_helper.c | 4244 +++++++++++++++++++++++++++++-----------------
 target/mips/op_helper.c  | 1032 +++++++----
 target/mips/translate.c  |  483 +++++-
 8 files changed, 4039 insertions(+), 2009 deletions(-)

Comments

no-reply@patchew.org Oct. 25, 2019, 4:43 a.m. UTC | #1 
Patchew URL: https://patchew.org/QEMU/1571915195-4381-1-git-send-email-aleksandar.markovic@rt-rk.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL 00/11] MIPS queue for October 24th, 2019
Type: series
Message-id: 1571915195-4381-1-git-send-email-aleksandar.markovic@rt-rk.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
54710a8 target/mips: Add support for emulation of CRC32 group of instructions
d8645d0 target/mips: msa: Split helpers for PCK<EV|OD>.<B|H|W|D>
e3c1ee9 target/mips: msa: Split helpers for S<LL|RA|RAR|RL|RLR>.<B|H|W|D>
6bb4421 target/mips: msa: Split helpers for HADD_<S|U>.<H|W|D>
0f4cc5e target/mips: msa: Split helpers for ADD<_A|S_A|S_S|S_U|V>.<B|H|W|D>
009d120 target/mips: msa: Split helpers for ILV<EV|OD|L|R>.<B|H|W|D>
cfe231b target/mips: msa: Split helpers for <MAX|MIN>_<S|U>.<B|H|W|D>
34a0fab target/mips: msa: Split helpers for <MAX|MIN>_A.<B|H|W|D>
c169d7e MAINTAINERS: Update mail address of Aleksandar Rikalo
832615f target/mips: Clean up op_helper.c
d177c65 target/mips: Clean up helper.c

=== OUTPUT BEGIN ===
1/11 Checking commit d177c65047a3 (target/mips: Clean up helper.c)
2/11 Checking commit 832615f56fef (target/mips: Clean up op_helper.c)
ERROR: spaces required around that '*' (ctx:WxV)
#1060: FILE: target/mips/op_helper.c:3871:
+                                  float_status *status)              \
                                                ^

total: 1 errors, 0 warnings, 1681 lines checked

Patch 2/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/11 Checking commit c169d7e49e4c (MAINTAINERS: Update mail address of Aleksandar Rikalo)
4/11 Checking commit 34a0fabb8579 (target/mips: msa: Split helpers for <MAX|MIN>_A.<B|H|W|D>)
5/11 Checking commit cfe231b2ea70 (target/mips: msa: Split helpers for <MAX|MIN>_<S|U>.<B|H|W|D>)
6/11 Checking commit 009d120710e1 (target/mips: msa: Split helpers for ILV<EV|OD|L|R>.<B|H|W|D>)
7/11 Checking commit 0f4cc5edd2d0 (target/mips: msa: Split helpers for ADD<_A|S_A|S_S|S_U|V>.<B|H|W|D>)
8/11 Checking commit 6bb44211f0a5 (target/mips: msa: Split helpers for HADD_<S|U>.<H|W|D>)
9/11 Checking commit e3c1ee9fd9b7 (target/mips: msa: Split helpers for S<LL|RA|RAR|RL|RLR>.<B|H|W|D>)
10/11 Checking commit d8645d096706 (target/mips: msa: Split helpers for PCK<EV|OD>.<B|H|W|D>)
11/11 Checking commit 54710a87852c (target/mips: Add support for emulation of CRC32 group of instructions)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1571915195-4381-1-git-send-email-aleksandar.markovic@rt-rk.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Peter Maydell Oct. 25, 2019, 9:31 a.m. UTC | #2 
On Thu, 24 Oct 2019 at 12:07, Aleksandar Markovic
<aleksandar.markovic@rt-rk.com> wrote:
>
> From: Aleksandar Markovic <amarkovic@wavecomp.com>
>
> The following changes since commit ea0ec714d3109e0d0523b9dacb38030e4cb142a8:
>
>   Merge remote-tracking branch 'remotes/xtensa/tags/20191023-xtensa' into staging (2019-10-24 09:55:01 +0100)
>
> are available in the git repository at:
>
>   https://github.com/AMarkovic/qemu tags/mips-queue-oct-24-2019
>
> for you to fetch changes up to f4d200d0e55ebc4e9c9af50cb9317e2f6ebe9d0c:
>
>   target/mips: Add support for emulation of CRC32 group of instructions (2019-10-24 13:00:37 +0200)
>
> ----------------------------------------------------------------
>
> MIPS queue for October 24th, 2019
>
>   - added emulation of R6 CRC32 instructions
>   - added several mostly cosmetic leanups
>   - a checkpath warning is a false positive
>

Hi; this fails to compile with 'implicit conversion' errors
on clang (OSX, freebsd, openbsd, and linux):


/home/petmay01/linaro/qemu-for-merges/target/mips/op_helper.c:359:44:
error: implicit conversion from 'unsigned long long' to 'target_ulong'
(aka 'unsigned int') changes value from 18446744073709551615 to
4294967295 [-Werror,-Wconstant-conversion]
    target_ulong mask = ((sz * 8) == 64) ? -1ULL : ((1ULL << (sz * 8)) - 1);
                 ~~~~                      ^~~~~
/home/petmay01/linaro/qemu-for-merges/target/mips/op_helper.c:369:44:
error: implicit conversion from 'unsigned long long' to 'target_ulong'
(aka 'unsigned int') changes value from 18446744073709551615 to
4294967295 [-Werror,-Wconstant-conversion]
    target_ulong mask = ((sz * 8) == 64) ? -1ULL : ((1ULL << (sz * 8)) - 1);
                 ~~~~                      ^~~~~
2 errors generated.


thanks
-- PMM
Aleksandar Markovic Oct. 25, 2019, 4:43 p.m. UTC | #3 
> Hi; this fails to compile with 'implicit conversion' errors
> on clang (OSX, freebsd, openbsd, and linux):


I am going to send v2 shortly, that will not contain the offending patch.

Sorry about this.

Aleksandar