| Message ID | 20191025044721.16617-3-alastair@au1.ibm.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add support for OpenCAPI SCM devices | expand |
On 25/10/19 3:46 pm, Alastair D'Silva wrote: > From: Alastair D'Silva <alastair@d-silva.org> > > These functions don't exist, so remove the prototypes for them. > > Signed-off-by: Alastair D'Silva <alastair@d-silva.org> Indeed, they do not. Reviewed-by: Andrew Donnellan <ajd@linux.ibm.com> > --- > drivers/nvdimm/nd-core.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/nvdimm/nd-core.h b/drivers/nvdimm/nd-core.h > index 25fa121104d0..9f121a6aeb02 100644 > --- a/drivers/nvdimm/nd-core.h > +++ b/drivers/nvdimm/nd-core.h > @@ -124,11 +124,7 @@ void nd_region_create_dax_seed(struct nd_region *nd_region); > int nvdimm_bus_create_ndctl(struct nvdimm_bus *nvdimm_bus); > void nvdimm_bus_destroy_ndctl(struct nvdimm_bus *nvdimm_bus); > void nd_synchronize(void); > -int nvdimm_bus_register_dimms(struct nvdimm_bus *nvdimm_bus); > -int nvdimm_bus_register_regions(struct nvdimm_bus *nvdimm_bus); > -int nvdimm_bus_init_interleave_sets(struct nvdimm_bus *nvdimm_bus); > void __nd_device_register(struct device *dev); > -int nd_match_dimm(struct device *dev, void *data); > struct nd_label_id; > char *nd_label_gen_id(struct nd_label_id *label_id, u8 *uuid, u32 flags); > bool nd_is_uuid_unique(struct device *dev, u8 *uuid); >
Le 25/10/2019 à 06:46, Alastair D'Silva a écrit : > From: Alastair D'Silva <alastair@d-silva.org> > > These functions don't exist, so remove the prototypes for them. > > Signed-off-by: Alastair D'Silva <alastair@d-silva.org> > --- Reviewed-by: Frederic Barrat <fbarrat@linux.ibm.com> > drivers/nvdimm/nd-core.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/nvdimm/nd-core.h b/drivers/nvdimm/nd-core.h > index 25fa121104d0..9f121a6aeb02 100644 > --- a/drivers/nvdimm/nd-core.h > +++ b/drivers/nvdimm/nd-core.h > @@ -124,11 +124,7 @@ void nd_region_create_dax_seed(struct nd_region *nd_region); > int nvdimm_bus_create_ndctl(struct nvdimm_bus *nvdimm_bus); > void nvdimm_bus_destroy_ndctl(struct nvdimm_bus *nvdimm_bus); > void nd_synchronize(void); > -int nvdimm_bus_register_dimms(struct nvdimm_bus *nvdimm_bus); > -int nvdimm_bus_register_regions(struct nvdimm_bus *nvdimm_bus); > -int nvdimm_bus_init_interleave_sets(struct nvdimm_bus *nvdimm_bus); > void __nd_device_register(struct device *dev); > -int nd_match_dimm(struct device *dev, void *data); > struct nd_label_id; > char *nd_label_gen_id(struct nd_label_id *label_id, u8 *uuid, u32 flags); > bool nd_is_uuid_unique(struct device *dev, u8 *uuid); >
On Thu, Oct 24, 2019 at 9:49 PM Alastair D'Silva <alastair@au1.ibm.com> wrote: > > From: Alastair D'Silva <alastair@d-silva.org> > > These functions don't exist, so remove the prototypes for them. > > Signed-off-by: Alastair D'Silva <alastair@d-silva.org> Looks good, applied.
diff --git a/drivers/nvdimm/nd-core.h b/drivers/nvdimm/nd-core.h index 25fa121104d0..9f121a6aeb02 100644 --- a/drivers/nvdimm/nd-core.h +++ b/drivers/nvdimm/nd-core.h @@ -124,11 +124,7 @@ void nd_region_create_dax_seed(struct nd_region *nd_region); int nvdimm_bus_create_ndctl(struct nvdimm_bus *nvdimm_bus); void nvdimm_bus_destroy_ndctl(struct nvdimm_bus *nvdimm_bus); void nd_synchronize(void); -int nvdimm_bus_register_dimms(struct nvdimm_bus *nvdimm_bus); -int nvdimm_bus_register_regions(struct nvdimm_bus *nvdimm_bus); -int nvdimm_bus_init_interleave_sets(struct nvdimm_bus *nvdimm_bus); void __nd_device_register(struct device *dev); -int nd_match_dimm(struct device *dev, void *data); struct nd_label_id; char *nd_label_gen_id(struct nd_label_id *label_id, u8 *uuid, u32 flags); bool nd_is_uuid_unique(struct device *dev, u8 *uuid);