mbox series

[v2,00/12] ACPICA version 20191018v2

Message ID 20191025213700.14685-1-erik.schmauss@intel.com (mailing list archive)
Headers show
Series ACPICA version 20191018v2 | expand

Message

Schmauss, Erik Oct. 25, 2019, 9:36 p.m. UTC
V2 - fixed build warnings

This patchset contains the linuxized patches for ACPICA version
20191018. There are several debugger changes but they are meant for
acpiexec at this time. acpi_load_table definition has been modified and
a new acpi_unload_table has been added. These new interfaces can be used
as a part of config fs to load and unload tables.

Other than that, Bob has run clang on our code base and removed several
compiler warnings.

This patchset is also available here:
https://github.com/SchmErik/linux/tree/v20191018


Bob Moore (5):
  ACPICA: Results from Clang changes/fixes From Clang V5.0.1. Mostly
    "set but never read" warnings.
  ACPICA: Win OSL: Replace get_tick_count with get_tick_count64
  ACPICA: More Clang changes - V8.0.1 Fixed all "dead assignment"
    warnings.
  ACPICA: Add new external interface, acpi_unload_table
  ACPICA: Update version to 20191018

Erik Schmauss (6):
  ACPICA: utilities: add flag to only display data when dumping buffers
  ACPICA: debugger: add command to dump all fields of a particular
    subtype
  ACPICA: debugger: surround field unit output with braces '{'
  ACPICA: debugger: add field unit support for acpi_db_get_next_token
  ACPICA: acpiexec: initialize all simple types and field units from
    user input
  ACPICA: debugger: remove leading whitespaces when converting a string
    to a buffer

Nikolaus Voss (1):
  ACPICA: make acpi_load_table() return table index

 drivers/acpi/acpi_configfs.c    |   2 +-
 drivers/acpi/acpica/acdebug.h   |   2 +
 drivers/acpi/acpica/acstruct.h  |  10 +++
 drivers/acpi/acpica/acutils.h   |   9 +--
 drivers/acpi/acpica/dbconvert.c |   4 ++
 drivers/acpi/acpica/dbdisply.c  |   2 -
 drivers/acpi/acpica/dbfileio.c  |   2 +-
 drivers/acpi/acpica/dbinput.c   |  36 +++++++++-
 drivers/acpi/acpica/dbmethod.c  |   4 ++
 drivers/acpi/acpica/dbnames.c   | 114 ++++++++++++++++++++++++++++++++
 drivers/acpi/acpica/dbobject.c  |   1 -
 drivers/acpi/acpica/dscontrol.c |   2 +-
 drivers/acpi/acpica/dsfield.c   |  12 +---
 drivers/acpi/acpica/evgpeblk.c  |  11 +--
 drivers/acpi/acpica/evgpeinit.c |   3 -
 drivers/acpi/acpica/evmisc.c    |  12 +++-
 drivers/acpi/acpica/evregion.c  |   4 +-
 drivers/acpi/acpica/evrgnini.c  |   1 -
 drivers/acpi/acpica/hwxfsleep.c |   3 +
 drivers/acpi/acpica/nsconvert.c |   2 +-
 drivers/acpi/acpica/nsdump.c    |   6 +-
 drivers/acpi/acpica/nsxfname.c  |   4 +-
 drivers/acpi/acpica/psobject.c  |   7 +-
 drivers/acpi/acpica/rscreate.c  |   3 +
 drivers/acpi/acpica/tbdata.c    |   3 +
 drivers/acpi/acpica/tbxfload.c  |  40 ++++++++++-
 drivers/acpi/acpica/utbuffer.c  |  52 ++++++++-------
 drivers/acpi/acpica/utids.c     |   2 -
 drivers/acpi/acpica/uttrack.c   |   2 +-
 drivers/firmware/efi/efi.c      |   2 +-
 include/acpi/acpixf.h           |   8 ++-
 31 files changed, 291 insertions(+), 74 deletions(-)

Comments

Andy Shevchenko Oct. 26, 2019, 2:42 p.m. UTC | #1
On Fri, Oct 25, 2019 at 02:36:48PM -0700, Erik Schmauss wrote:
> V2 - fixed build warnings
> 
> This patchset contains the linuxized patches for ACPICA version
> 20191018. There are several debugger changes but they are meant for
> acpiexec at this time. acpi_load_table definition has been modified and
> a new acpi_unload_table has been added. These new interfaces can be used
> as a part of config fs to load and unload tables.
> 
> Other than that, Bob has run clang on our code base and removed several
> compiler warnings.
> 
> This patchset is also available here:
> https://github.com/SchmErik/linux/tree/v20191018

Thanks!
I'll be able to test this next week.

> 
> Bob Moore (5):
>   ACPICA: Results from Clang changes/fixes From Clang V5.0.1. Mostly
>     "set but never read" warnings.
>   ACPICA: Win OSL: Replace get_tick_count with get_tick_count64
>   ACPICA: More Clang changes - V8.0.1 Fixed all "dead assignment"
>     warnings.
>   ACPICA: Add new external interface, acpi_unload_table
>   ACPICA: Update version to 20191018
> 
> Erik Schmauss (6):
>   ACPICA: utilities: add flag to only display data when dumping buffers
>   ACPICA: debugger: add command to dump all fields of a particular
>     subtype
>   ACPICA: debugger: surround field unit output with braces '{'
>   ACPICA: debugger: add field unit support for acpi_db_get_next_token
>   ACPICA: acpiexec: initialize all simple types and field units from
>     user input
>   ACPICA: debugger: remove leading whitespaces when converting a string
>     to a buffer
> 
> Nikolaus Voss (1):
>   ACPICA: make acpi_load_table() return table index
> 
>  drivers/acpi/acpi_configfs.c    |   2 +-
>  drivers/acpi/acpica/acdebug.h   |   2 +
>  drivers/acpi/acpica/acstruct.h  |  10 +++
>  drivers/acpi/acpica/acutils.h   |   9 +--
>  drivers/acpi/acpica/dbconvert.c |   4 ++
>  drivers/acpi/acpica/dbdisply.c  |   2 -
>  drivers/acpi/acpica/dbfileio.c  |   2 +-
>  drivers/acpi/acpica/dbinput.c   |  36 +++++++++-
>  drivers/acpi/acpica/dbmethod.c  |   4 ++
>  drivers/acpi/acpica/dbnames.c   | 114 ++++++++++++++++++++++++++++++++
>  drivers/acpi/acpica/dbobject.c  |   1 -
>  drivers/acpi/acpica/dscontrol.c |   2 +-
>  drivers/acpi/acpica/dsfield.c   |  12 +---
>  drivers/acpi/acpica/evgpeblk.c  |  11 +--
>  drivers/acpi/acpica/evgpeinit.c |   3 -
>  drivers/acpi/acpica/evmisc.c    |  12 +++-
>  drivers/acpi/acpica/evregion.c  |   4 +-
>  drivers/acpi/acpica/evrgnini.c  |   1 -
>  drivers/acpi/acpica/hwxfsleep.c |   3 +
>  drivers/acpi/acpica/nsconvert.c |   2 +-
>  drivers/acpi/acpica/nsdump.c    |   6 +-
>  drivers/acpi/acpica/nsxfname.c  |   4 +-
>  drivers/acpi/acpica/psobject.c  |   7 +-
>  drivers/acpi/acpica/rscreate.c  |   3 +
>  drivers/acpi/acpica/tbdata.c    |   3 +
>  drivers/acpi/acpica/tbxfload.c  |  40 ++++++++++-
>  drivers/acpi/acpica/utbuffer.c  |  52 ++++++++-------
>  drivers/acpi/acpica/utids.c     |   2 -
>  drivers/acpi/acpica/uttrack.c   |   2 +-
>  drivers/firmware/efi/efi.c      |   2 +-
>  include/acpi/acpixf.h           |   8 ++-
>  31 files changed, 291 insertions(+), 74 deletions(-)
> 
> -- 
> 2.21.0
>
Andy Shevchenko Oct. 28, 2019, 3:58 p.m. UTC | #2
On Fri, Oct 25, 2019 at 02:36:48PM -0700, Erik Schmauss wrote:
> V2 - fixed build warnings
> 
> This patchset contains the linuxized patches for ACPICA version
> 20191018. There are several debugger changes but they are meant for
> acpiexec at this time. acpi_load_table definition has been modified and
> a new acpi_unload_table has been added. These new interfaces can be used
> as a part of config fs to load and unload tables.
> 
> Other than that, Bob has run clang on our code base and removed several
> compiler warnings.
> 
> This patchset is also available here:
> https://github.com/SchmErik/linux/tree/v20191018
> 

I have tested this series and it works in my case.
Thank you!

P.S. Rafael, I think we can also append the oneliner I have added in the comment
to the patch 5.

> 
> Bob Moore (5):
>   ACPICA: Results from Clang changes/fixes From Clang V5.0.1. Mostly
>     "set but never read" warnings.
>   ACPICA: Win OSL: Replace get_tick_count with get_tick_count64
>   ACPICA: More Clang changes - V8.0.1 Fixed all "dead assignment"
>     warnings.
>   ACPICA: Add new external interface, acpi_unload_table
>   ACPICA: Update version to 20191018
> 
> Erik Schmauss (6):
>   ACPICA: utilities: add flag to only display data when dumping buffers
>   ACPICA: debugger: add command to dump all fields of a particular
>     subtype
>   ACPICA: debugger: surround field unit output with braces '{'
>   ACPICA: debugger: add field unit support for acpi_db_get_next_token
>   ACPICA: acpiexec: initialize all simple types and field units from
>     user input
>   ACPICA: debugger: remove leading whitespaces when converting a string
>     to a buffer
> 
> Nikolaus Voss (1):
>   ACPICA: make acpi_load_table() return table index
> 
>  drivers/acpi/acpi_configfs.c    |   2 +-
>  drivers/acpi/acpica/acdebug.h   |   2 +
>  drivers/acpi/acpica/acstruct.h  |  10 +++
>  drivers/acpi/acpica/acutils.h   |   9 +--
>  drivers/acpi/acpica/dbconvert.c |   4 ++
>  drivers/acpi/acpica/dbdisply.c  |   2 -
>  drivers/acpi/acpica/dbfileio.c  |   2 +-
>  drivers/acpi/acpica/dbinput.c   |  36 +++++++++-
>  drivers/acpi/acpica/dbmethod.c  |   4 ++
>  drivers/acpi/acpica/dbnames.c   | 114 ++++++++++++++++++++++++++++++++
>  drivers/acpi/acpica/dbobject.c  |   1 -
>  drivers/acpi/acpica/dscontrol.c |   2 +-
>  drivers/acpi/acpica/dsfield.c   |  12 +---
>  drivers/acpi/acpica/evgpeblk.c  |  11 +--
>  drivers/acpi/acpica/evgpeinit.c |   3 -
>  drivers/acpi/acpica/evmisc.c    |  12 +++-
>  drivers/acpi/acpica/evregion.c  |   4 +-
>  drivers/acpi/acpica/evrgnini.c  |   1 -
>  drivers/acpi/acpica/hwxfsleep.c |   3 +
>  drivers/acpi/acpica/nsconvert.c |   2 +-
>  drivers/acpi/acpica/nsdump.c    |   6 +-
>  drivers/acpi/acpica/nsxfname.c  |   4 +-
>  drivers/acpi/acpica/psobject.c  |   7 +-
>  drivers/acpi/acpica/rscreate.c  |   3 +
>  drivers/acpi/acpica/tbdata.c    |   3 +
>  drivers/acpi/acpica/tbxfload.c  |  40 ++++++++++-
>  drivers/acpi/acpica/utbuffer.c  |  52 ++++++++-------
>  drivers/acpi/acpica/utids.c     |   2 -
>  drivers/acpi/acpica/uttrack.c   |   2 +-
>  drivers/firmware/efi/efi.c      |   2 +-
>  include/acpi/acpixf.h           |   8 ++-
>  31 files changed, 291 insertions(+), 74 deletions(-)
> 
> -- 
> 2.21.0
>
Schmauss, Erik Oct. 28, 2019, 5:49 p.m. UTC | #3
> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Sent: Monday, October 28, 2019 8:59 AM
> To: Schmauss, Erik <erik.schmauss@intel.com>
> Cc: Rafael J . Wysocki <rafael@kernel.org>; linux-acpi@vger.kernel.org
> Subject: Re: [PATCH v2 00/12] ACPICA version 20191018v2
> 
> On Fri, Oct 25, 2019 at 02:36:48PM -0700, Erik Schmauss wrote:
> > V2 - fixed build warnings
> >
> > This patchset contains the linuxized patches for ACPICA version
> > 20191018. There are several debugger changes but they are meant for
> > acpiexec at this time. acpi_load_table definition has been modified
> > and a new acpi_unload_table has been added. These new interfaces can
> > be used as a part of config fs to load and unload tables.
> >
> > Other than that, Bob has run clang on our code base and removed
> > several compiler warnings.
> >
> > This patchset is also available here:
> > https://github.com/SchmErik/linux/tree/v20191018
> >
> 
> I have tested this series and it works in my case.
> Thank you!
> 
> P.S. Rafael, I think we can also append the oneliner I have added in the
> comment to the patch 5.

I agree. It makes sense to use the interface in the same commit for linux

> 
> >
> > Bob Moore (5):
> >   ACPICA: Results from Clang changes/fixes From Clang V5.0.1. Mostly
> >     "set but never read" warnings.
> >   ACPICA: Win OSL: Replace get_tick_count with get_tick_count64
> >   ACPICA: More Clang changes - V8.0.1 Fixed all "dead assignment"
> >     warnings.
> >   ACPICA: Add new external interface, acpi_unload_table
> >   ACPICA: Update version to 20191018
> >
> > Erik Schmauss (6):
> >   ACPICA: utilities: add flag to only display data when dumping buffers
> >   ACPICA: debugger: add command to dump all fields of a particular
> >     subtype
> >   ACPICA: debugger: surround field unit output with braces '{'
> >   ACPICA: debugger: add field unit support for acpi_db_get_next_token
> >   ACPICA: acpiexec: initialize all simple types and field units from
> >     user input
> >   ACPICA: debugger: remove leading whitespaces when converting a string
> >     to a buffer
> >
> > Nikolaus Voss (1):
> >   ACPICA: make acpi_load_table() return table index
> >
> >  drivers/acpi/acpi_configfs.c    |   2 +-
> >  drivers/acpi/acpica/acdebug.h   |   2 +
> >  drivers/acpi/acpica/acstruct.h  |  10 +++
> >  drivers/acpi/acpica/acutils.h   |   9 +--
> >  drivers/acpi/acpica/dbconvert.c |   4 ++
> >  drivers/acpi/acpica/dbdisply.c  |   2 -
> >  drivers/acpi/acpica/dbfileio.c  |   2 +-
> >  drivers/acpi/acpica/dbinput.c   |  36 +++++++++-
> >  drivers/acpi/acpica/dbmethod.c  |   4 ++
> >  drivers/acpi/acpica/dbnames.c   | 114 ++++++++++++++++++++++++++++++++
> >  drivers/acpi/acpica/dbobject.c  |   1 -
> >  drivers/acpi/acpica/dscontrol.c |   2 +-
> >  drivers/acpi/acpica/dsfield.c   |  12 +---
> >  drivers/acpi/acpica/evgpeblk.c  |  11 +--
> >  drivers/acpi/acpica/evgpeinit.c |   3 -
> >  drivers/acpi/acpica/evmisc.c    |  12 +++-
> >  drivers/acpi/acpica/evregion.c  |   4 +-
> >  drivers/acpi/acpica/evrgnini.c  |   1 -
> >  drivers/acpi/acpica/hwxfsleep.c |   3 +
> >  drivers/acpi/acpica/nsconvert.c |   2 +-
> >  drivers/acpi/acpica/nsdump.c    |   6 +-
> >  drivers/acpi/acpica/nsxfname.c  |   4 +-
> >  drivers/acpi/acpica/psobject.c  |   7 +-
> >  drivers/acpi/acpica/rscreate.c  |   3 +
> >  drivers/acpi/acpica/tbdata.c    |   3 +
> >  drivers/acpi/acpica/tbxfload.c  |  40 ++++++++++-
> > drivers/acpi/acpica/utbuffer.c  |  52 ++++++++-------
> >  drivers/acpi/acpica/utids.c     |   2 -
> >  drivers/acpi/acpica/uttrack.c   |   2 +-
> >  drivers/firmware/efi/efi.c      |   2 +-
> >  include/acpi/acpixf.h           |   8 ++-
> >  31 files changed, 291 insertions(+), 74 deletions(-)
> >
> > --
> > 2.21.0
> >
> 
> --
> With Best Regards,
> Andy Shevchenko
>
Rafael J. Wysocki Oct. 28, 2019, 9:16 p.m. UTC | #4
On Monday, October 28, 2019 6:49:10 PM CET Schmauss, Erik wrote:
> 
> > -----Original Message-----
> > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Sent: Monday, October 28, 2019 8:59 AM
> > To: Schmauss, Erik <erik.schmauss@intel.com>
> > Cc: Rafael J . Wysocki <rafael@kernel.org>; linux-acpi@vger.kernel.org
> > Subject: Re: [PATCH v2 00/12] ACPICA version 20191018v2
> > 
> > On Fri, Oct 25, 2019 at 02:36:48PM -0700, Erik Schmauss wrote:
> > > V2 - fixed build warnings
> > >
> > > This patchset contains the linuxized patches for ACPICA version
> > > 20191018. There are several debugger changes but they are meant for
> > > acpiexec at this time. acpi_load_table definition has been modified
> > > and a new acpi_unload_table has been added. These new interfaces can
> > > be used as a part of config fs to load and unload tables.
> > >
> > > Other than that, Bob has run clang on our code base and removed
> > > several compiler warnings.
> > >
> > > This patchset is also available here:
> > > https://github.com/SchmErik/linux/tree/v20191018
> > >
> > 
> > I have tested this series and it works in my case.
> > Thank you!
> > 
> > P.S. Rafael, I think we can also append the oneliner I have added in the
> > comment to the patch 5.
> 
> I agree. It makes sense to use the interface in the same commit for linux

OK, done.

Please check the result in the bleeding-edge branch of my tree.

Thanks!
Andy Shevchenko Oct. 29, 2019, 9:56 a.m. UTC | #5
On Mon, Oct 28, 2019 at 10:16:58PM +0100, Rafael J. Wysocki wrote:
> On Monday, October 28, 2019 6:49:10 PM CET Schmauss, Erik wrote:
> > > -----Original Message-----
> > > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > Sent: Monday, October 28, 2019 8:59 AM
> > > To: Schmauss, Erik <erik.schmauss@intel.com>
> > > Cc: Rafael J . Wysocki <rafael@kernel.org>; linux-acpi@vger.kernel.org
> > > Subject: Re: [PATCH v2 00/12] ACPICA version 20191018v2
> > > On Fri, Oct 25, 2019 at 02:36:48PM -0700, Erik Schmauss wrote:

> > I agree. It makes sense to use the interface in the same commit for linux
> 
> OK, done.
> 
> Please check the result in the bleeding-edge branch of my tree.

I have checked the contents of the patch 5 and it's fine, thanks!

(Since for the rest I have no changes, I think they are fine as well)