| Message ID | 20191028182254.30739-1-pgwipeout@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | add rk3328 usb3 phy driver | expand |
On 28/10/2019 18:22, Peter Geis wrote: > It took a lot more effort than originally anticipated, but here it is. > This is the driver from [0], updated to work with the current kernel. > I've tested it on the rk3328-roc-cc board, both usb 2.0 and usb 3.0 > devices detect on hotplug. Thanks Peter, I'll try to give this a go on my box for confirmation. One quick comment is that it might be worth importing the version from Rockchip's own kernel tree, as that includes this additional patch which looks like a welcome improvement: https://github.com/rockchip-linux/kernel/commit/12efa9acad65b4c3256683c1ccd769687be3ca56#diff-b6317b3425ac054be551abdcda910b68 Also, as it's a new phy driver, we should keep Kishon (+cc) in the loop as the subsystem maintainer. Robin. > [0] https://github.com/FireflyTeam/kernel/commits/roc-rk3328-cc/drivers/phy/rockchip/phy-rockchip-inno-usb3.c > > Peter Geis (5): > phy: rockchip: add inno-usb3 phy driver > dt-bindings: clean up rockchip grf binding document > Documentation: bindings: add dt documentation for rockchip usb3 phy > arm64: dts: rockchip: add usb3 to rk3328 devicetree > arm64: dts: rockchip: enable usb3 on rk3328-roc-cc > > .../bindings/phy/phy-rockchip-inno-usb3.yaml | 157 +++ > .../devicetree/bindings/soc/rockchip/grf.txt | 8 +- > .../devicetree/bindings/usb/rockchip,dwc3.txt | 9 +- > .../arm64/boot/dts/rockchip/rk3328-roc-cc.dts | 21 + > arch/arm64/boot/dts/rockchip/rk3328.dtsi | 72 ++ > drivers/phy/rockchip/Kconfig | 9 + > drivers/phy/rockchip/Makefile | 1 + > drivers/phy/rockchip/phy-rockchip-inno-usb3.c | 1107 +++++++++++++++++ > 8 files changed, 1378 insertions(+), 6 deletions(-) > create mode 100644 Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb3.yaml > create mode 100644 drivers/phy/rockchip/phy-rockchip-inno-usb3.c >
On 2019-10-28 6:41 pm, Robin Murphy wrote: > On 28/10/2019 18:22, Peter Geis wrote: >> It took a lot more effort than originally anticipated, but here it is. >> This is the driver from [0], updated to work with the current kernel. >> I've tested it on the rk3328-roc-cc board, both usb 2.0 and usb 3.0 >> devices detect on hotplug. > > Thanks Peter, I'll try to give this a go on my box for confirmation. OK, I hooked it up with a vbus-drv-gpio hacked in - USB 2.0 unplug/replug does indeed work fine, but it takes a while to acknowledge an unplug of a USB 3.0 device, and throws a bunch of errors every time: [ 288.229568] usb usb4-port1: Cannot enable. Maybe the USB cable is bad? [ 290.809599] usb usb4-port1: Cannot enable. Maybe the USB cable is bad? [ 293.389594] usb usb4-port1: Cannot enable. Maybe the USB cable is bad? [ 295.969600] usb usb4-port1: Cannot enable. Maybe the USB cable is bad? [ 295.970418] usb 4-1: USB disconnect, device number 10 [ 299.209631] usb usb4-port1: Cannot enable. Maybe the USB cable is bad? [ 301.789655] usb usb4-port1: Cannot enable. Maybe the USB cable is bad? [ 301.790534] usb usb4-port1: attempt power cycle (although new devices are still detected OK eventually) Robin. > One quick comment is that it might be worth importing the version from > Rockchip's own kernel tree, as that includes this additional patch which > looks like a welcome improvement: > > https://github.com/rockchip-linux/kernel/commit/12efa9acad65b4c3256683c1ccd769687be3ca56#diff-b6317b3425ac054be551abdcda910b68 > > > Also, as it's a new phy driver, we should keep Kishon (+cc) in the loop > as the subsystem maintainer. > > Robin. > >> [0] >> https://github.com/FireflyTeam/kernel/commits/roc-rk3328-cc/drivers/phy/rockchip/phy-rockchip-inno-usb3.c >> >> >> Peter Geis (5): >> phy: rockchip: add inno-usb3 phy driver >> dt-bindings: clean up rockchip grf binding document >> Documentation: bindings: add dt documentation for rockchip usb3 phy >> arm64: dts: rockchip: add usb3 to rk3328 devicetree >> arm64: dts: rockchip: enable usb3 on rk3328-roc-cc >> >> .../bindings/phy/phy-rockchip-inno-usb3.yaml | 157 +++ >> .../devicetree/bindings/soc/rockchip/grf.txt | 8 +- >> .../devicetree/bindings/usb/rockchip,dwc3.txt | 9 +- >> .../arm64/boot/dts/rockchip/rk3328-roc-cc.dts | 21 + >> arch/arm64/boot/dts/rockchip/rk3328.dtsi | 72 ++ >> drivers/phy/rockchip/Kconfig | 9 + >> drivers/phy/rockchip/Makefile | 1 + >> drivers/phy/rockchip/phy-rockchip-inno-usb3.c | 1107 +++++++++++++++++ >> 8 files changed, 1378 insertions(+), 6 deletions(-) >> create mode 100644 >> Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb3.yaml >> create mode 100644 drivers/phy/rockchip/phy-rockchip-inno-usb3.c >> > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip
On Tue, Oct 29, 2019, 20:18 Robin Murphy <robin.murphy@arm.com> wrote: > > On 2019-10-28 6:41 pm, Robin Murphy wrote: > > On 28/10/2019 18:22, Peter Geis wrote: > >> It took a lot more effort than originally anticipated, but here it is. > >> This is the driver from [0], updated to work with the current kernel. > >> I've tested it on the rk3328-roc-cc board, both usb 2.0 and usb 3.0 > >> devices detect on hotplug. > > > > Thanks Peter, I'll try to give this a go on my box for confirmation. > > OK, I hooked it up with a vbus-drv-gpio hacked in - USB 2.0 > unplug/replug does indeed work fine, but it takes a while to acknowledge > an unplug of a USB 3.0 device, and throws a bunch of errors every time: > > [ 288.229568] usb usb4-port1: Cannot enable. Maybe the USB cable is bad? > [ 290.809599] usb usb4-port1: Cannot enable. Maybe the USB cable is bad? > [ 293.389594] usb usb4-port1: Cannot enable. Maybe the USB cable is bad? > [ 295.969600] usb usb4-port1: Cannot enable. Maybe the USB cable is bad? > [ 295.970418] usb 4-1: USB disconnect, device number 10 > [ 299.209631] usb usb4-port1: Cannot enable. Maybe the USB cable is bad? > [ 301.789655] usb usb4-port1: Cannot enable. Maybe the USB cable is bad? > [ 301.790534] usb usb4-port1: attempt power cycle > > (although new devices are still detected OK eventually) > > Robin. (Resending because I forgot the Android Gmail app fails at plain text) Thanks! May I ask which board and what type of USB 3 device it was? (I tried a usb3 hub and a Samsung sad) Also I noticed some odd behavior when I was getting it to work. When the u3phy driver loaded but wasn't tied to the controller, it would put everything to sleep. In this state, the u2 host port also failed to enumerate on boot. It's almost as if they have something common between them that isn't being accounted for in the u2 driver. With the u3phy driver loaded and tied to the controller, I couldn't get a low speed device to work in the u2 host port (the aeotec zwave stick at 12m) but a hs device works fine. > > > > One quick comment is that it might be worth importing the version from > > Rockchip's own kernel tree, as that includes this additional patch which > > looks like a welcome improvement: > > > > https://github.com/rockchip-linux/kernel/commit/12efa9acad65b4c3256683c1ccd769687be3ca56#diff-b6317b3425ac054be551abdcda910b68 > > > > > > Also, as it's a new phy driver, we should keep Kishon (+cc) in the loop > > as the subsystem maintainer. > > > > Robin. > > > >> [0] > >> https://github.com/FireflyTeam/kernel/commits/roc-rk3328-cc/drivers/phy/rockchip/phy-rockchip-inno-usb3.c > >> > >> > >> Peter Geis (5): > >> phy: rockchip: add inno-usb3 phy driver > >> dt-bindings: clean up rockchip grf binding document > >> Documentation: bindings: add dt documentation for rockchip usb3 phy > >> arm64: dts: rockchip: add usb3 to rk3328 devicetree > >> arm64: dts: rockchip: enable usb3 on rk3328-roc-cc > >> > >> .../bindings/phy/phy-rockchip-inno-usb3.yaml | 157 +++ > >> .../devicetree/bindings/soc/rockchip/grf.txt | 8 +- > >> .../devicetree/bindings/usb/rockchip,dwc3.txt | 9 +- > >> .../arm64/boot/dts/rockchip/rk3328-roc-cc.dts | 21 + > >> arch/arm64/boot/dts/rockchip/rk3328.dtsi | 72 ++ > >> drivers/phy/rockchip/Kconfig | 9 + > >> drivers/phy/rockchip/Makefile | 1 + > >> drivers/phy/rockchip/phy-rockchip-inno-usb3.c | 1107 +++++++++++++++++ > >> 8 files changed, 1378 insertions(+), 6 deletions(-) > >> create mode 100644 > >> Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb3.yaml > >> create mode 100644 drivers/phy/rockchip/phy-rockchip-inno-usb3.c > >> > > > > _______________________________________________ > > Linux-rockchip mailing list > > Linux-rockchip@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-rockchip
As a status update for this, I have spent quite a while working on this driver. In the end, it appears the available documentation is insufficient. The original driver calls a few registers that are not documented in the TRM. What I have found is the following: The 2.0 functionality works as documented in the original rockchip driver. The 3.0 functionality does not. A 3.0 device does not trigger the interrupt like a 2.0 device does. A 3.0 device causes 0x34 bit 6 to toggle, which is usb3otg_pipe3_phystatus I've enabled all usb3phy interrupts, and cannot get a 3.0 device to trigger any of them. Did the original driver ever work correctly?