| Message ID | 1571023588-9870-1-git-send-email-peter.chen@nxp.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 02f8eb40ef7b141b56eccb4faaf83becac3f1d4b |
| Headers | show |
| Series | [1/1] ARM: dts: imx7s: Add power domain for imx7d HSIC | expand |
Peter, Thank you for this patch, I was out so I will test it early next week and report (together with the USB HSIC driver fixes). Cheers, Andre' On Mon, 2019-10-14 at 11:26 +0800, Peter Chen wrote: > Otherwise, the system will hang if USB driver try to access > portsc register. > > Cc: André Draszik <git@andred.net> > Signed-off-by: Peter Chen <peter.chen@nxp.com> > --- > arch/arm/boot/dts/imx7s.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi > index c1a4fff5ceda..a5b380f530f8 100644 > --- a/arch/arm/boot/dts/imx7s.dtsi > +++ b/arch/arm/boot/dts/imx7s.dtsi > @@ -658,6 +658,12 @@ > reg = <1>; > power-supply = <®_1p0d>; > }; > + > + pgc_hsic_phy: power-domain@2 { > + #power-domain-cells = <0>; > + reg = <2>; > + power-supply = <®_1p2>; > + }; > }; > }; > }; > @@ -1101,6 +1107,7 @@ > compatible = "fsl,imx7d-usb", "fsl,imx27-usb"; > reg = <0x30b30000 0x200>; > interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>; > + power-domains = <&pgc_hsic_phy>; > clocks = <&clks IMX7D_USB_CTRL_CLK>; > fsl,usbphy = <&usbphynop3>; > fsl,usbmisc = <&usbmisc3 0>;
On 19-10-14 11:26:28, Peter Chen wrote: > Otherwise, the system will hang if USB driver try to access > portsc register. > > Cc: André Draszik <git@andred.net> > Signed-off-by: Peter Chen <peter.chen@nxp.com> > --- > arch/arm/boot/dts/imx7s.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi > index c1a4fff5ceda..a5b380f530f8 100644 > --- a/arch/arm/boot/dts/imx7s.dtsi > +++ b/arch/arm/boot/dts/imx7s.dtsi > @@ -658,6 +658,12 @@ > reg = <1>; > power-supply = <®_1p0d>; > }; > + > + pgc_hsic_phy: power-domain@2 { > + #power-domain-cells = <0>; > + reg = <2>; > + power-supply = <®_1p2>; > + }; > }; > }; > }; > @@ -1101,6 +1107,7 @@ > compatible = "fsl,imx7d-usb", "fsl,imx27-usb"; > reg = <0x30b30000 0x200>; > interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>; > + power-domains = <&pgc_hsic_phy>; > clocks = <&clks IMX7D_USB_CTRL_CLK>; > fsl,usbphy = <&usbphynop3>; > fsl,usbmisc = <&usbmisc3 0>; > -- > 2.17.1 > Gentle ping...
Hi Peter, On Thu, 2019-10-31 at 02:18 +0000, Peter Chen wrote: > On 19-10-14 11:26:28, Peter Chen wrote: > > Otherwise, the system will hang if USB driver try to access > > portsc register. > > > > Cc: André Draszik <git@andred.net> > > Signed-off-by: Peter Chen <peter.chen@nxp.com> > > --- > > arch/arm/boot/dts/imx7s.dtsi | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi > > index c1a4fff5ceda..a5b380f530f8 100644 > > --- a/arch/arm/boot/dts/imx7s.dtsi > > +++ b/arch/arm/boot/dts/imx7s.dtsi > > @@ -658,6 +658,12 @@ > > reg = <1>; > > power-supply = <®_1p0d>; > > }; > > + > > + pgc_hsic_phy: power-domain@2 { > > + #power-domain-cells = <0>; > > + reg = <2>; > > + power-supply = <®_1p2>; > > + }; > > }; > > }; > > }; > > @@ -1101,6 +1107,7 @@ > > compatible = "fsl,imx7d-usb", "fsl,imx27-usb"; > > reg = <0x30b30000 0x200>; > > interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>; > > + power-domains = <&pgc_hsic_phy>; > > clocks = <&clks IMX7D_USB_CTRL_CLK>; > > fsl,usbphy = <&usbphynop3>; > > fsl,usbmisc = <&usbmisc3 0>; > > -- > > 2.17.1 > > > > Gentle ping... Sorry for the delay. The kernel hangs even with this extra patch, I suppose when initialising the USB. I haven't had time to look into it, though. But I assume some additional clock might need to be enabled... Cheers, Andre'
diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi index c1a4fff5ceda..a5b380f530f8 100644 --- a/arch/arm/boot/dts/imx7s.dtsi +++ b/arch/arm/boot/dts/imx7s.dtsi @@ -658,6 +658,12 @@ reg = <1>; power-supply = <®_1p0d>; }; + + pgc_hsic_phy: power-domain@2 { + #power-domain-cells = <0>; + reg = <2>; + power-supply = <®_1p2>; + }; }; }; }; @@ -1101,6 +1107,7 @@ compatible = "fsl,imx7d-usb", "fsl,imx27-usb"; reg = <0x30b30000 0x200>; interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>; + power-domains = <&pgc_hsic_phy>; clocks = <&clks IMX7D_USB_CTRL_CLK>; fsl,usbphy = <&usbphynop3>; fsl,usbmisc = <&usbmisc3 0>;
Otherwise, the system will hang if USB driver try to access portsc register. Cc: André Draszik <git@andred.net> Signed-off-by: Peter Chen <peter.chen@nxp.com> --- arch/arm/boot/dts/imx7s.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)