diff mbox series

[v2,11/11] ARM: dts: imx6ul-kontron-n6310-s-43: Add missing includes for GPIOs and IRQs

Message ID 20191029112655.15058-12-frieder.schrempf@kontron.de (mailing list archive)
State New, archived
Headers show
Series Add support for more Kontron i.MX6UL/ULL SoMs and boards | expand

Commit Message

Frieder Schrempf Oct. 29, 2019, 11:28 a.m. UTC 
From: Frieder Schrempf <frieder.schrempf@kontron.de>

Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Fixes: 1ea4b76cdfde ("ARM: dts: imx6ul-kontron-n6310: Add Kontron i.MX6UL N6310 SoM and boards")
---
 arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dts | 3 +++
 1 file changed, 3 insertions(+)

Comments

Frieder Schrempf Oct. 29, 2019, 11:32 a.m. UTC | #1 
On 29.10.19 12:28, Schrempf Frieder wrote:
> From: Frieder Schrempf <frieder.schrempf@kontron.de>

Sorry, the commit message here got lost:

The IRQ and GPIO macros are used in this file. Therefore we add the 
missing header includes.

> 
> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> Fixes: 1ea4b76cdfde ("ARM: dts: imx6ul-kontron-n6310: Add Kontron i.MX6UL N6310 SoM and boards")
> ---
>   arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dts | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dts b/arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dts
> index 5bad29683cc3..295bc3138fea 100644
> --- a/arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dts
> +++ b/arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dts
> @@ -7,6 +7,9 @@
>   
>   #include "imx6ul-kontron-n6310-s.dts"
>   
> +#include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/gpio/gpio.h>
> +
>   / {
>   	model = "Kontron N6310 S 43";
>   	compatible = "kontron,imx6ul-n6310-s-43", "kontron,imx6ul-n6310-s",
>
Krzysztof Kozlowski Oct. 31, 2019, 1:07 p.m. UTC | #2 
On Tue, Oct 29, 2019 at 11:28:16AM +0000, Schrempf Frieder wrote:
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
> 
> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> Fixes: 1ea4b76cdfde ("ARM: dts: imx6ul-kontron-n6310: Add Kontron i.MX6UL N6310 SoM and boards")
> ---
>  arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dts | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dts b/arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dts
> index 5bad29683cc3..295bc3138fea 100644
> --- a/arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dts
> +++ b/arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dts
> @@ -7,6 +7,9 @@
>  
>  #include "imx6ul-kontron-n6310-s.dts"
>  
> +#include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/gpio/gpio.h>

This is not needed. This includes imx6ul-kontron-n6310-s.dts, which
includes imx6ul-kontron-n6310-som.dtsi which has proper GPIO include. It
also polls imx6ul.dtsi which has the IRQ defines.

My comment from v1 was for a case where you have a DTSI standing on its
own. If it does not include anything else, then it should have all
necessary inclusions (not only GPIO but also iMX-specific pinctrl and clock).

Best regards,
Krzysztof


> +
>  / {
>  	model = "Kontron N6310 S 43";
>  	compatible = "kontron,imx6ul-n6310-s-43", "kontron,imx6ul-n6310-s",
> -- 
> 2.17.1
Frieder Schrempf Oct. 31, 2019, 1:11 p.m. UTC | #3 
On 31.10.19 14:07, Krzysztof Kozlowski wrote:
> On Tue, Oct 29, 2019 at 11:28:16AM +0000, Schrempf Frieder wrote:
>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>>
>> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
>> Fixes: 1ea4b76cdfde ("ARM: dts: imx6ul-kontron-n6310: Add Kontron i.MX6UL N6310 SoM and boards")
>> ---
>>   arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dts | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dts b/arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dts
>> index 5bad29683cc3..295bc3138fea 100644
>> --- a/arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dts
>> +++ b/arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dts
>> @@ -7,6 +7,9 @@
>>   
>>   #include "imx6ul-kontron-n6310-s.dts"
>>   
>> +#include <dt-bindings/interrupt-controller/irq.h>
>> +#include <dt-bindings/gpio/gpio.h>
> 
> This is not needed. This includes imx6ul-kontron-n6310-s.dts, which
> includes imx6ul-kontron-n6310-som.dtsi which has proper GPIO include. It
> also polls imx6ul.dtsi which has the IRQ defines.
> 
> My comment from v1 was for a case where you have a DTSI standing on its
> own. If it does not include anything else, then it should have all
> necessary inclusions (not only GPIO but also iMX-specific pinctrl and clock).

Ok, got it. Thanks for clarifying.
This patch can be dropped then.

> 
> Best regards,
> Krzysztof
> 
> 
>> +
>>   / {
>>   	model = "Kontron N6310 S 43";
>>   	compatible = "kontron,imx6ul-n6310-s-43", "kontron,imx6ul-n6310-s",
>> -- 
>> 2.17.1
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dts b/arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dts
index 5bad29683cc3..295bc3138fea 100644
--- a/arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dts
+++ b/arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dts
@@ -7,6 +7,9 @@ 
 
 #include "imx6ul-kontron-n6310-s.dts"
 
+#include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/gpio/gpio.h>
+
 / {
 	model = "Kontron N6310 S 43";
 	compatible = "kontron,imx6ul-n6310-s-43", "kontron,imx6ul-n6310-s",