| Message ID | 20191031110452.73463-5-hare@suse.de (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Revamp SCSI result values | expand |
On 10/31/19 4:04 AM, Hannes Reinecke wrote: > Use midlayer-defined values and drop the non-existing QUEUE_FULL > case. > > [ ... ] > > - case QUEUE_FULL: > - /* TODO: target queue is full */ > - break; Please clarify in the commit message why it is OK to drop this code. Thanks, Bart.
On 11/1/19 5:18 PM, Bart Van Assche wrote: > On 10/31/19 4:04 AM, Hannes Reinecke wrote: >> Use midlayer-defined values and drop the non-existing QUEUE_FULL >> case. >> >> [ ... ] >> - case QUEUE_FULL: >> - /* TODO: target queue is full */ >> - break; > > Please clarify in the commit message why it is OK to drop this code. > Because QUEUE_FULL doesn't exist in this context; QUEUE_FULL is a SCSI status, but the switch is checking SCSI messages. Cheers, Hannes
diff --git a/drivers/scsi/arm/acornscsi.c b/drivers/scsi/arm/acornscsi.c index ddb52e7ba622..8ceb1663bdb5 100644 --- a/drivers/scsi/arm/acornscsi.c +++ b/drivers/scsi/arm/acornscsi.c @@ -144,12 +144,6 @@ #define VER_MINOR 0 #define VER_PATCH 6 -#ifndef ABORT_TAG -#define ABORT_TAG 0xd -#else -#error "Yippee! ABORT TAG is now defined! Remove this error!" -#endif - #ifdef USE_DMAC /* * DMAC setup parameters @@ -1490,8 +1484,8 @@ void acornscsi_message(AS_Host *host) } switch (message[0]) { - case ABORT: - case ABORT_TAG: + case ABORT_TASK_SET: + case ABORT_TASK: case COMMAND_COMPLETE: if (host->scsi.phase != PHASE_STATUSIN) { printk(KERN_ERR "scsi%d.%c: command complete following non-status in phase?\n", @@ -1596,10 +1590,6 @@ void acornscsi_message(AS_Host *host) } break; - case QUEUE_FULL: - /* TODO: target queue is full */ - break; - case SIMPLE_QUEUE_TAG: /* tag queue reconnect... message[1] = queue tag. Print something to indicate something happened! */ printk("scsi%d.%c: reconnect queue tag %02X\n",
Use midlayer-defined values and drop the non-existing QUEUE_FULL case. Signed-off-by: Hannes Reinecke <hare@suse.de> --- drivers/scsi/arm/acornscsi.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-)