| Message ID | 20191013154832.1858884-1-jic23@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iio: adc: rcar-gyroadc: use devm_platform_ioremap_resource | expand |
On Sun, 2019-10-13 at 16:48 +0100, jic23@kernel.org wrote: > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Avoids some local boilerplate. > Suggested by coccinelle. > > CHECK drivers/iio/adc/rcar-gyroadc.c > drivers/iio/adc/rcar-gyroadc.c:495:1-11: WARNING: Use > devm_platform_ioremap_resource for priv -> regs > Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > Cc: Marek Vasut <marek.vasut+renesas@gmail.com> > --- > drivers/iio/adc/rcar-gyroadc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/iio/adc/rcar-gyroadc.c b/drivers/iio/adc/rcar- > gyroadc.c > index c37f201294b2..63ce743ee7af 100644 > --- a/drivers/iio/adc/rcar-gyroadc.c > +++ b/drivers/iio/adc/rcar-gyroadc.c > @@ -481,7 +481,6 @@ static int rcar_gyroadc_probe(struct platform_device > *pdev) > struct device *dev = &pdev->dev; > struct rcar_gyroadc *priv; > struct iio_dev *indio_dev; > - struct resource *mem; > int ret; > > indio_dev = devm_iio_device_alloc(dev, sizeof(*priv)); > @@ -491,8 +490,7 @@ static int rcar_gyroadc_probe(struct platform_device > *pdev) > priv = iio_priv(indio_dev); > priv->dev = dev; > > - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - priv->regs = devm_ioremap_resource(dev, mem); > + priv->regs = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(priv->regs)) > return PTR_ERR(priv->regs); >
On Mon, 4 Nov 2019 15:17:28 +0000 "Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote: > On Sun, 2019-10-13 at 16:48 +0100, jic23@kernel.org wrote: > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > > > Avoids some local boilerplate. > > Suggested by coccinelle. > > > > CHECK drivers/iio/adc/rcar-gyroadc.c > > drivers/iio/adc/rcar-gyroadc.c:495:1-11: WARNING: Use > > devm_platform_ioremap_resource for priv -> regs > > > > Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com> Applied, Thanks, Jonathan > > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Cc: Marek Vasut <marek.vasut+renesas@gmail.com> > > --- > > drivers/iio/adc/rcar-gyroadc.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/iio/adc/rcar-gyroadc.c b/drivers/iio/adc/rcar- > > gyroadc.c > > index c37f201294b2..63ce743ee7af 100644 > > --- a/drivers/iio/adc/rcar-gyroadc.c > > +++ b/drivers/iio/adc/rcar-gyroadc.c > > @@ -481,7 +481,6 @@ static int rcar_gyroadc_probe(struct platform_device > > *pdev) > > struct device *dev = &pdev->dev; > > struct rcar_gyroadc *priv; > > struct iio_dev *indio_dev; > > - struct resource *mem; > > int ret; > > > > indio_dev = devm_iio_device_alloc(dev, sizeof(*priv)); > > @@ -491,8 +490,7 @@ static int rcar_gyroadc_probe(struct platform_device > > *pdev) > > priv = iio_priv(indio_dev); > > priv->dev = dev; > > > > - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > - priv->regs = devm_ioremap_resource(dev, mem); > > + priv->regs = devm_platform_ioremap_resource(pdev, 0); > > if (IS_ERR(priv->regs)) > > return PTR_ERR(priv->regs); > >
diff --git a/drivers/iio/adc/rcar-gyroadc.c b/drivers/iio/adc/rcar-gyroadc.c index c37f201294b2..63ce743ee7af 100644 --- a/drivers/iio/adc/rcar-gyroadc.c +++ b/drivers/iio/adc/rcar-gyroadc.c @@ -481,7 +481,6 @@ static int rcar_gyroadc_probe(struct platform_device *pdev) struct device *dev = &pdev->dev; struct rcar_gyroadc *priv; struct iio_dev *indio_dev; - struct resource *mem; int ret; indio_dev = devm_iio_device_alloc(dev, sizeof(*priv)); @@ -491,8 +490,7 @@ static int rcar_gyroadc_probe(struct platform_device *pdev) priv = iio_priv(indio_dev); priv->dev = dev; - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); - priv->regs = devm_ioremap_resource(dev, mem); + priv->regs = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(priv->regs)) return PTR_ERR(priv->regs);