diff mbox series

[v2,2/5] drm/dsi: add missing DSI data types

Message ID 20191028150047.22048-2-jani.nikula@intel.com (mailing list archive)
State New, archived
Headers show
Series [v2,1/5] drm/dsi: clean up DSI data type definitions | expand

Commit Message

Jani Nikula Oct. 28, 2019, 3 p.m. UTC 
Add execute queue and compressed pixel stream packet data types for
completeness.

Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/drm_mipi_dsi.c | 2 ++
 include/video/mipi_display.h   | 2 ++
 2 files changed, 4 insertions(+)

Comments

Kulkarni, Vandita Oct. 30, 2019, 8:28 a.m. UTC | #1 
> -----Original Message-----
> From: Jani Nikula <jani.nikula@intel.com>
> Sent: Monday, October 28, 2019 8:31 PM
> To: dri-devel@lists.freedesktop.org
> Cc: intel-gfx@lists.freedesktop.org; Nikula, Jani <jani.nikula@intel.com>;
> Kulkarni, Vandita <vandita.kulkarni@intel.com>
> Subject: [PATCH v2 2/5] drm/dsi: add missing DSI data types
> 
> Add execute queue and compressed pixel stream packet data types for
> completeness.
> 
> Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>

Looks good to me.
Reviewed-by: Vandita Kulkarni <vandita.kulkarni@intel.com>

> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/drm_mipi_dsi.c | 2 ++
>  include/video/mipi_display.h   | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_mipi_dsi.c
> b/drivers/gpu/drm/drm_mipi_dsi.c index f237d80828c3..3f33f02571fd
> 100644
> --- a/drivers/gpu/drm/drm_mipi_dsi.c
> +++ b/drivers/gpu/drm/drm_mipi_dsi.c
> @@ -388,6 +388,7 @@ bool mipi_dsi_packet_format_is_short(u8 type)
>  	case MIPI_DSI_DCS_SHORT_WRITE:
>  	case MIPI_DSI_DCS_SHORT_WRITE_PARAM:
>  	case MIPI_DSI_DCS_READ:
> +	case MIPI_DSI_EXECUTE_QUEUE:
>  	case MIPI_DSI_SET_MAXIMUM_RETURN_PACKET_SIZE:
>  		return true;
>  	}
> @@ -411,6 +412,7 @@ bool mipi_dsi_packet_format_is_long(u8 type)
>  	case MIPI_DSI_GENERIC_LONG_WRITE:
>  	case MIPI_DSI_DCS_LONG_WRITE:
>  	case MIPI_DSI_PICTURE_PARAMETER_SET:
> +	case MIPI_DSI_COMPRESSED_PIXEL_STREAM:
>  	case MIPI_DSI_LOOSELY_PACKED_PIXEL_STREAM_YCBCR20:
>  	case MIPI_DSI_PACKED_PIXEL_STREAM_YCBCR24:
>  	case MIPI_DSI_PACKED_PIXEL_STREAM_YCBCR16:
> diff --git a/include/video/mipi_display.h b/include/video/mipi_display.h
> index 79fd71cf4934..6b6390dfa203 100644
> --- a/include/video/mipi_display.h
> +++ b/include/video/mipi_display.h
> @@ -37,6 +37,7 @@ enum {
>  	MIPI_DSI_DCS_SHORT_WRITE_PARAM			= 0x15,
> 
>  	MIPI_DSI_DCS_READ				= 0x06,
> +	MIPI_DSI_EXECUTE_QUEUE				= 0x16,
> 
>  	MIPI_DSI_SET_MAXIMUM_RETURN_PACKET_SIZE		=
> 0x37,
> 
> @@ -46,6 +47,7 @@ enum {
>  	MIPI_DSI_DCS_LONG_WRITE				= 0x39,
> 
>  	MIPI_DSI_PICTURE_PARAMETER_SET			= 0x0a,
> +	MIPI_DSI_COMPRESSED_PIXEL_STREAM		= 0x0b,
> 
>  	MIPI_DSI_LOOSELY_PACKED_PIXEL_STREAM_YCBCR20	= 0x0c,
>  	MIPI_DSI_PACKED_PIXEL_STREAM_YCBCR24		= 0x1c,
> --
> 2.20.1
Thierry Reding Nov. 4, 2019, 3:24 p.m. UTC | #2 
On Mon, Oct 28, 2019 at 05:00:44PM +0200, Jani Nikula wrote:
> Add execute queue and compressed pixel stream packet data types for
> completeness.
> 
> Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/drm_mipi_dsi.c | 2 ++
>  include/video/mipi_display.h   | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c
> index f237d80828c3..3f33f02571fd 100644
> --- a/drivers/gpu/drm/drm_mipi_dsi.c
> +++ b/drivers/gpu/drm/drm_mipi_dsi.c
> @@ -388,6 +388,7 @@ bool mipi_dsi_packet_format_is_short(u8 type)
>  	case MIPI_DSI_DCS_SHORT_WRITE:
>  	case MIPI_DSI_DCS_SHORT_WRITE_PARAM:
>  	case MIPI_DSI_DCS_READ:
> +	case MIPI_DSI_EXECUTE_QUEUE:
>  	case MIPI_DSI_SET_MAXIMUM_RETURN_PACKET_SIZE:
>  		return true;
>  	}
> @@ -411,6 +412,7 @@ bool mipi_dsi_packet_format_is_long(u8 type)
>  	case MIPI_DSI_GENERIC_LONG_WRITE:
>  	case MIPI_DSI_DCS_LONG_WRITE:
>  	case MIPI_DSI_PICTURE_PARAMETER_SET:
> +	case MIPI_DSI_COMPRESSED_PIXEL_STREAM:
>  	case MIPI_DSI_LOOSELY_PACKED_PIXEL_STREAM_YCBCR20:
>  	case MIPI_DSI_PACKED_PIXEL_STREAM_YCBCR24:
>  	case MIPI_DSI_PACKED_PIXEL_STREAM_YCBCR16:
> diff --git a/include/video/mipi_display.h b/include/video/mipi_display.h
> index 79fd71cf4934..6b6390dfa203 100644
> --- a/include/video/mipi_display.h
> +++ b/include/video/mipi_display.h
> @@ -37,6 +37,7 @@ enum {
>  	MIPI_DSI_DCS_SHORT_WRITE_PARAM			= 0x15,
>  
>  	MIPI_DSI_DCS_READ				= 0x06,
> +	MIPI_DSI_EXECUTE_QUEUE				= 0x16,
>  
>  	MIPI_DSI_SET_MAXIMUM_RETURN_PACKET_SIZE		= 0x37,
>  
> @@ -46,6 +47,7 @@ enum {
>  	MIPI_DSI_DCS_LONG_WRITE				= 0x39,
>  
>  	MIPI_DSI_PICTURE_PARAMETER_SET			= 0x0a,
> +	MIPI_DSI_COMPRESSED_PIXEL_STREAM		= 0x0b,
>  
>  	MIPI_DSI_LOOSELY_PACKED_PIXEL_STREAM_YCBCR20	= 0x0c,
>  	MIPI_DSI_PACKED_PIXEL_STREAM_YCBCR24		= 0x1c,

Actually, it looks like the ordering is by lowest-significant nibble
first, then by highest-significant nibble, so maybe there's some logic
to this after all.

Hmm... that's mostly true, except for 0x07 and 0x08... anyway, the new
enumeration values and names match the specification, so:

Reviewed-by: Thierry Reding <treding@nvidia.com>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c
index f237d80828c3..3f33f02571fd 100644
--- a/drivers/gpu/drm/drm_mipi_dsi.c
+++ b/drivers/gpu/drm/drm_mipi_dsi.c
@@ -388,6 +388,7 @@  bool mipi_dsi_packet_format_is_short(u8 type)
 	case MIPI_DSI_DCS_SHORT_WRITE:
 	case MIPI_DSI_DCS_SHORT_WRITE_PARAM:
 	case MIPI_DSI_DCS_READ:
+	case MIPI_DSI_EXECUTE_QUEUE:
 	case MIPI_DSI_SET_MAXIMUM_RETURN_PACKET_SIZE:
 		return true;
 	}
@@ -411,6 +412,7 @@  bool mipi_dsi_packet_format_is_long(u8 type)
 	case MIPI_DSI_GENERIC_LONG_WRITE:
 	case MIPI_DSI_DCS_LONG_WRITE:
 	case MIPI_DSI_PICTURE_PARAMETER_SET:
+	case MIPI_DSI_COMPRESSED_PIXEL_STREAM:
 	case MIPI_DSI_LOOSELY_PACKED_PIXEL_STREAM_YCBCR20:
 	case MIPI_DSI_PACKED_PIXEL_STREAM_YCBCR24:
 	case MIPI_DSI_PACKED_PIXEL_STREAM_YCBCR16:
diff --git a/include/video/mipi_display.h b/include/video/mipi_display.h
index 79fd71cf4934..6b6390dfa203 100644
--- a/include/video/mipi_display.h
+++ b/include/video/mipi_display.h
@@ -37,6 +37,7 @@  enum {
 	MIPI_DSI_DCS_SHORT_WRITE_PARAM			= 0x15,
 
 	MIPI_DSI_DCS_READ				= 0x06,
+	MIPI_DSI_EXECUTE_QUEUE				= 0x16,
 
 	MIPI_DSI_SET_MAXIMUM_RETURN_PACKET_SIZE		= 0x37,
 
@@ -46,6 +47,7 @@  enum {
 	MIPI_DSI_DCS_LONG_WRITE				= 0x39,
 
 	MIPI_DSI_PICTURE_PARAMETER_SET			= 0x0a,
+	MIPI_DSI_COMPRESSED_PIXEL_STREAM		= 0x0b,
 
 	MIPI_DSI_LOOSELY_PACKED_PIXEL_STREAM_YCBCR20	= 0x0c,
 	MIPI_DSI_PACKED_PIXEL_STREAM_YCBCR24		= 0x1c,