| Message ID | 20191023212823.608-11-pierre-louis.bossart@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | soundwire: intel: implement new ASoC interfaces | expand |
On 2019-10-23 23:28, Pierre-Louis Bossart wrote: > From: Rander Wang <rander.wang@linux.intel.com> > > It gets sdw runtime information from dai to prepare stream. > > Signed-off-by: Rander Wang <rander.wang@linux.intel.com> > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> While the patch looks good, the commit message is questionable. You may simply state why it is added only just now. Judging from the commit title, it has been added to make the sdw dai driver interface complete. Czarek
On 11/4/19 1:45 PM, Cezary Rojewski wrote: > On 2019-10-23 23:28, Pierre-Louis Bossart wrote: >> From: Rander Wang <rander.wang@linux.intel.com> >> >> It gets sdw runtime information from dai to prepare stream. >> >> Signed-off-by: Rander Wang <rander.wang@linux.intel.com> >> Signed-off-by: Pierre-Louis Bossart >> <pierre-louis.bossart@linux.intel.com> > > While the patch looks good, the commit message is questionable. You may > simply state why it is added only just now. Judging from the commit > title, it has been added to make the sdw dai driver interface complete. The commit message is not great but it's not wrong either...
On 04-11-19, 15:31, Pierre-Louis Bossart wrote: > > > On 11/4/19 1:45 PM, Cezary Rojewski wrote: > > On 2019-10-23 23:28, Pierre-Louis Bossart wrote: > > > From: Rander Wang <rander.wang@linux.intel.com> > > > > > > It gets sdw runtime information from dai to prepare stream. > > > > > > Signed-off-by: Rander Wang <rander.wang@linux.intel.com> > > > Signed-off-by: Pierre-Louis Bossart > > > <pierre-louis.bossart@linux.intel.com> > > > > While the patch looks good, the commit message is questionable. You may > > simply state why it is added only just now. Judging from the commit > > title, it has been added to make the sdw dai driver interface complete. > > The commit message is not great but it's not wrong either... And it doesn't harm to elaborate and explain things rather than have reviewer play detective!
diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c index 492684ba08c3..c50aebda7f4d 100644 --- a/drivers/soundwire/intel.c +++ b/drivers/soundwire/intel.c @@ -697,6 +697,21 @@ static int intel_hw_params(struct snd_pcm_substream *substream, return ret; } +static int intel_prepare(struct snd_pcm_substream *substream, + struct snd_soc_dai *dai) +{ + struct sdw_cdns_dma_data *dma; + + dma = snd_soc_dai_get_dma_data(dai, substream); + if (!dma) { + dev_err(dai->dev, "failed to get dma data in %s", + __func__); + return -EIO; + } + + return sdw_prepare_stream(dma->stream); +} + static int intel_hw_free(struct snd_pcm_substream *substream, struct snd_soc_dai *dai) { @@ -743,6 +758,7 @@ static int intel_pdm_set_sdw_stream(struct snd_soc_dai *dai, static const struct snd_soc_dai_ops intel_pcm_dai_ops = { .hw_params = intel_hw_params, + .prepare = intel_prepare, .hw_free = intel_hw_free, .shutdown = intel_shutdown, .set_sdw_stream = intel_pcm_set_sdw_stream, @@ -750,6 +766,7 @@ static const struct snd_soc_dai_ops intel_pcm_dai_ops = { static const struct snd_soc_dai_ops intel_pdm_dai_ops = { .hw_params = intel_hw_params, + .prepare = intel_prepare, .hw_free = intel_hw_free, .shutdown = intel_shutdown, .set_sdw_stream = intel_pdm_set_sdw_stream,