diff mbox series

[RESEND,07/14] drm/msm/hdmi: Provide ddc symlink in hdmi connector sysfs directory

Message ID 1e343b02195757bfbf60ca8999cadeb376db204e.1566845537.git.andrzej.p@collabora.com (mailing list archive)
State New, archived
Headers show
Series Next round of associating ddc adapters with connectors | expand

Commit Message

Andrzej Pietrasiewicz Aug. 26, 2019, 7:25 p.m. UTC 
Use the ddc pointer provided by the generic connector.

Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
---
 drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Sean Paul Nov. 6, 2019, 3:58 p.m. UTC | #1 
On Mon, Aug 26, 2019 at 3:27 PM Andrzej Pietrasiewicz
<andrzej.p@collabora.com> wrote:
>
> Use the ddc pointer provided by the generic connector.
>
> Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
> Acked-by: Sam Ravnborg <sam@ravnborg.org>
> Reviewed-by: Emil Velikov <emil.velikov@collabora.com>

Acked-by: Sean Paul <sean@poorly.run>

> ---
>  drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_connector.c b/drivers/gpu/drm/msm/hdmi/hdmi_connector.c
> index 07b4cb877d82..1f03262b8a52 100644
> --- a/drivers/gpu/drm/msm/hdmi/hdmi_connector.c
> +++ b/drivers/gpu/drm/msm/hdmi/hdmi_connector.c
> @@ -450,8 +450,10 @@ struct drm_connector *msm_hdmi_connector_init(struct hdmi *hdmi)
>
>         connector = &hdmi_connector->base;
>
> -       drm_connector_init(hdmi->dev, connector, &hdmi_connector_funcs,
> -                       DRM_MODE_CONNECTOR_HDMIA);
> +       drm_connector_init_with_ddc(hdmi->dev, connector,
> +                                   &hdmi_connector_funcs,
> +                                   DRM_MODE_CONNECTOR_HDMIA,
> +                                   hdmi->i2c);
>         drm_connector_helper_add(connector, &msm_hdmi_connector_helper_funcs);
>
>         connector->polled = DRM_CONNECTOR_POLL_CONNECT |
> --
> 2.17.1
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_connector.c b/drivers/gpu/drm/msm/hdmi/hdmi_connector.c
index 07b4cb877d82..1f03262b8a52 100644
--- a/drivers/gpu/drm/msm/hdmi/hdmi_connector.c
+++ b/drivers/gpu/drm/msm/hdmi/hdmi_connector.c
@@ -450,8 +450,10 @@  struct drm_connector *msm_hdmi_connector_init(struct hdmi *hdmi)
 
 	connector = &hdmi_connector->base;
 
-	drm_connector_init(hdmi->dev, connector, &hdmi_connector_funcs,
-			DRM_MODE_CONNECTOR_HDMIA);
+	drm_connector_init_with_ddc(hdmi->dev, connector,
+				    &hdmi_connector_funcs,
+				    DRM_MODE_CONNECTOR_HDMIA,
+				    hdmi->i2c);
 	drm_connector_helper_add(connector, &msm_hdmi_connector_helper_funcs);
 
 	connector->polled = DRM_CONNECTOR_POLL_CONNECT |