[v3,0/3] Inline sqe_submit

Message

Pavel Begunkov Nov. 6, 2019, 10:41 p.m. UTC

The idea is to not pass struct sqe_submit as a separate entity,
but always use req->submit instead, so there will be less stuff to
care about.

Also, I've got steady +1% throughput improvement for nop tests.
Though, it's highly system-dependent, and I wouldn't count on it.

v2: fix use-after-free catched by Jens

v3: -EAGAIN, in case submission failed

Pavel Begunkov (3):
  io_uring: allocate io_kiocb upfront
  io_uring: Use submit info inlined into req
  io_uring: use inlined struct sqe_submit

 fs/io_uring.c | 134 +++++++++++++++++++++++++-------------------------
 1 file changed, 67 insertions(+), 67 deletions(-)

Comments

Jens Axboe Nov. 6, 2019, 10:47 p.m. UTC | #1

On 11/6/19 3:41 PM, Pavel Begunkov wrote:
> The idea is to not pass struct sqe_submit as a separate entity,
> but always use req->submit instead, so there will be less stuff to
> care about.
> 
> Also, I've got steady +1% throughput improvement for nop tests.
> Though, it's highly system-dependent, and I wouldn't count on it.
> 
> v2: fix use-after-free catched by Jens
> 
> v3: -EAGAIN, in case submission failed
> 
> Pavel Begunkov (3):
>    io_uring: allocate io_kiocb upfront
>    io_uring: Use submit info inlined into req
>    io_uring: use inlined struct sqe_submit
> 
>   fs/io_uring.c | 134 +++++++++++++++++++++++++-------------------------
>   1 file changed, 67 insertions(+), 67 deletions(-)

This looks good to me now, thanks! Applied.