| Message ID | fcd51b067bafa571b3d9879a3afc31e8c764100d.1573029228.git.matti.vaittinen@fi.rohmeurope.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add definition for GPIO direction | expand |
On Wed, Nov 6, 2019 at 9:51 AM Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> wrote: > At least for me it is difficult to remember the meaning of GPIO > direction values. Define GPIO_LINE_DIRECTION_IN and > GPIO_LINE_DIRECTION_OUT so that occasional GPIO contributors would > not need to always check the meaning of hard coded values 1 and 0. > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> Patch applied. Yours, Linus Walleij
diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h index 5dd9c982e2cb..cc9ade4552d9 100644 --- a/include/linux/gpio/driver.h +++ b/include/linux/gpio/driver.h @@ -22,6 +22,9 @@ enum gpio_lookup_flags; struct gpio_chip; +#define GPIO_LINE_DIRECTION_IN 1 +#define GPIO_LINE_DIRECTION_OUT 0 + /** * struct gpio_irq_chip - GPIO interrupt controller */
At least for me it is difficult to remember the meaning of GPIO direction values. Define GPIO_LINE_DIRECTION_IN and GPIO_LINE_DIRECTION_OUT so that occasional GPIO contributors would not need to always check the meaning of hard coded values 1 and 0. Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> --- Changes from v1: No changes. include/linux/gpio/driver.h | 3 +++ 1 file changed, 3 insertions(+)