| Message ID | 20191106093239.25517-6-rrichter@marvell.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | EDAC: Rework edac_mc and ghes drivers | expand |
Em Wed, 6 Nov 2019 09:33:11 +0000 Robert Richter <rrichter@marvell.com> escreveu: > Since this is a string already and strlen() has been used to advance > the pointer, the end of the buffer is already zero terminated. Remove > the needless zero string termination. > > Suggested-by: Joe Perches <joe@perches.com> > Signed-off-by: Robert Richter <rrichter@marvell.com> Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org> > --- > drivers/edac/edac_mc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/edac/edac_mc.c b/drivers/edac/edac_mc.c > index f2cbca77bc50..8bfe76d1bdf1 100644 > --- a/drivers/edac/edac_mc.c > +++ b/drivers/edac/edac_mc.c > @@ -1183,7 +1183,6 @@ void edac_mc_handle_error(const enum hw_event_mc_err_type type, > } > strcpy(p, dimm->label); > p += strlen(p); > - *p = '\0'; > > /* > * get csrow/channel of the DIMM, in order to allow Cheers, Mauro
On Wed, Nov 06, 2019 at 09:33:11AM +0000, Robert Richter wrote: > Since this is a string already and strlen() has been used to advance > the pointer, the end of the buffer is already zero terminated. Remove > the needless zero string termination. Changed that to: "The e string to which this is pointing to has already been cleared earlier in the function so remove the needless zero string termination."
diff --git a/drivers/edac/edac_mc.c b/drivers/edac/edac_mc.c index f2cbca77bc50..8bfe76d1bdf1 100644 --- a/drivers/edac/edac_mc.c +++ b/drivers/edac/edac_mc.c @@ -1183,7 +1183,6 @@ void edac_mc_handle_error(const enum hw_event_mc_err_type type, } strcpy(p, dimm->label); p += strlen(p); - *p = '\0'; /* * get csrow/channel of the DIMM, in order to allow
Since this is a string already and strlen() has been used to advance the pointer, the end of the buffer is already zero terminated. Remove the needless zero string termination. Suggested-by: Joe Perches <joe@perches.com> Signed-off-by: Robert Richter <rrichter@marvell.com> --- drivers/edac/edac_mc.c | 1 - 1 file changed, 1 deletion(-)