| Message ID | e7098a35e93f329a3044f16724a4eb504545ad61.1572556786.git.leonard.crestez@nxp.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [v10,01/11] PM / devfreq: Fix devfreq_notifier_call returning errno | expand |
On 11/1/19 6:34 AM, Leonard Crestez wrote: > The devfreq_notifier_call functions will update scaling_min_freq and > scaling_max_freq when the OPP table is updated. > > If fetching the maximum frequency fails then scaling_max_freq remains > set to zero which is confusing. Set to ULONG_MAX instead so we don't > need special handling for this case in other places. > > Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com> > Reviewed-by: Matthias Kaehlcke <mka@chromium.org> > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> > --- > drivers/devfreq/devfreq.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c > index b65faa1a2baa..715127f1cda5 100644 > --- a/drivers/devfreq/devfreq.c > +++ b/drivers/devfreq/devfreq.c > @@ -557,12 +557,14 @@ static int devfreq_notifier_call(struct notifier_block *nb, unsigned long type, > devfreq->scaling_min_freq = find_available_min_freq(devfreq); > if (!devfreq->scaling_min_freq) > goto out; > > devfreq->scaling_max_freq = find_available_max_freq(devfreq); > - if (!devfreq->scaling_max_freq) > + if (!devfreq->scaling_max_freq) { > + devfreq->scaling_max_freq = ULONG_MAX; > goto out; > + } > > err = update_devfreq(devfreq); > > out: > mutex_unlock(&devfreq->lock); > Applied it because it doesn't depend on the pm_qos feature.
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index b65faa1a2baa..715127f1cda5 100644 --- a/drivers/devfreq/devfreq.c +++ b/drivers/devfreq/devfreq.c @@ -557,12 +557,14 @@ static int devfreq_notifier_call(struct notifier_block *nb, unsigned long type, devfreq->scaling_min_freq = find_available_min_freq(devfreq); if (!devfreq->scaling_min_freq) goto out; devfreq->scaling_max_freq = find_available_max_freq(devfreq); - if (!devfreq->scaling_max_freq) + if (!devfreq->scaling_max_freq) { + devfreq->scaling_max_freq = ULONG_MAX; goto out; + } err = update_devfreq(devfreq); out: mutex_unlock(&devfreq->lock);