| Message ID | 20191105222652.70226-9-gwendal@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | cros_ec: Add sensorhub driver and FIFO processing | expand |
Hi, cc'in Dmitry and linux-input list which is missing On 5/11/19 23:26, Gwendal Grignou wrote: > This reverts commit d096aa3eb6045a6a475a0239f3471c59eedf3d61. > > This patch is not needed anymore since we clear EC_MKBP_HAS_MORE_EVENTS > flag before calling the notifiers in patch > "9d9518f5b52a (platform: chrome: cros_ec: handle MKBP more events flag)" > > Signed-off-by: Gwendal Grignou <gwendal@chromium.org> > --- > No changes in v4, v3. > New to v2. > > drivers/input/keyboard/cros_ec_keyb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c > index a29e81fdf186..2b71c5a51f90 100644 > --- a/drivers/input/keyboard/cros_ec_keyb.c > +++ b/drivers/input/keyboard/cros_ec_keyb.c > @@ -237,7 +237,7 @@ static int cros_ec_keyb_work(struct notifier_block *nb, > if (queued_during_suspend && !device_may_wakeup(ckdev->dev)) > return NOTIFY_OK; > > - switch (ckdev->ec->event_data.event_type & EC_MKBP_EVENT_TYPE_MASK) { > + switch (ckdev->ec->event_data.event_type) { > case EC_MKBP_EVENT_KEY_MATRIX: > pm_wakeup_event(ckdev->dev, 0); > >
On Mon, Nov 11, 2019 at 10:20:41AM +0100, Enric Balletbo i Serra wrote: > Hi, > > cc'in Dmitry and linux-input list which is missing Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > On 5/11/19 23:26, Gwendal Grignou wrote: > > This reverts commit d096aa3eb6045a6a475a0239f3471c59eedf3d61. > > > > This patch is not needed anymore since we clear EC_MKBP_HAS_MORE_EVENTS > > flag before calling the notifiers in patch > > "9d9518f5b52a (platform: chrome: cros_ec: handle MKBP more events flag)" > > > > Signed-off-by: Gwendal Grignou <gwendal@chromium.org> > > --- > > No changes in v4, v3. > > New to v2. > > > > drivers/input/keyboard/cros_ec_keyb.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c > > index a29e81fdf186..2b71c5a51f90 100644 > > --- a/drivers/input/keyboard/cros_ec_keyb.c > > +++ b/drivers/input/keyboard/cros_ec_keyb.c > > @@ -237,7 +237,7 @@ static int cros_ec_keyb_work(struct notifier_block *nb, > > if (queued_during_suspend && !device_may_wakeup(ckdev->dev)) > > return NOTIFY_OK; > > > > - switch (ckdev->ec->event_data.event_type & EC_MKBP_EVENT_TYPE_MASK) { > > + switch (ckdev->ec->event_data.event_type) { > > case EC_MKBP_EVENT_KEY_MATRIX: > > pm_wakeup_event(ckdev->dev, 0); > > > >
diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c index a29e81fdf186..2b71c5a51f90 100644 --- a/drivers/input/keyboard/cros_ec_keyb.c +++ b/drivers/input/keyboard/cros_ec_keyb.c @@ -237,7 +237,7 @@ static int cros_ec_keyb_work(struct notifier_block *nb, if (queued_during_suspend && !device_may_wakeup(ckdev->dev)) return NOTIFY_OK; - switch (ckdev->ec->event_data.event_type & EC_MKBP_EVENT_TYPE_MASK) { + switch (ckdev->ec->event_data.event_type) { case EC_MKBP_EVENT_KEY_MATRIX: pm_wakeup_event(ckdev->dev, 0);
This reverts commit d096aa3eb6045a6a475a0239f3471c59eedf3d61. This patch is not needed anymore since we clear EC_MKBP_HAS_MORE_EVENTS flag before calling the notifiers in patch "9d9518f5b52a (platform: chrome: cros_ec: handle MKBP more events flag)" Signed-off-by: Gwendal Grignou <gwendal@chromium.org> --- No changes in v4, v3. New to v2. drivers/input/keyboard/cros_ec_keyb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)