mbox series

[00/11] USB: serial: mos7840: type detection and clean ups

Message ID 20191107132904.2379-1-johan@kernel.org (mailing list archive)
Headers show
Series USB: serial: mos7840: type detection and clean ups | expand

Message

Johan Hovold Nov. 7, 2019, 1:28 p.m. UTC 
The mos7840 device-type detection is fragile and cannot generally be
relied upon (e.g. as recently reported for Moxa UPort 2210 which was
detected as a four-port device).

The first couple of patches adds support for encoding known chip
features in the device-id table, and documents the underlying
assumptions for the mcs7810-detection hack.

Turns out we have a lot of legacy cruft in this driver, and the
remaining patches rips that out.

Johan


Johan Hovold (11):
  USB: serial: mos7840: clean up device-type handling
  USB: serial: mos7840: document MCS7810 detection hack
  USB: serial: mos7840: fix probe error handling
  USB: serial: mos7840: rip out broken interrupt handling
  USB: serial: mos7840: drop redundant urb context check
  USB: serial: mos7840: drop paranoid port checks
  USB: serial: mos7840: drop paranoid serial checks
  USB: serial: mos7840: drop serial struct accessor
  USB: serial: mos7840: drop port driver data accessors
  USB: serial: mos7840: drop read-urb check
  USB: serial: mos7840: drop port open flag

 drivers/usb/serial/mos7840.c | 770 +++++------------------------------
 1 file changed, 102 insertions(+), 668 deletions(-)

Comments

Greg KH Nov. 11, 2019, 1:27 p.m. UTC | #1 
On Thu, Nov 07, 2019 at 02:28:53PM +0100, Johan Hovold wrote:
> The mos7840 device-type detection is fragile and cannot generally be
> relied upon (e.g. as recently reported for Moxa UPort 2210 which was
> detected as a four-port device).
> 
> The first couple of patches adds support for encoding known chip
> features in the device-id table, and documents the underlying
> assumptions for the mcs7810-detection hack.
> 
> Turns out we have a lot of legacy cruft in this driver, and the
> remaining patches rips that out.
> 
> Johan
> 
> 
> Johan Hovold (11):
>   USB: serial: mos7840: clean up device-type handling
>   USB: serial: mos7840: document MCS7810 detection hack
>   USB: serial: mos7840: fix probe error handling
>   USB: serial: mos7840: rip out broken interrupt handling
>   USB: serial: mos7840: drop redundant urb context check
>   USB: serial: mos7840: drop paranoid port checks
>   USB: serial: mos7840: drop paranoid serial checks
>   USB: serial: mos7840: drop serial struct accessor
>   USB: serial: mos7840: drop port driver data accessors
>   USB: serial: mos7840: drop read-urb check
>   USB: serial: mos7840: drop port open flag
> 
>  drivers/usb/serial/mos7840.c | 770 +++++------------------------------
>  1 file changed, 102 insertions(+), 668 deletions(-)

Nice cleanups:

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Hovold Nov. 12, 2019, 9:21 a.m. UTC | #2 
On Mon, Nov 11, 2019 at 02:27:46PM +0100, Greg Kroah-Hartman wrote:
> On Thu, Nov 07, 2019 at 02:28:53PM +0100, Johan Hovold wrote:

> > Johan Hovold (11):
> >   USB: serial: mos7840: clean up device-type handling
> >   USB: serial: mos7840: document MCS7810 detection hack
> >   USB: serial: mos7840: fix probe error handling
> >   USB: serial: mos7840: rip out broken interrupt handling
> >   USB: serial: mos7840: drop redundant urb context check
> >   USB: serial: mos7840: drop paranoid port checks
> >   USB: serial: mos7840: drop paranoid serial checks
> >   USB: serial: mos7840: drop serial struct accessor
> >   USB: serial: mos7840: drop port driver data accessors
> >   USB: serial: mos7840: drop read-urb check
> >   USB: serial: mos7840: drop port open flag
> > 
> >  drivers/usb/serial/mos7840.c | 770 +++++------------------------------
> >  1 file changed, 102 insertions(+), 668 deletions(-)
> 
> Nice cleanups:
> 
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Thanks for the review. All now applied.

Johan