| Message ID | 20191027105243.34339-1-like.xu@linux.intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | KVM: x86/vPMU: Efficiency optimization by reusing last created perf_event | expand |
On Sun, Oct 27, 2019 at 06:52:37PM +0800, Like Xu wrote: > For perf subsystem, please help review first two patches. > Like Xu (6): > perf/core: Provide a kernel-internal interface to recalibrate event > period > perf/core: Provide a kernel-internal interface to pause perf_event Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Hi Paolo, On 2019/10/29 0:43, Peter Zijlstra wrote: > On Sun, Oct 27, 2019 at 06:52:37PM +0800, Like Xu wrote: >> For perf subsystem, please help review first two patches. > >> Like Xu (6): >> perf/core: Provide a kernel-internal interface to recalibrate event >> period >> perf/core: Provide a kernel-internal interface to pause perf_event > > Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org> > Would you mind to revisit the following patches for upstream ? > KVM: x86/vPMU: Rename pmu_ops callbacks from msr_idx to rdpmc_ecx > KVM: x86/vPMU: Introduce a new kvm_pmu_ops->msr_idx_to_pmc callback > KVM: x86/vPMU: Reuse perf_event to avoid unnecessary > pmc_reprogram_counter > KVM: x86/vPMU: Add lazy mechanism to release perf_event per vPMC For vPMU, please review two more patches as well: + https://lore.kernel.org/kvm/20191030164418.2957-1-like.xu@linux.intel.com/ (kvm) + https://lore.kernel.org/lkml/20191105140955.22504-1-like.xu@linux.intel.com/ (perf) Thanks, Like Xu
On 12/11/19 07:08, Like Xu wrote: > Hi Paolo, > > On 2019/10/29 0:43, Peter Zijlstra wrote: >> On Sun, Oct 27, 2019 at 06:52:37PM +0800, Like Xu wrote: >>> For perf subsystem, please help review first two patches. >> >>> Like Xu (6): >>> perf/core: Provide a kernel-internal interface to recalibrate event >>> period >>> perf/core: Provide a kernel-internal interface to pause perf_event >> >> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org> >> > > Would you mind to revisit the following patches for upstream ? > >> KVM: x86/vPMU: Rename pmu_ops callbacks from msr_idx to rdpmc_ecx >> KVM: x86/vPMU: Introduce a new kvm_pmu_ops->msr_idx_to_pmc callback >> KVM: x86/vPMU: Reuse perf_event to avoid unnecessary >> pmc_reprogram_counter >> KVM: x86/vPMU: Add lazy mechanism to release perf_event per vPMC Queued, thanks. Paolo > For vPMU, please review two more patches as well: > + > https://lore.kernel.org/kvm/20191030164418.2957-1-like.xu@linux.intel.com/ > (kvm) > + > https://lore.kernel.org/lkml/20191105140955.22504-1-like.xu@linux.intel.com/ > (perf) > > Thanks, > Like Xu >
On 12/11/19 07:08, Like Xu wrote: > > For vPMU, please review two more patches as well: > + > https://lore.kernel.org/kvm/20191030164418.2957-1-like.xu@linux.intel.com/ > (kvm) If I understand this patch correctly, you are patching the CPUID values passed to the KVM_SET_CPUID2 ioctl if they are not valid for the host. Generally we don't do that, if there is garbage in CPUID the behavior of the guest will be unreliable. Paolo
Hi Community, For perf subsystem, please help review first two patches. For kvm subsystem, please help review last four patches. This patch series is going to improve vPMU Efficiency for guest which is mainly measured by guest NMI handler latency in such as basic perf usages [1][2] with hardware PMU. It's not a passthrough solution but based on the legacy vPMU implementation. With this optimization, the average latency of the guest NMI handler is reduced from 104923 ns to 48393 ns (~2.16x speed up on CLX-AP with 5.4-rc4, w/ perf_v4_pmi=n). If host disables the watchdog, the minimum latency of guest NMI handler could be speed up at ~3413x and in the average at ~786x. The run time of workload with perf attached inside the guest could be reduced significantly with this optimization. The general idea (defined in patch 5/6) is to reuse last created event for the same vPMC when the new requested config is the exactly same as the current_config (used by last pmc_reprogram_counter()) AND the new event period is appropriate and accepted (via perf_event_period() in patch 1/6). Before reusing the perf_event, it will be disabled until it's suitable for reuse and a hardware counter will be reassigned again to serve vPMC. If the disabled perf_event is no longer reused, we do a lazy release mechanism (defined in patch 6/6) which in a short is to release the disabled perf_events in the call of kvm_pmu_handle_event since the vcpu gets next scheduled in if guest doesn't WRMSR its MSRs in the last sched time slice. In the kvm_arch_sched_in(), KVM_REQ_PMU is requested if the pmu->event_count has not been reduced to zero and then do kvm_pmu_cleanup only once for a sched time slice to ensure that overhead is very limited. Please check each commit for more details and share your comments with us. Thanks, Like Xu --- [1] multiplexing sampling mode usage: perf record -e \ `perf list | grep Hardware | grep event |\ awk '{print $1}' | head -n 10 |tr '\n' ',' | sed 's/,$//' ` ./ftest [2] single event count mode usage: perf stat -e branch-misses ./ftest --- Changes in v4: - s/rdpmc_idx/rdpmc_ecx/g (Jim Mattson) - make *_msr_idx_to_pmc static (kbuild test robot) Changes in v3: - optimize perf_event_pause() for no child event - rename programed_config to programed_config - rename lazy_release_ctrl to pmc_in_use - rename kvm_pmu_ops callbacks form msr_idx to rdpmc_idx - add a new kvm_pmu_ops callback msr_idx_to_pmc - use DECLARE_BITMAP to declare bitmap - set up a bitmap 'pmu->all_valid_pmc_idx' - move kvm_pmu_cleanup to kvm_pmu_handle_event - update performance data based on 5.4-rc4 on CLX-AP Changes in v2: - use perf_event_pause() to disable, read, reset by only one lock; - use __perf_event_read_value() after _perf_event_disable(); - replace bitfields with 'u8 event_count; bool need_cleanup;'; - refine comments and commit messages; - fix two issues reported by kbuild test robot for ARCH=[nds32|sh] v3: https://lore.kernel.org/kvm/20191021160651.49508-1-like.xu@linux.intel.com/ v2: https://lore.kernel.org/kvm/20191013091533.12971-1-like.xu@linux.intel.com/ v1: https://lore.kernel.org/kvm/20190930072257.43352-1-like.xu@linux.intel.com/ Like Xu (6): perf/core: Provide a kernel-internal interface to recalibrate event period perf/core: Provide a kernel-internal interface to pause perf_event KVM: x86/vPMU: Rename pmu_ops callbacks from msr_idx to rdpmc_ecx KVM: x86/vPMU: Introduce a new kvm_pmu_ops->msr_idx_to_pmc callback KVM: x86/vPMU: Reuse perf_event to avoid unnecessary pmc_reprogram_counter KVM: x86/vPMU: Add lazy mechanism to release perf_event per vPMC arch/x86/include/asm/kvm_host.h | 19 ++++++ arch/x86/kvm/pmu.c | 112 ++++++++++++++++++++++++++++++-- arch/x86/kvm/pmu.h | 23 +++++-- arch/x86/kvm/pmu_amd.c | 24 +++++-- arch/x86/kvm/vmx/pmu_intel.c | 29 +++++++-- arch/x86/kvm/x86.c | 8 ++- include/linux/perf_event.h | 10 +++ kernel/events/core.c | 46 +++++++++++-- 8 files changed, 240 insertions(+), 31 deletions(-)