[0/4] arm/aspeed: Watchdog and SDRAM fixes

Message

Joel Stanley Nov. 12, 2019, 6:40 a.m. UTC

Three of these are fixes for ast2600 models that I found when testing
master. The forth is a usability improvement that is helpful when
diagnosing why a watchdog is biting.

Joel Stanley (4):
  aspeed/sdmc: Make ast2600 default 1G
  aspeed/scu: Fix W1C behavior
  watchdog/aspeed: Improve watchdog timeout message
  watchdog/aspeed: Fix AST2600 frequency behaviour

 hw/misc/aspeed_scu.c             | 11 ++++++++---
 hw/misc/aspeed_sdmc.c            |  6 +++---
 hw/watchdog/wdt_aspeed.c         | 24 +++++++++++++++++++-----
 include/hw/watchdog/wdt_aspeed.h |  1 +
 4 files changed, 31 insertions(+), 11 deletions(-)

Comments

[e-mail] Nov. 12, 2019, 3:05 p.m. UTC | #1

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series failed the docker-mingw@fedora build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#! /bin/bash
export ARCH=x86_64
make docker-image-fedora V=1 NETWORK=1
time make docker-test-mingw@fedora J=14 NETWORK=1
=== TEST SCRIPT END ===

  CC      qga/guest-agent-command-state.o
In file included from /tmp/qemu-test/src/hw/watchdog/wdt_aspeed.c:13:
/tmp/qemu-test/src/hw/watchdog/wdt_aspeed.c: In function 'aspeed_wdt_timer_expired':
/tmp/qemu-test/src/hw/watchdog/wdt_aspeed.c:232:34: error: format '%lx' expects argument of type 'long unsigned int', but argument 2 has type 'hwaddr' {aka 'long long unsigned int'} [-Werror=format=]
     qemu_log_mask(CPU_LOG_RESET, "Watchdog timer %08lx expired.\n",
                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             s->iomem.addr);
---
                      ^~~
cc1: all warnings being treated as errors
  BUILD   pc-bios/optionrom/multiboot.img
make: *** [/tmp/qemu-test/src/rules.mak:69: hw/watchdog/wdt_aspeed.o] Error 1
make: *** Waiting for unfinished jobs....
  CC      qga/main.o
  BUILD   pc-bios/optionrom/linuxboot.img
---
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=f52d432b2dd64b048a6f416466c0033d', '-u', '1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-k6_g3bqv/src/docker-src.2019-11-12-10.02.49.13016:/var/tmp/qemu:z,ro', 'qemu:fedora', '/var/tmp/qemu/run', 'test-mingw']' returned non-zero exit status 2.
filter=--filter=label=com.qemu.instance.uuid=f52d432b2dd64b048a6f416466c0033d
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-k6_g3bqv/src'
make: *** [docker-run-test-mingw@fedora] Error 2

real    2m42.914s
user    0m7.862s


The full log is available at
http://patchew.org/logs/[e-mail]/testing.docker-mingw@fedora/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [e-mail]