| Message ID | 20191105114402.6009-1-l.stach@pengutronix.de (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 549766ac2ac1f6c8bb85906bbcea759541bb19a2 |
| Headers | show |
| Series | Input: synaptics-rmi4 - clear IRQ enables for F54 | expand |
On Tue, Nov 05, 2019 at 12:44:02PM +0100, Lucas Stach wrote: > The driver for F54 just polls the status and doesn't even have a IRQ > handler registered. Make sure to disable all F54 IRQs, so we don't crash > the kernel on a nonexistent handler. > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> Applied, thank you. > --- > drivers/input/rmi4/rmi_f54.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/rmi4/rmi_f54.c b/drivers/input/rmi4/rmi_f54.c > index 710b02595486..7e6243ecaf32 100644 > --- a/drivers/input/rmi4/rmi_f54.c > +++ b/drivers/input/rmi4/rmi_f54.c > @@ -601,7 +601,7 @@ static int rmi_f54_config(struct rmi_function *fn) > { > struct rmi_driver *drv = fn->rmi_dev->driver; > > - drv->set_irq_bits(fn->rmi_dev, fn->irq_mask); > + drv->clear_irq_bits(fn->rmi_dev, fn->irq_mask); > > return 0; > } > -- > 2.20.1 >
diff --git a/drivers/input/rmi4/rmi_f54.c b/drivers/input/rmi4/rmi_f54.c index 710b02595486..7e6243ecaf32 100644 --- a/drivers/input/rmi4/rmi_f54.c +++ b/drivers/input/rmi4/rmi_f54.c @@ -601,7 +601,7 @@ static int rmi_f54_config(struct rmi_function *fn) { struct rmi_driver *drv = fn->rmi_dev->driver; - drv->set_irq_bits(fn->rmi_dev, fn->irq_mask); + drv->clear_irq_bits(fn->rmi_dev, fn->irq_mask); return 0; }
The driver for F54 just polls the status and doesn't even have a IRQ handler registered. Make sure to disable all F54 IRQs, so we don't crash the kernel on a nonexistent handler. Signed-off-by: Lucas Stach <l.stach@pengutronix.de> --- drivers/input/rmi4/rmi_f54.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)