| Message ID | 17b12e91c878dcb74160e3df5f88bc8a9e3f7fce.1573122644.git.hns@goldelico.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | OpenPandora: make wl1251 connected to mmc3 sdio port of OpenPandora work again | expand |
On Thu, 7 Nov 2019 11:30:34 +0100, "H. Nikolaus Schaller" wrote: > The standard method for sdio devices connected to > an sdio interface is to define them as a child node > like we can see with wlcore. > > Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> > Acked-by: Kalle Valo <kvalo@codeaurora.org> > --- > .../bindings/net/wireless/ti,wl1251.txt | 26 +++++++++++++++++++ > 1 file changed, 26 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org>
On Thu, 7 Nov 2019 at 11:32, H. Nikolaus Schaller <hns@goldelico.com> wrote: > > The standard method for sdio devices connected to > an sdio interface is to define them as a child node > like we can see with wlcore. > > Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> > Acked-by: Kalle Valo <kvalo@codeaurora.org> > --- > .../bindings/net/wireless/ti,wl1251.txt | 26 +++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt b/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt > index bb2fcde6f7ff..f38950560982 100644 > --- a/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt > +++ b/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt > @@ -35,3 +35,29 @@ Examples: > ti,power-gpio = <&gpio3 23 GPIO_ACTIVE_HIGH>; /* 87 */ > }; > }; > + > +&mmc3 { > + vmmc-supply = <&wlan_en>; > + > + bus-width = <4>; > + non-removable; > + ti,non-removable; > + cap-power-off-card; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&mmc3_pins>; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + wlan: wifi@1 { > + compatible = "ti,wl1251"; > + > + reg = <1>; > + > + interrupt-parent = <&gpio1>; > + interrupts = <21 IRQ_TYPE_LEVEL_HIGH>; /* GPIO_21 */ > + > + ti,wl1251-has-eeprom; > + }; > +}; One minor thing, the "ti,power-gpio" is not required anymore, as it's not needed for the SDIO case for pandora. Please move it to an option section. Kind regards Uffe
diff --git a/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt b/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt index bb2fcde6f7ff..f38950560982 100644 --- a/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt +++ b/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt @@ -35,3 +35,29 @@ Examples: ti,power-gpio = <&gpio3 23 GPIO_ACTIVE_HIGH>; /* 87 */ }; }; + +&mmc3 { + vmmc-supply = <&wlan_en>; + + bus-width = <4>; + non-removable; + ti,non-removable; + cap-power-off-card; + + pinctrl-names = "default"; + pinctrl-0 = <&mmc3_pins>; + + #address-cells = <1>; + #size-cells = <0>; + + wlan: wifi@1 { + compatible = "ti,wl1251"; + + reg = <1>; + + interrupt-parent = <&gpio1>; + interrupts = <21 IRQ_TYPE_LEVEL_HIGH>; /* GPIO_21 */ + + ti,wl1251-has-eeprom; + }; +};