| Message ID | 20191106225527.9121-1-mihailescu2m@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [v4,1/2] dt-bindings: gpu: mali-midgard: add samsung exynos 5420 compatible | expand |
On Thu, Nov 07, 2019 at 09:25:26AM +1030, Marian Mihailescu wrote: > Add "samsung,exynos5420-mali" binding > > Signed-off-by: Marian Mihailescu <mihailescu2m@gmail.com> > --- > Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml > index 47bc1ac36426..41b928bce4ea 100644 > --- a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml > @@ -38,9 +38,12 @@ properties: > - enum: > - samsung,exynos5433-mali > - const: arm,mali-t760 > + - items: > + - enum: > + - samsung,exynos5420-mali > + - const: arm,mali-t628 I would prefer to order it logically/alphabetically, so after 5250 and before 5433. With that change: Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof
On Thu, 7 Nov 2019 09:25:26 +1030, Marian Mihailescu wrote: > Add "samsung,exynos5420-mali" binding > > Signed-off-by: Marian Mihailescu <mihailescu2m@gmail.com> > --- > Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > Applied, thanks. Rob
On Thu, Nov 7, 2019 at 3:17 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On Thu, Nov 07, 2019 at 09:25:26AM +1030, Marian Mihailescu wrote: > > Add "samsung,exynos5420-mali" binding > > > > Signed-off-by: Marian Mihailescu <mihailescu2m@gmail.com> > > --- > > Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml > > index 47bc1ac36426..41b928bce4ea 100644 > > --- a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml > > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml > > @@ -38,9 +38,12 @@ properties: > > - enum: > > - samsung,exynos5433-mali > > - const: arm,mali-t760 > > + - items: > > + - enum: > > + - samsung,exynos5420-mali > > + - const: arm,mali-t628 > > I would prefer to order it logically/alphabetically, so after 5250 and > before 5433. With that change: I didn't see your comment, but that's what I did. This has been re-ordered to be sorted by Mali part numbers (though partially to avoid a conflict). Good thing Arm and Samsung agree newer/better/faster should be higher numbers. :) Rob
> > > > I would prefer to order it logically/alphabetically, so after 5250 and > > before 5433. With that change: > > I didn't see your comment, but that's what I did. This has been > re-ordered to be sorted by Mali part numbers (though partially to > avoid a conflict). Good thing Arm and Samsung agree > newer/better/faster should be higher numbers. :) > > Rob Thank you. -Marian
diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml index 47bc1ac36426..41b928bce4ea 100644 --- a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml +++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml @@ -38,9 +38,12 @@ properties: - enum: - samsung,exynos5433-mali - const: arm,mali-t760 + - items: + - enum: + - samsung,exynos5420-mali + - const: arm,mali-t628 # "arm,mali-t624" - # "arm,mali-t628" # "arm,mali-t830" # "arm,mali-t880"
Add "samsung,exynos5420-mali" binding Signed-off-by: Marian Mihailescu <mihailescu2m@gmail.com> --- Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)