| Message ID | 20191114190844.42484-1-jacobraz@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ASoC: rt5645: Fixed typo for buddy jack support. | expand |
On Thu, Nov 14, 2019 at 12:08:44PM -0700, Jacob Rasmussen wrote: > Had a typo in e7cfd867fd98 that resulted in buddy jack support not being > fixed. > > Fixes: e7cfd867fd98 ("ASoC: rt5645: Fixed buddy jack support.") > Cc: <zwisler@google.com> > Cc: <jacobraz@google.com> > CC: stable@vger.kernel.org Need to add your signed-off-by. With that added you can add: Reviewed-by: Ross Zwisler <zwisler@google.com>
On Thu, Nov 14, 2019 at 03:43:32PM -0700, Jacob Rasmussen wrote: > On Thu, Nov 14, 2019 at 2:43 PM Ross Zwisler <zwisler@google.com> wrote: > > On Thu, Nov 14, 2019 at 12:08:44PM -0700, Jacob Rasmussen wrote: > > > Had a typo in e7cfd867fd98 that resulted in buddy jack support not being > > > fixed. > > > Fixes: e7cfd867fd98 ("ASoC: rt5645: Fixed buddy jack support.") > > > Cc: <zwisler@google.com> > > > Cc: <jacobraz@google.com> > > > CC: stable@vger.kernel.org > > Need to add your signed-off-by. With that added you can add: > > Reviewed-by: Ross Zwisler <zwisler@google.com> > Signed-off-by: Jacob Rasmussen <jacobraz@google.com> I'd be more comfortable with this if you could repost with the signoff and the patch in one mail.
diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index 902ac98a3fbe..19662ee330d6 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -3271,7 +3271,7 @@ static void rt5645_jack_detect_work(struct work_struct *work) report, SND_JACK_MICROPHONE); return; case 4: - val = snd_soc_component_read32(rt5645->component, RT5645_A_JD_CTRL1) & 0x002; + val = snd_soc_component_read32(rt5645->component, RT5645_A_JD_CTRL1) & 0x0020; break; default: /* read rt5645 jd1_1 status */ val = snd_soc_component_read32(rt5645->component, RT5645_INT_IRQ_ST) & 0x1000;
Had a typo in e7cfd867fd98 that resulted in buddy jack support not being fixed. Fixes: e7cfd867fd98 ("ASoC: rt5645: Fixed buddy jack support.") Cc: <zwisler@google.com> Cc: <jacobraz@google.com> CC: stable@vger.kernel.org --- sound/soc/codecs/rt5645.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)