Message ID | 603fd9f6b118b05c68858a9bf93c65d98b7efd9c.1573771485.git.rosbrookn@ainfosec.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | golang/xenlight: add missing arguments to libxl_domain_shutdown/reboot | expand |
On 11/14/19 10:44 PM, Nick Rosbrook wrote: > From: Nick Rosbrook <rosbrookn@ainfosec.com> > > These functions now have a third parameter of type const *libxl_asyncop_how. > > Pass nil for this argument to fix compilation and maintain the > synchronous behavior. > > Signed-off-by: Nick Rosbrook <rosbrookn@ainfosec.com> Actually this has already been submitted and Release-acked here: https://patchew.org/Xen/20191023162358.7222-1-george.dunlap@citrix.com/ It was just done during a commit moratorium, and then forgotten afterwards. I'll check it in now. -George
> Actually this has already been submitted and Release-acked here: > > https://patchew.org/Xen/20191023162358.7222-1-george.dunlap@citrix.com/ Ah thanks, I remember seeing that now but I confused it with the *very* similar patch for libxl_domain_pause/unpause. -NR
diff --git a/tools/golang/xenlight/xenlight.go b/tools/golang/xenlight/xenlight.go index 59b8186a64..902cbb839e 100644 --- a/tools/golang/xenlight/xenlight.go +++ b/tools/golang/xenlight/xenlight.go @@ -1041,7 +1041,7 @@ func (Ctx *Context) DomainShutdown(id Domid) (err error) { return } - ret := C.libxl_domain_shutdown(Ctx.ctx, C.uint32_t(id)) + ret := C.libxl_domain_shutdown(Ctx.ctx, C.uint32_t(id), nil) if ret != 0 { err = Error(-ret) @@ -1056,7 +1056,7 @@ func (Ctx *Context) DomainReboot(id Domid) (err error) { return } - ret := C.libxl_domain_reboot(Ctx.ctx, C.uint32_t(id)) + ret := C.libxl_domain_reboot(Ctx.ctx, C.uint32_t(id), nil) if ret != 0 { err = Error(-ret)