mbox series

[v3,0/7] x86/intel_pmc_core: Add Tiger Lake, Elkhart Lake

Message ID cover.1573750525.git.gayatri.kammela@intel.com (mailing list archive)
Headers show
Series x86/intel_pmc_core: Add Tiger Lake, Elkhart Lake | expand

Message

Kammela, Gayatri Nov. 14, 2019, 5:01 p.m. UTC
Hi,

Patch 1: Fix SoC naming inconsistency
Patch 2: Cleans up termination lines
Patch 3: Refactor driver for ease of adding new SoCs
Patch 4: Add debugfs entry for PCH IPs only if platform supports
Patch 5: Add Tiger Lake legacy support to pmc_core
Patch 6: Add Elkhart Lake legacy support to pmc_core
patch 7: Add Comet Lake legacy support to pmc_core

All the information regarding the PCH IPs and names of IPs will be
available in Intel's Platform Controller Hub (PCH) External Design
Specification (EDS) document expected to be released in 2020 before
product launch.

Changes since v1:
1) Added a patch that fixes the naming inconsistency.
2) Fixed the prefix of all the patches.

Changes since v2:
1) Add Comet Lake legacy support to pmc_core up on Dell's request

Gayatri Kammela (7):
  x86/intel_pmc_core: Fix the SoC naming inconsistency
  x86/intel_pmc_core: Clean up: Remove comma after the termination line
  x86/intel_pmc_core: Create platform dependent pmc bitmap structs
  x86/intel_pmc_core: Make debugfs entry for pch_ip_power_gating_status
    conditional
  platform/x86: Add Tiger Lake (TGL) platform support to intel_pmc_core
    driver
  platform/x86: Add Atom based Elkhart Lake (EHL) platform support to
    intel_pmc_core driver
  platform/x86: Add Comet Lake (CML) platform support to intel_pmc_core
    driver

 drivers/platform/x86/intel_pmc_core.c | 121 ++++++++++++++++++++------
 drivers/platform/x86/intel_pmc_core.h |   2 +-
 2 files changed, 96 insertions(+), 27 deletions(-)

Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Srinivas Pandruvada <srinivas.pandruvada@intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Kan Liang <kan.liang@intel.com>
Cc: David E. Box <david.e.box@intel.com>
Cc: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>
Cc: Tony Luck <tony.luck@intel.com>

Comments

Andy Shevchenko Nov. 18, 2019, 10:50 a.m. UTC | #1
On Thu, Nov 14, 2019 at 7:02 PM Gayatri Kammela
<gayatri.kammela@intel.com> wrote:
>
> Hi,
>
> Patch 1: Fix SoC naming inconsistency
> Patch 2: Cleans up termination lines
> Patch 3: Refactor driver for ease of adding new SoCs
> Patch 4: Add debugfs entry for PCH IPs only if platform supports
> Patch 5: Add Tiger Lake legacy support to pmc_core
> Patch 6: Add Elkhart Lake legacy support to pmc_core
> patch 7: Add Comet Lake legacy support to pmc_core
>
> All the information regarding the PCH IPs and names of IPs will be
> available in Intel's Platform Controller Hub (PCH) External Design
> Specification (EDS) document expected to be released in 2020 before
> product launch.

Thanks, though you forgot to fix all prefixes in the mails. We have
platform/x86: $DRIVER_NAME: ...

Also consider Mario's comment (I didn't hear back from you on it).

>
> Changes since v1:
> 1) Added a patch that fixes the naming inconsistency.
> 2) Fixed the prefix of all the patches.
>
> Changes since v2:
> 1) Add Comet Lake legacy support to pmc_core up on Dell's request
>
> Gayatri Kammela (7):
>   x86/intel_pmc_core: Fix the SoC naming inconsistency
>   x86/intel_pmc_core: Clean up: Remove comma after the termination line
>   x86/intel_pmc_core: Create platform dependent pmc bitmap structs
>   x86/intel_pmc_core: Make debugfs entry for pch_ip_power_gating_status
>     conditional
>   platform/x86: Add Tiger Lake (TGL) platform support to intel_pmc_core
>     driver
>   platform/x86: Add Atom based Elkhart Lake (EHL) platform support to
>     intel_pmc_core driver
>   platform/x86: Add Comet Lake (CML) platform support to intel_pmc_core
>     driver
>
>  drivers/platform/x86/intel_pmc_core.c | 121 ++++++++++++++++++++------
>  drivers/platform/x86/intel_pmc_core.h |   2 +-
>  2 files changed, 96 insertions(+), 27 deletions(-)
>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@intel.com>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Kan Liang <kan.liang@intel.com>
> Cc: David E. Box <david.e.box@intel.com>
> Cc: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>
> Cc: Tony Luck <tony.luck@intel.com>
>
> --
> 2.17.1
>
Kammela, Gayatri Nov. 18, 2019, 6:11 p.m. UTC | #2
> > All the information regarding the PCH IPs and names of IPs will be
> > available in Intel's Platform Controller Hub (PCH) External Design
> > Specification (EDS) document expected to be released in 2020 before
> > product launch.
> 
> Thanks, though you forgot to fix all prefixes in the mails. We have
> platform/x86: $DRIVER_NAME: ...
> 
Hi Andy! Sorry I think I misunderstood your comment last time. Just to make sure, the prefix should the pattern in this case
"platform/x86: intel_pmc_core: " and should be same for all the patches in the series right?

> Also consider Mario's comment (I didn't hear back from you on it).
Sorry about that. I am planning on sending it a single patch excluding it from the series since we received a request from Dell. Please let me know if you think this patch should be included in the series.
Limonciello, Mario Nov. 18, 2019, 6:18 p.m. UTC | #3
> -----Original Message-----
> From: platform-driver-x86-owner@vger.kernel.org <platform-driver-x86-
> owner@vger.kernel.org> On Behalf Of Kammela, Gayatri
> Sent: Monday, November 18, 2019 12:11 PM
> To: Andy Shevchenko
> Cc: Platform Driver; Somayaji, Vishwanath; Darren Hart; Linux Kernel Mailing
> List; Prestopine, Charles D; Peter Zijlstra; Pandruvada, Srinivas; Andy
> Shevchenko; Liang, Kan; Box, David E; Bhardwaj, Rajneesh; Luck, Tony
> Subject: RE: [PATCH v3 0/7] x86/intel_pmc_core: Add Tiger Lake, Elkhart Lake
> 
> 
> [EXTERNAL EMAIL]
> 
> > > All the information regarding the PCH IPs and names of IPs will be
> > > available in Intel's Platform Controller Hub (PCH) External Design
> > > Specification (EDS) document expected to be released in 2020 before
> > > product launch.
> >
> > Thanks, though you forgot to fix all prefixes in the mails. We have
> > platform/x86: $DRIVER_NAME: ...
> >
> Hi Andy! Sorry I think I misunderstood your comment last time. Just to make
> sure, the prefix should the pattern in this case
> "platform/x86: intel_pmc_core: " and should be same for all the patches in the
> series right?
> 
> > Also consider Mario's comment (I didn't hear back from you on it).
> Sorry about that. I am planning on sending it a single patch excluding it from the
> series since we received a request from Dell. Please let me know if you think this
> patch should be included in the series.

Just to make it clear to those on the list - the request from Dell was off list and separately
from my comment in adjusting the ordering.  A convenient side effect is that it will
take into consideration my comment too :)
Andy Shevchenko Nov. 18, 2019, 6:23 p.m. UTC | #4
On Mon, Nov 18, 2019 at 06:11:16PM +0000, Kammela, Gayatri wrote:
> > > All the information regarding the PCH IPs and names of IPs will be
> > > available in Intel's Platform Controller Hub (PCH) External Design
> > > Specification (EDS) document expected to be released in 2020 before
> > > product launch.
> > 
> > Thanks, though you forgot to fix all prefixes in the mails. We have
> > platform/x86: $DRIVER_NAME: ...
> > 
> Hi Andy! Sorry I think I misunderstood your comment last time. Just to make sure, the prefix should the pattern in this case
> "platform/x86: intel_pmc_core: " and should be same for all the patches in the series right?

I didn't deeply check myself, but sounds right.

> > Also consider Mario's comment (I didn't hear back from you on it).
> Sorry about that. I am planning on sending it a single patch excluding it from the series since we received a request from Dell. Please let me know if you think this patch should be included in the series. 

I think we keep good relationship with Dell.
Kammela, Gayatri Nov. 18, 2019, 7:12 p.m. UTC | #5
> >
> > > Also consider Mario's comment (I didn't hear back from you on it).
> > Sorry about that. I am planning on sending it a single patch excluding
> > it from the series since we received a request from Dell. Please let
> > me know if you think this patch should be included in the series.
> 
> Just to make it clear to those on the list - the request from Dell was off list
> and separately from my comment in adjusting the ordering.  A convenient
> side effect is that it will take into consideration my comment too :)
I have just sent v1 of Comet Lake patch in a new series. Thanks Mario! 
Kammela, Gayatri Nov. 18, 2019, 7:15 p.m. UTC | #6
> > Hi Andy! Sorry I think I misunderstood your comment last time. Just to
> > make sure, the prefix should the pattern in this case
> > "platform/x86: intel_pmc_core: " and should be same for all the patches in
> the series right?
> 
> I didn't deeply check myself, but sounds right.
Thanks for confirming!
> 
> > > Also consider Mario's comment (I didn't hear back from you on it).
> > Sorry about that. I am planning on sending it a single patch excluding it from
> the series since we received a request from Dell. Please let me know if you
> think this patch should be included in the series.
> 
> I think we keep good relationship with Dell.
Yeah