| Message ID | 1574157219-22052-2-git-send-email-imbrenda@linux.ibm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | s390x: SCLP Unit test | expand |
On 19/11/2019 10.53, Claudio Imbrenda wrote: > Export sclp_setup_int() so that it can be used from outside. > > Needed for an upocoming unit test. > > Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com> > --- > lib/s390x/sclp.h | 1 + > lib/s390x/sclp.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/s390x/sclp.h b/lib/s390x/sclp.h > index 6d40fb7..675f07e 100644 > --- a/lib/s390x/sclp.h > +++ b/lib/s390x/sclp.h > @@ -265,6 +265,7 @@ typedef struct ReadEventData { > } __attribute__((packed)) ReadEventData; > > extern char _sccb[]; > +void sclp_setup_int(void); > void sclp_handle_ext(void); > void sclp_wait_busy(void); > void sclp_mark_busy(void); > diff --git a/lib/s390x/sclp.c b/lib/s390x/sclp.c > index 7798f04..123b639 100644 > --- a/lib/s390x/sclp.c > +++ b/lib/s390x/sclp.c > @@ -45,7 +45,7 @@ static void mem_init(phys_addr_t mem_end) > page_alloc_ops_enable(); > } > > -static void sclp_setup_int(void) > +void sclp_setup_int(void) > { > uint64_t mask; Reviewed-by: Thomas Huth <thuth@redhat.com>
On 11/19/19 10:53 AM, Claudio Imbrenda wrote: > Export sclp_setup_int() so that it can be used from outside. > > Needed for an upocoming unit test. > > Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com> Reviewed-by: Janosch Frank <frankja@linux.ibm.com> > --- > lib/s390x/sclp.h | 1 + > lib/s390x/sclp.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/s390x/sclp.h b/lib/s390x/sclp.h > index 6d40fb7..675f07e 100644 > --- a/lib/s390x/sclp.h > +++ b/lib/s390x/sclp.h > @@ -265,6 +265,7 @@ typedef struct ReadEventData { > } __attribute__((packed)) ReadEventData; > > extern char _sccb[]; > +void sclp_setup_int(void); > void sclp_handle_ext(void); > void sclp_wait_busy(void); > void sclp_mark_busy(void); > diff --git a/lib/s390x/sclp.c b/lib/s390x/sclp.c > index 7798f04..123b639 100644 > --- a/lib/s390x/sclp.c > +++ b/lib/s390x/sclp.c > @@ -45,7 +45,7 @@ static void mem_init(phys_addr_t mem_end) > page_alloc_ops_enable(); > } > > -static void sclp_setup_int(void) > +void sclp_setup_int(void) > { > uint64_t mask; > >
On 11/19/19 10:53 AM, Claudio Imbrenda wrote: > Export sclp_setup_int() so that it can be used from outside. ... so that it can be used in tests / outside of lib/s390x/sclp.c Choose one > > Needed for an upocoming unit test. upocoming? > > Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com> > --- > lib/s390x/sclp.h | 1 + > lib/s390x/sclp.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/s390x/sclp.h b/lib/s390x/sclp.h > index 6d40fb7..675f07e 100644 > --- a/lib/s390x/sclp.h > +++ b/lib/s390x/sclp.h > @@ -265,6 +265,7 @@ typedef struct ReadEventData { > } __attribute__((packed)) ReadEventData; > > extern char _sccb[]; > +void sclp_setup_int(void); > void sclp_handle_ext(void); > void sclp_wait_busy(void); > void sclp_mark_busy(void); > diff --git a/lib/s390x/sclp.c b/lib/s390x/sclp.c > index 7798f04..123b639 100644 > --- a/lib/s390x/sclp.c > +++ b/lib/s390x/sclp.c > @@ -45,7 +45,7 @@ static void mem_init(phys_addr_t mem_end) > page_alloc_ops_enable(); > } > > -static void sclp_setup_int(void) > +void sclp_setup_int(void) > { > uint64_t mask; > >
diff --git a/lib/s390x/sclp.h b/lib/s390x/sclp.h index 6d40fb7..675f07e 100644 --- a/lib/s390x/sclp.h +++ b/lib/s390x/sclp.h @@ -265,6 +265,7 @@ typedef struct ReadEventData { } __attribute__((packed)) ReadEventData; extern char _sccb[]; +void sclp_setup_int(void); void sclp_handle_ext(void); void sclp_wait_busy(void); void sclp_mark_busy(void); diff --git a/lib/s390x/sclp.c b/lib/s390x/sclp.c index 7798f04..123b639 100644 --- a/lib/s390x/sclp.c +++ b/lib/s390x/sclp.c @@ -45,7 +45,7 @@ static void mem_init(phys_addr_t mem_end) page_alloc_ops_enable(); } -static void sclp_setup_int(void) +void sclp_setup_int(void) { uint64_t mask;
Export sclp_setup_int() so that it can be used from outside. Needed for an upocoming unit test. Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com> --- lib/s390x/sclp.h | 1 + lib/s390x/sclp.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-)