Message ID | 87r2208o9g.wl-kuninori.morimoto.gx@renesas.com (mailing list archive) |
---|---|
Headers | show |
Series | ASoC: soc-core cleanup step6 | expand |
On 11/21/19 11:37 PM, Kuninori Morimoto wrote: > > Hi Mark > > These are soc-core cleanup step6. > These doesn't add new features. Looks mostly good to me, I only have a set of nit-picks. First tests look ok (2 known/unrelated errors) https://sof-ci.01.org/linuxpr/PR1538/build2542/devicetest/ Sounds promising, thanks for all this Morimoto-san. > > Kuninori Morimoto (14): > ASoC: soc-core: remove dai_link_list > ASoC: soc-core: remove snd_soc_disconnect_sync() > ASoC: soc-core: remove snd_soc_get_dai_substream() > ASoC: soc-core: move snd_soc_get_pcm_runtime() > ASoC: soc-core: find rtd via dai_link pointer at snd_soc_get_pcm_runtime() > ASoC: soc-core: move snd_soc_find_dai_link() > ASoC: soc-core: rename snd_soc_add_dai_link() to snd_soc_add_pcm_runtime() > ASoC: soc-core: rename snd_soc_remove_dai_link() to snd_soc_remove_pcm_runtime() > ASoC: soc-core: move soc_link_dai_pcm_new() > ASoC: soc-core: rename soc_link_dai_pcm_new() to soc_dai_pcm_new() > ASoC: soc-core: move soc_link_init() > ASoC: soc-core: rename soc_link_init() to soc_init_pcm_runtime() > ASoC: soc-core: soc_set_name_prefix(): tidyup loop condition > ASoC: soc-core: soc_set_name_prefix(): get component device_node at out of loop > > include/sound/soc.h | 22 +-- > sound/soc/fsl/fsl-asoc-card.c | 2 +- > sound/soc/pxa/mioa701_wm9713.c | 2 +- > sound/soc/samsung/bells.c | 12 +- > sound/soc/samsung/littlemill.c | 10 +- > sound/soc/samsung/snow.c | 2 +- > sound/soc/samsung/speyside.c | 4 +- > sound/soc/samsung/tm2_wm5110.c | 6 +- > sound/soc/samsung/tobermory.c | 6 +- > sound/soc/sh/rcar/core.c | 2 - > sound/soc/soc-core.c | 339 ++++++++++++++++------------------------- > sound/soc/soc-topology.c | 47 +++++- > sound/soc/tegra/tegra_wm8903.c | 2 +- > 13 files changed, 204 insertions(+), 252 deletions(-) >
On Thu, Nov 21, 2019 at 9:39 PM Kuninori Morimoto < kuninori.morimoto.gx@renesas.com> wrote: > > Hi Mark > > These are soc-core cleanup step6. > These doesn't add new features. > > Kuninori Morimoto (14): > ASoC: soc-core: remove dai_link_list > ASoC: soc-core: remove snd_soc_disconnect_sync() > ASoC: soc-core: remove snd_soc_get_dai_substream() > ASoC: soc-core: move snd_soc_get_pcm_runtime() > ASoC: soc-core: find rtd via dai_link pointer at > snd_soc_get_pcm_runtime() > ASoC: soc-core: move snd_soc_find_dai_link() > ASoC: soc-core: rename snd_soc_add_dai_link() to > snd_soc_add_pcm_runtime() > ASoC: soc-core: rename snd_soc_remove_dai_link() to > snd_soc_remove_pcm_runtime() > ASoC: soc-core: move soc_link_dai_pcm_new() > ASoC: soc-core: rename soc_link_dai_pcm_new() to soc_dai_pcm_new() > ASoC: soc-core: move soc_link_init() > ASoC: soc-core: rename soc_link_init() to soc_init_pcm_runtime() > ASoC: soc-core: soc_set_name_prefix(): tidyup loop condition > ASoC: soc-core: soc_set_name_prefix(): get component device_node at out > of loop > Looks good to me, Morimoto-san. Thanks for this cleanup! Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com> > > include/sound/soc.h | 22 +-- > sound/soc/fsl/fsl-asoc-card.c | 2 +- > sound/soc/pxa/mioa701_wm9713.c | 2 +- > sound/soc/samsung/bells.c | 12 +- > sound/soc/samsung/littlemill.c | 10 +- > sound/soc/samsung/snow.c | 2 +- > sound/soc/samsung/speyside.c | 4 +- > sound/soc/samsung/tm2_wm5110.c | 6 +- > sound/soc/samsung/tobermory.c | 6 +- > sound/soc/sh/rcar/core.c | 2 - > sound/soc/soc-core.c | 339 > ++++++++++++++++------------------------- > sound/soc/soc-topology.c | 47 +++++- > sound/soc/tegra/tegra_wm8903.c | 2 +- > 13 files changed, 204 insertions(+), 252 deletions(-) > > -- > 2.7.4 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > https://mailman.alsa-project.org/mailman/listinfo/alsa-devel >
Hi Pierre-Louis Thank you for reviewing, and testing > > These are soc-core cleanup step6. > > These doesn't add new features. > > Looks mostly good to me, I only have a set of nit-picks. > > First tests look ok (2 known/unrelated errors) > https://sof-ci.01.org/linuxpr/PR1538/build2542/devicetest/ > > Sounds promising, thanks for all this Morimoto-san. I will fixup and re-post patches. Thank you for your help !! Best regards --- Kuninori Morimoto
Hi Sridharan Thank you for reviewing > Kuninori Morimoto (14): > ASoC: soc-core: remove dai_link_list > ASoC: soc-core: remove snd_soc_disconnect_sync() > ASoC: soc-core: remove snd_soc_get_dai_substream() > ASoC: soc-core: move snd_soc_get_pcm_runtime() > ASoC: soc-core: find rtd via dai_link pointer at snd_soc_get_pcm_runtime() > ASoC: soc-core: move snd_soc_find_dai_link() > ASoC: soc-core: rename snd_soc_add_dai_link() to snd_soc_add_pcm_runtime() > ASoC: soc-core: rename snd_soc_remove_dai_link() to snd_soc_remove_pcm_runtime() > ASoC: soc-core: move soc_link_dai_pcm_new() > ASoC: soc-core: rename soc_link_dai_pcm_new() to soc_dai_pcm_new() > ASoC: soc-core: move soc_link_init() > ASoC: soc-core: rename soc_link_init() to soc_init_pcm_runtime() > ASoC: soc-core: soc_set_name_prefix(): tidyup loop condition > ASoC: soc-core: soc_set_name_prefix(): get component device_node at out of loop > > Looks good to me, Morimoto-san. Thanks for this cleanup! > Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com> I will post v2 patch with your reviewed-by Thank you for your help !! Best regards --- Kuninori Morimoto