[v4,0/6] s390x: Cleanup

Message

Janosch Frank Nov. 27, 2019, 5:50 p.m. UTC

Adding comments and reordering code for better readability in the
diag308 and machine reset functions. Also making the kvm sclp function
void and refactoring it.

v4
	* Added sclp cleanup
	* Renamed ccpu reset wrapper
	* Added assert to cpu reset function

Janosch Frank (6):
  s390x: Don't do a normal reset on the initial cpu
  s390x: Move reset normal to shared reset handler
  s390x: Move initial reset
  s390x: Move clear reset
  s390x: Beautify diag308 handling
  s390x: kvm: Make kvm_sclp_service_call void

 hw/s390x/s390-virtio-ccw.c |   3 ++
 target/s390x/cpu-qom.h     |   9 +++-
 target/s390x/cpu.c         | 107 ++++++++++++++-----------------------
 target/s390x/cpu.h         |   4 +-
 target/s390x/diag.c        |  54 +++++++++++--------
 target/s390x/kvm.c         |  12 ++---
 target/s390x/sigp.c        |   4 +-
 7 files changed, 91 insertions(+), 102 deletions(-)

Comments

Cornelia Huck Nov. 29, 2019, 10:03 a.m. UTC | #1

On Wed, 27 Nov 2019 12:50:40 -0500
Janosch Frank <[e-mail]> wrote:

> Adding comments and reordering code for better readability in the
> diag308 and machine reset functions. Also making the kvm sclp function
> void and refactoring it.
> 
> v4
> 	* Added sclp cleanup
> 	* Renamed ccpu reset wrapper
> 	* Added assert to cpu reset function
> 
> Janosch Frank (6):
>   s390x: Don't do a normal reset on the initial cpu
>   s390x: Move reset normal to shared reset handler
>   s390x: Move initial reset
>   s390x: Move clear reset
>   s390x: Beautify diag308 handling
>   s390x: kvm: Make kvm_sclp_service_call void
> 
>  hw/s390x/s390-virtio-ccw.c |   3 ++
>  target/s390x/cpu-qom.h     |   9 +++-
>  target/s390x/cpu.c         | 107 ++++++++++++++-----------------------
>  target/s390x/cpu.h         |   4 +-
>  target/s390x/diag.c        |  54 +++++++++++--------
>  target/s390x/kvm.c         |  12 ++---
>  target/s390x/sigp.c        |   4 +-
>  7 files changed, 91 insertions(+), 102 deletions(-)
> 

Thanks, applied.