gitk branch name encoding utf-8 probrem

Commit Message

加藤一博 Dec. 4, 2019, 6:36 p.m. UTC

Hello.

Here is a patch to gitk branch name utf-8 probrem.

See issue
https://github.com/kkato233/gitk/issues/1
and fix it 
https://github.com/kkato233/gitk/pull/2


---

--

--
[e-mail]

Comments

Jonathan Nieder Dec. 4, 2019, 10:29 p.m. UTC | #1

(cc-ing Paul, gitk expert)
Hi!

加藤一博 wrote:

> Here is a patch to gitk branch name utf-8 probrem.

Thanks for reporting it.  Can you provide a short summary here of
the problem that we can use for a self-contained description in the
commit log?  See
https://www.kernel.org/pub/software/scm/git/docs/SubmittingPatches.html#describe-changes
for more on this subject.

May we also have your sign-off?  See
https://www.kernel.org/pub/software/scm/git/docs/SubmittingPatches.html#sign-off
for what this means.

Thanks and hope that helps,
Jonathan

> See issue
> https://github.com/kkato233/gitk/issues/1
> and fix it 
> https://github.com/kkato233/gitk/pull/2
> 
> 
> ---
> 
> diff --git a/gitk b/gitk
> index abe4805..3f61a5b 100755
> --- a/gitk
> +++ b/gitk
> @@ -1780,11 +1780,15 @@ proc readrefs {} {
>      global otherrefids idotherrefs mainhead mainheadid
>      global selecthead selectheadid
>      global hideremotes
> +    global tclencoding
> 
>      foreach v {tagids idtags headids idheads otherrefids idotherrefs} {
>         unset -nocomplain $v
>      }
>      set refd [open [list | git show-ref -d] r]
> +    if {$tclencoding != {}} {
> +       fconfigure $refd -encoding $tclencoding
> +    }
>      while {[gets $refd line] >= 0} {
>         if {[string index $line 40] ne " "} continue
>         set id [string range $line 0 39]

Patch

diff --git a/gitk b/gitk
index abe4805..3f61a5b 100755
--- a/gitk
+++ b/gitk
@@ -1780,11 +1780,15 @@  proc readrefs {} {
     global otherrefids idotherrefs mainhead mainheadid
     global selecthead selectheadid
     global hideremotes
+    global tclencoding

     foreach v {tagids idtags headids idheads otherrefids idotherrefs} {
        unset -nocomplain $v
     }
     set refd [open [list | git show-ref -d] r]
+    if {$tclencoding != {}} {
+       fconfigure $refd -encoding $tclencoding
+    }
     while {[gets $refd line] >= 0} {
        if {[string index $line 40] ne " "} continue
        set id [string range $line 0 39]