| Message ID | 157554844882.11018.13436399905210284553.stgit@devnote2 (mailing list archive) |
|---|---|
| Headers | show |
| Series | selftests: safesetid: Fix some bugs in safesetid test | expand |
On Thu, Dec 5, 2019 at 4:20 AM Masami Hiramatsu <mhiramat@kernel.org> wrote: > > Hi, > > Here is the v2 series to fix build warnings and erorrs on > kselftest safesetid. > This version includes a fix for a runtime error. > > Thank you, > > --- > > Masami Hiramatsu (3): > selftests: safesetid: Move link library to LDLIBS > selftests: safesetid: Check the return value of setuid/setgid > selftests: safesetid: Fix Makefile to set correct test program These 3 fixes look good, thanks. Were you thinking they would go through my SafeSetID tree or is there a dedicated one for selftests? I guess if you're not sure someone else on here can chime in, or I can just take them through my tree if I don't hear anything. > > > tools/testing/selftests/safesetid/Makefile | 5 +++-- > tools/testing/selftests/safesetid/safesetid-test.c | 15 ++++++++++----- > 2 files changed, 13 insertions(+), 7 deletions(-) > > -- > Masami Hiramatsu (Linaro) <mhiramat@kernel.org>
On 12/5/19 9:40 AM, Micah Morton wrote: > On Thu, Dec 5, 2019 at 4:20 AM Masami Hiramatsu <mhiramat@kernel.org> wrote: >> >> Hi, >> >> Here is the v2 series to fix build warnings and erorrs on >> kselftest safesetid. >> This version includes a fix for a runtime error. >> >> Thank you, >> >> --- >> >> Masami Hiramatsu (3): >> selftests: safesetid: Move link library to LDLIBS >> selftests: safesetid: Check the return value of setuid/setgid >> selftests: safesetid: Fix Makefile to set correct test program > > These 3 fixes look good, thanks. Were you thinking they would go > through my SafeSetID tree or is there a dedicated one for selftests? I > guess if you're not sure someone else on here can chime in, or I can > just take them through my tree if I don't hear anything. > Yes. There is a linux-kselftest tree dedicated to selftests. I can take them. >> >> >> tools/testing/selftests/safesetid/Makefile | 5 +++-- >> tools/testing/selftests/safesetid/safesetid-test.c | 15 ++++++++++----- >> 2 files changed, 13 insertions(+), 7 deletions(-) >> >> -- thanks, -- Shuah
On Thu, 5 Dec 2019 09:44:52 -0700 shuah <shuah@kernel.org> wrote: > On 12/5/19 9:40 AM, Micah Morton wrote: > > On Thu, Dec 5, 2019 at 4:20 AM Masami Hiramatsu <mhiramat@kernel.org> wrote: > >> > >> Hi, > >> > >> Here is the v2 series to fix build warnings and erorrs on > >> kselftest safesetid. > >> This version includes a fix for a runtime error. > >> > >> Thank you, > >> > >> --- > >> > >> Masami Hiramatsu (3): > >> selftests: safesetid: Move link library to LDLIBS > >> selftests: safesetid: Check the return value of setuid/setgid > >> selftests: safesetid: Fix Makefile to set correct test program > > > > These 3 fixes look good, thanks. Were you thinking they would go > > through my SafeSetID tree or is there a dedicated one for selftests? I > > guess if you're not sure someone else on here can chime in, or I can > > just take them through my tree if I don't hear anything. > > > > Yes. There is a linux-kselftest tree dedicated to selftests. > I can take them. Thanks Micah and Shuah! > > > >> > >> > >> tools/testing/selftests/safesetid/Makefile | 5 +++-- > >> tools/testing/selftests/safesetid/safesetid-test.c | 15 ++++++++++----- > >> 2 files changed, 13 insertions(+), 7 deletions(-) > >> > >> -- > > thanks, > -- Shuah >
Hi, Here is the v2 series to fix build warnings and erorrs on kselftest safesetid. This version includes a fix for a runtime error. Thank you, --- Masami Hiramatsu (3): selftests: safesetid: Move link library to LDLIBS selftests: safesetid: Check the return value of setuid/setgid selftests: safesetid: Fix Makefile to set correct test program tools/testing/selftests/safesetid/Makefile | 5 +++-- tools/testing/selftests/safesetid/safesetid-test.c | 15 ++++++++++----- 2 files changed, 13 insertions(+), 7 deletions(-) -- Masami Hiramatsu (Linaro) <mhiramat@kernel.org>