mbox series

[v1,00/15] PHY: Update Cadence Torrent PHY driver with reconfiguration

Message ID 1575368005-29797-1-git-send-email-yamonkar@cadence.com (mailing list archive)
Headers show
Series PHY: Update Cadence Torrent PHY driver with reconfiguration | expand

Message

Yuti Amonkar Dec. 3, 2019, 10:13 a.m. UTC 
This patch series applies to the Cadence SD0801 PHY driver. Cadence SD0801 PHY driver
is Torrent PHY driver for Display Port.Torrent PHY is a multiprotocol PHY supporting PHY 
configurations including Display Port,USB and PCIe. 
This patch series first adds display port configuration then updates the driver to make
it a generic Torrent driver and finally adds SoC platform dependent initialization.

The patch series has 15 patches which applies the changes in the below sequence 
1.  001-phy-cadance-dp-Add-DisplayPort-configuration-options
This patch adds generic DisplayPort API for configuring PHY.The parameters configured are
link rate, number of lanes, voltage swing and pre-emphasis.
2. 002-dt-bindings-phy-Convert-Cadence-MHDP-PHY-bindings-to-YAML
This patch converts the MHDP PHY device tree bindings to yaml schemas 
3. 003-phy-cadence-dp-Rename-to-phy-Cadence-Torrent
Rename Cadence DP PHY driver from phy-cadence-dp to phy-cadence-torrent 
4. 004-phy-cadence-torrent-Adopt-Torrent-nomenclature
Update private data structures, module descriptions and functions prefix to Torrent 
5. 005-phy-cadence-torrent-Add-wrapper-for-PHY-register-access
Add a wrapper function to write Torrent PHY registers to improve code readability.
6. 006-phy-cadence-torrent-Add-wrapper-for-DPTX-register-access
Add wrapper functions to read, write DisplayPort specific PHY registers to improve code
readability.
7. 007-phy-cadence-torrent-Refactor-code-for-reusability
Add separate function to set different power state values.
Use of uniform polling timeout value. Check return values of functions for error handling.
8. 008-phy-cadence-torrent-Add clock bindings 
Add Torrent PHY reference clock bindings. 
9. 009-phy-cadence-torrent-Add-19.2-MHz-reference-clock-support
Add configuration functions for 19.2 MHz reference clock support.Add register configurations
for SSC support.
10. 010-phy-cadence-torrent-Add-phy-lane-reset-support
Add reset support for PHY lane group.
11. 011-phy-cadence-torrent-Implement-phy-configure-APIs
Add PHY configuration APIs for link rate, number of lanes, voltage swing and pre-emphasis values.
12. 012-phy-cadence-torrent-Use-regmap
Use regmap for accessing Torrent PHY registers. Update register offsets. Abstract address 
calculation using regmap APIs.
13. 013-phy: cadence-torrent-Use-regmap-to-read-and-write-DPTX-PHY-registers
Use regmap to read and write DPTX specific PHY registers.
14. 014-dt-bindings-phy-phy-cadence-torrent-Add-platform-dependent-compatible-string
Add a new compatible string used for TI SoCs using Torrent PHY.
15. 015-phy-cadence-torrent-Add-platform-dependent-initialization-structure
Add platform dependent initialization data for Torrent PHY used in TI's J721E SoC.


Swapnil Jakhade (8):
  phy: cadence-torrent: Adopt Torrent nomenclature
  phy: cadence-torrent: Add wrapper for PHY register access
  phy: cadence-torrent: Add wrapper for DPTX register access
  phy: cadence-torrent: Refactor code for reusability
  phy: cadence-torrent: Add 19.2 MHz reference clock support
  phy: cadence-torrent: Add PHY lane reset support
  phy: cadence-torrent: Implement PHY configure APIs
  phy: cadence-torrent: Use regmap to read and write DPTX PHY registers

Yuti Amonkar (7):
  phy: Add DisplayPort configuration options
  dt-bindings:phy: Convert Cadence MHDP PHY bindings to YAML.
  phy: cadence-dp: Rename to phy-cadence-torrent
  dt-bindings: phy: phy-cadence-torrent: Add clock bindings
  phy: cadence-torrent: Use regmap to read and write Torrent PHY
    registers
  dt-bindings: phy: phy-cadence-torrent: Add platform dependent
    compatible string
  phy: cadence-torrent: Add platform dependent initialization structure

 .../devicetree/bindings/phy/phy-cadence-dp.txt     |   30 -
 .../bindings/phy/phy-cadence-torrent.yaml          |   66 +
 drivers/phy/cadence/Kconfig                        |    6 +-
 drivers/phy/cadence/Makefile                       |    2 +-
 drivers/phy/cadence/phy-cadence-dp.c               |  541 ------
 drivers/phy/cadence/phy-cadence-torrent.c          | 1824 ++++++++++++++++++++
 include/linux/phy/phy-dp.h                         |   95 +
 include/linux/phy/phy.h                            |    4 +
 8 files changed, 1993 insertions(+), 575 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/phy/phy-cadence-dp.txt
 create mode 100644 Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml
 delete mode 100644 drivers/phy/cadence/phy-cadence-dp.c
 create mode 100644 drivers/phy/cadence/phy-cadence-torrent.c
 create mode 100644 include/linux/phy/phy-dp.h

Comments

Jyri Sarha Dec. 3, 2019, 8:21 p.m. UTC | #1 
Yuti, you have phy maintainer (Kishon) in cc, but you do not have
linux-kernel@vger.kernel.org list mentioned under "GENERIC PHY
FRAMEWORK" entry in the MAINTAINERS file [1]. Please add that to the
recipient list
in the next round.

Best regards,
Jyri

[1] https://www.kernel.org/doc/linux/MAINTAINERS

On 03/12/2019 12:13, Yuti Amonkar wrote:
> This patch series applies to the Cadence SD0801 PHY driver. Cadence SD0801 PHY driver
> is Torrent PHY driver for Display Port.Torrent PHY is a multiprotocol PHY supporting PHY 
> configurations including Display Port,USB and PCIe. 
> This patch series first adds display port configuration then updates the driver to make
> it a generic Torrent driver and finally adds SoC platform dependent initialization.
> 
> The patch series has 15 patches which applies the changes in the below sequence 
> 1.  001-phy-cadance-dp-Add-DisplayPort-configuration-options
> This patch adds generic DisplayPort API for configuring PHY.The parameters configured are
> link rate, number of lanes, voltage swing and pre-emphasis.
> 2. 002-dt-bindings-phy-Convert-Cadence-MHDP-PHY-bindings-to-YAML
> This patch converts the MHDP PHY device tree bindings to yaml schemas 
> 3. 003-phy-cadence-dp-Rename-to-phy-Cadence-Torrent
> Rename Cadence DP PHY driver from phy-cadence-dp to phy-cadence-torrent 
> 4. 004-phy-cadence-torrent-Adopt-Torrent-nomenclature
> Update private data structures, module descriptions and functions prefix to Torrent 
> 5. 005-phy-cadence-torrent-Add-wrapper-for-PHY-register-access
> Add a wrapper function to write Torrent PHY registers to improve code readability.
> 6. 006-phy-cadence-torrent-Add-wrapper-for-DPTX-register-access
> Add wrapper functions to read, write DisplayPort specific PHY registers to improve code
> readability.
> 7. 007-phy-cadence-torrent-Refactor-code-for-reusability
> Add separate function to set different power state values.
> Use of uniform polling timeout value. Check return values of functions for error handling.
> 8. 008-phy-cadence-torrent-Add clock bindings 
> Add Torrent PHY reference clock bindings. 
> 9. 009-phy-cadence-torrent-Add-19.2-MHz-reference-clock-support
> Add configuration functions for 19.2 MHz reference clock support.Add register configurations
> for SSC support.
> 10. 010-phy-cadence-torrent-Add-phy-lane-reset-support
> Add reset support for PHY lane group.
> 11. 011-phy-cadence-torrent-Implement-phy-configure-APIs
> Add PHY configuration APIs for link rate, number of lanes, voltage swing and pre-emphasis values.
> 12. 012-phy-cadence-torrent-Use-regmap
> Use regmap for accessing Torrent PHY registers. Update register offsets. Abstract address 
> calculation using regmap APIs.
> 13. 013-phy: cadence-torrent-Use-regmap-to-read-and-write-DPTX-PHY-registers
> Use regmap to read and write DPTX specific PHY registers.
> 14. 014-dt-bindings-phy-phy-cadence-torrent-Add-platform-dependent-compatible-string
> Add a new compatible string used for TI SoCs using Torrent PHY.
> 15. 015-phy-cadence-torrent-Add-platform-dependent-initialization-structure
> Add platform dependent initialization data for Torrent PHY used in TI's J721E SoC.
> 
> 
> Swapnil Jakhade (8):
>   phy: cadence-torrent: Adopt Torrent nomenclature
>   phy: cadence-torrent: Add wrapper for PHY register access
>   phy: cadence-torrent: Add wrapper for DPTX register access
>   phy: cadence-torrent: Refactor code for reusability
>   phy: cadence-torrent: Add 19.2 MHz reference clock support
>   phy: cadence-torrent: Add PHY lane reset support
>   phy: cadence-torrent: Implement PHY configure APIs
>   phy: cadence-torrent: Use regmap to read and write DPTX PHY registers
> 
> Yuti Amonkar (7):
>   phy: Add DisplayPort configuration options
>   dt-bindings:phy: Convert Cadence MHDP PHY bindings to YAML.
>   phy: cadence-dp: Rename to phy-cadence-torrent
>   dt-bindings: phy: phy-cadence-torrent: Add clock bindings
>   phy: cadence-torrent: Use regmap to read and write Torrent PHY
>     registers
>   dt-bindings: phy: phy-cadence-torrent: Add platform dependent
>     compatible string
>   phy: cadence-torrent: Add platform dependent initialization structure
> 
>  .../devicetree/bindings/phy/phy-cadence-dp.txt     |   30 -
>  .../bindings/phy/phy-cadence-torrent.yaml          |   66 +
>  drivers/phy/cadence/Kconfig                        |    6 +-
>  drivers/phy/cadence/Makefile                       |    2 +-
>  drivers/phy/cadence/phy-cadence-dp.c               |  541 ------
>  drivers/phy/cadence/phy-cadence-torrent.c          | 1824 ++++++++++++++++++++
>  include/linux/phy/phy-dp.h                         |   95 +
>  include/linux/phy/phy.h                            |    4 +
>  8 files changed, 1993 insertions(+), 575 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/phy/phy-cadence-dp.txt
>  create mode 100644 Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml
>  delete mode 100644 drivers/phy/cadence/phy-cadence-dp.c
>  create mode 100644 drivers/phy/cadence/phy-cadence-torrent.c
>  create mode 100644 include/linux/phy/phy-dp.h
>
Kishon Vijay Abraham I Dec. 9, 2019, 8:42 a.m. UTC | #2 
Hi Yuti,

On 04/12/19 1:51 am, Jyri Sarha wrote:
> Yuti, you have phy maintainer (Kishon) in cc, but you do not have
> linux-kernel@vger.kernel.org list mentioned under "GENERIC PHY
> FRAMEWORK" entry in the MAINTAINERS file [1]. Please add that to the
> recipient list
> in the next round.

Can you resend the series with linux-kernel@vger.kernel.org included? 
Just use --subject-prefix="RESEND PATCH" while formatting the patch.

Thanks
Kishon
> 
> Best regards,
> Jyri
> 
> [1] https://www.kernel.org/doc/linux/MAINTAINERS
> 
> On 03/12/2019 12:13, Yuti Amonkar wrote:
>> This patch series applies to the Cadence SD0801 PHY driver. Cadence SD0801 PHY driver
>> is Torrent PHY driver for Display Port.Torrent PHY is a multiprotocol PHY supporting PHY
>> configurations including Display Port,USB and PCIe.
>> This patch series first adds display port configuration then updates the driver to make
>> it a generic Torrent driver and finally adds SoC platform dependent initialization.
>>
>> The patch series has 15 patches which applies the changes in the below sequence
>> 1.  001-phy-cadance-dp-Add-DisplayPort-configuration-options
>> This patch adds generic DisplayPort API for configuring PHY.The parameters configured are
>> link rate, number of lanes, voltage swing and pre-emphasis.
>> 2. 002-dt-bindings-phy-Convert-Cadence-MHDP-PHY-bindings-to-YAML
>> This patch converts the MHDP PHY device tree bindings to yaml schemas
>> 3. 003-phy-cadence-dp-Rename-to-phy-Cadence-Torrent
>> Rename Cadence DP PHY driver from phy-cadence-dp to phy-cadence-torrent
>> 4. 004-phy-cadence-torrent-Adopt-Torrent-nomenclature
>> Update private data structures, module descriptions and functions prefix to Torrent
>> 5. 005-phy-cadence-torrent-Add-wrapper-for-PHY-register-access
>> Add a wrapper function to write Torrent PHY registers to improve code readability.
>> 6. 006-phy-cadence-torrent-Add-wrapper-for-DPTX-register-access
>> Add wrapper functions to read, write DisplayPort specific PHY registers to improve code
>> readability.
>> 7. 007-phy-cadence-torrent-Refactor-code-for-reusability
>> Add separate function to set different power state values.
>> Use of uniform polling timeout value. Check return values of functions for error handling.
>> 8. 008-phy-cadence-torrent-Add clock bindings
>> Add Torrent PHY reference clock bindings.
>> 9. 009-phy-cadence-torrent-Add-19.2-MHz-reference-clock-support
>> Add configuration functions for 19.2 MHz reference clock support.Add register configurations
>> for SSC support.
>> 10. 010-phy-cadence-torrent-Add-phy-lane-reset-support
>> Add reset support for PHY lane group.
>> 11. 011-phy-cadence-torrent-Implement-phy-configure-APIs
>> Add PHY configuration APIs for link rate, number of lanes, voltage swing and pre-emphasis values.
>> 12. 012-phy-cadence-torrent-Use-regmap
>> Use regmap for accessing Torrent PHY registers. Update register offsets. Abstract address
>> calculation using regmap APIs.
>> 13. 013-phy: cadence-torrent-Use-regmap-to-read-and-write-DPTX-PHY-registers
>> Use regmap to read and write DPTX specific PHY registers.
>> 14. 014-dt-bindings-phy-phy-cadence-torrent-Add-platform-dependent-compatible-string
>> Add a new compatible string used for TI SoCs using Torrent PHY.
>> 15. 015-phy-cadence-torrent-Add-platform-dependent-initialization-structure
>> Add platform dependent initialization data for Torrent PHY used in TI's J721E SoC.
>>
>>
>> Swapnil Jakhade (8):
>>    phy: cadence-torrent: Adopt Torrent nomenclature
>>    phy: cadence-torrent: Add wrapper for PHY register access
>>    phy: cadence-torrent: Add wrapper for DPTX register access
>>    phy: cadence-torrent: Refactor code for reusability
>>    phy: cadence-torrent: Add 19.2 MHz reference clock support
>>    phy: cadence-torrent: Add PHY lane reset support
>>    phy: cadence-torrent: Implement PHY configure APIs
>>    phy: cadence-torrent: Use regmap to read and write DPTX PHY registers
>>
>> Yuti Amonkar (7):
>>    phy: Add DisplayPort configuration options
>>    dt-bindings:phy: Convert Cadence MHDP PHY bindings to YAML.
>>    phy: cadence-dp: Rename to phy-cadence-torrent
>>    dt-bindings: phy: phy-cadence-torrent: Add clock bindings
>>    phy: cadence-torrent: Use regmap to read and write Torrent PHY
>>      registers
>>    dt-bindings: phy: phy-cadence-torrent: Add platform dependent
>>      compatible string
>>    phy: cadence-torrent: Add platform dependent initialization structure
>>
>>   .../devicetree/bindings/phy/phy-cadence-dp.txt     |   30 -
>>   .../bindings/phy/phy-cadence-torrent.yaml          |   66 +
>>   drivers/phy/cadence/Kconfig                        |    6 +-
>>   drivers/phy/cadence/Makefile                       |    2 +-
>>   drivers/phy/cadence/phy-cadence-dp.c               |  541 ------
>>   drivers/phy/cadence/phy-cadence-torrent.c          | 1824 ++++++++++++++++++++
>>   include/linux/phy/phy-dp.h                         |   95 +
>>   include/linux/phy/phy.h                            |    4 +
>>   8 files changed, 1993 insertions(+), 575 deletions(-)
>>   delete mode 100644 Documentation/devicetree/bindings/phy/phy-cadence-dp.txt
>>   create mode 100644 Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml
>>   delete mode 100644 drivers/phy/cadence/phy-cadence-dp.c
>>   create mode 100644 drivers/phy/cadence/phy-cadence-torrent.c
>>   create mode 100644 include/linux/phy/phy-dp.h
>>
> 
>