| Message ID | 20191113021720.9527-1-weiyongjun1@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 751438bc0f10f75633144acd6ff145f7260706d5 |
| Headers | show |
| Series | [-next] rtc: mt6397: drop free_irq of devm_ allocated irq | expand |
On 13/11/2019 02:17:20+0000, Wei Yongjun wrote: > The devm_request_threaded_irq function allocates irq that is > released when a driver detaches. Thus, there is no reason to > explicitly call free_irq in probe function. > > Fixes: 851b87148aa2 ("rtc: mt6397: improvements of rtc driver") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- > drivers/rtc/rtc-mt6397.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > Applied, thanks.
diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c index 5249fc99fd5f..6c585cd1ce10 100644 --- a/drivers/rtc/rtc-mt6397.c +++ b/drivers/rtc/rtc-mt6397.c @@ -286,15 +286,7 @@ static int mtk_rtc_probe(struct platform_device *pdev) rtc->rtc_dev->ops = &mtk_rtc_ops; - ret = rtc_register_device(rtc->rtc_dev); - if (ret) - goto out_free_irq; - - return 0; - -out_free_irq: - free_irq(rtc->irq, rtc); - return ret; + return rtc_register_device(rtc->rtc_dev); } #ifdef CONFIG_PM_SLEEP
The devm_request_threaded_irq function allocates irq that is released when a driver detaches. Thus, there is no reason to explicitly call free_irq in probe function. Fixes: 851b87148aa2 ("rtc: mt6397: improvements of rtc driver") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- drivers/rtc/rtc-mt6397.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-)