| Message ID | 20191210145345.11616-14-sudeep.holla@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | firmware: arm_scmi: Add support for multiple device per protocol | expand |
On 10-12-19, 14:53, Sudeep Holla wrote: > The scmi bus now has support to match the driver with devices not only > based on their protocol id but also based on their device name if one is > available. This was added to cater the need to support multiple devices > and drivers for the same protocol. > > Let us add the name "cpufreq" to scmi_device_id table in the driver so > that in matches only with device with the same name and protocol id > SCMI_PROTOCOL_PERF. This will help to add "devfreq" device/driver. > > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > Cc: Viresh Kumar <viresh.kumar@linaro.org> > Cc: linux-pm@vger.kernel.org > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > --- > drivers/cpufreq/scmi-cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c > index e6182c89df79..61623e2ff149 100644 > --- a/drivers/cpufreq/scmi-cpufreq.c > +++ b/drivers/cpufreq/scmi-cpufreq.c > @@ -261,7 +261,7 @@ static void scmi_cpufreq_remove(struct scmi_device *sdev) > } > > static const struct scmi_device_id scmi_id_table[] = { > - { SCMI_PROTOCOL_PERF }, > + { SCMI_PROTOCOL_PERF, "cpufreq" }, > { }, > }; > MODULE_DEVICE_TABLE(scmi, scmi_id_table); Applied. Thanks.
On Wed, Dec 11, 2019 at 08:09:09AM +0530, Viresh Kumar wrote: > On 10-12-19, 14:53, Sudeep Holla wrote: > > The scmi bus now has support to match the driver with devices not only > > based on their protocol id but also based on their device name if one is > > available. This was added to cater the need to support multiple devices > > and drivers for the same protocol. > > > > Let us add the name "cpufreq" to scmi_device_id table in the driver so > > that in matches only with device with the same name and protocol id > > SCMI_PROTOCOL_PERF. This will help to add "devfreq" device/driver. > > > > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > > Cc: Viresh Kumar <viresh.kumar@linaro.org> > > Cc: linux-pm@vger.kernel.org > > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > > --- > > drivers/cpufreq/scmi-cpufreq.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c > > index e6182c89df79..61623e2ff149 100644 > > --- a/drivers/cpufreq/scmi-cpufreq.c > > +++ b/drivers/cpufreq/scmi-cpufreq.c > > @@ -261,7 +261,7 @@ static void scmi_cpufreq_remove(struct scmi_device *sdev) > > } > > > > static const struct scmi_device_id scmi_id_table[] = { > > - { SCMI_PROTOCOL_PERF }, > > + { SCMI_PROTOCOL_PERF, "cpufreq" }, > > { }, > > }; > > MODULE_DEVICE_TABLE(scmi, scmi_id_table); > > Applied. Thanks. This will break the build without patch 1/15, so preferably must go as part of the series. Sorry for not missing to specify that detail. -- Regards, Sudeep
On 11-12-19, 10:13, Sudeep Holla wrote: > On Wed, Dec 11, 2019 at 08:09:09AM +0530, Viresh Kumar wrote: > > On 10-12-19, 14:53, Sudeep Holla wrote: > > > The scmi bus now has support to match the driver with devices not only > > > based on their protocol id but also based on their device name if one is > > > available. This was added to cater the need to support multiple devices > > > and drivers for the same protocol. > > > > > > Let us add the name "cpufreq" to scmi_device_id table in the driver so > > > that in matches only with device with the same name and protocol id > > > SCMI_PROTOCOL_PERF. This will help to add "devfreq" device/driver. > > > > > > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > > > Cc: Viresh Kumar <viresh.kumar@linaro.org> > > > Cc: linux-pm@vger.kernel.org > > > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > > > --- > > > drivers/cpufreq/scmi-cpufreq.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c > > > index e6182c89df79..61623e2ff149 100644 > > > --- a/drivers/cpufreq/scmi-cpufreq.c > > > +++ b/drivers/cpufreq/scmi-cpufreq.c > > > @@ -261,7 +261,7 @@ static void scmi_cpufreq_remove(struct scmi_device *sdev) > > > } > > > > > > static const struct scmi_device_id scmi_id_table[] = { > > > - { SCMI_PROTOCOL_PERF }, > > > + { SCMI_PROTOCOL_PERF, "cpufreq" }, > > > { }, > > > }; > > > MODULE_DEVICE_TABLE(scmi, scmi_id_table); > > > > Applied. Thanks. > > This will break the build without patch 1/15, so preferably must go as > part of the series. Sorry for not missing to specify that detail. Dropped now. Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c index e6182c89df79..61623e2ff149 100644 --- a/drivers/cpufreq/scmi-cpufreq.c +++ b/drivers/cpufreq/scmi-cpufreq.c @@ -261,7 +261,7 @@ static void scmi_cpufreq_remove(struct scmi_device *sdev) } static const struct scmi_device_id scmi_id_table[] = { - { SCMI_PROTOCOL_PERF }, + { SCMI_PROTOCOL_PERF, "cpufreq" }, { }, }; MODULE_DEVICE_TABLE(scmi, scmi_id_table);
The scmi bus now has support to match the driver with devices not only based on their protocol id but also based on their device name if one is available. This was added to cater the need to support multiple devices and drivers for the same protocol. Let us add the name "cpufreq" to scmi_device_id table in the driver so that in matches only with device with the same name and protocol id SCMI_PROTOCOL_PERF. This will help to add "devfreq" device/driver. Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> Cc: Viresh Kumar <viresh.kumar@linaro.org> Cc: linux-pm@vger.kernel.org Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> --- drivers/cpufreq/scmi-cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1